Compare commits
18
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
f96df3222d | ||
|
|
84dea8ea5d | ||
|
|
a6e414853d | ||
|
|
728ae68811 | ||
|
|
2eb8bff1c4 | ||
|
|
e68afba6a5 | ||
|
|
a1b0351048 | ||
|
|
de8560948a | ||
|
|
8eddbfe438 | ||
|
|
911355ae35 | ||
|
|
573f54afd2 | ||
|
|
1acc296541 | ||
|
|
06fcc16c02 | ||
|
|
b8f1d88d6e | ||
|
|
19fea892f3 | ||
|
|
c6f80e243d | ||
|
|
8a2c7de8ca | ||
|
|
f33a0739c2 |
@@ -26,3 +26,7 @@ SECURE_COOKIE=0
|
|||||||
# SPACES_BUCKET=your-bucket
|
# SPACES_BUCKET=your-bucket
|
||||||
# SPACES_ENDPOINT=https://nyc3.digitaloceanspaces.com
|
# SPACES_ENDPOINT=https://nyc3.digitaloceanspaces.com
|
||||||
# SPACES_CDN_BASE=https://your-bucket.nyc3.cdn.digitaloceanspaces.com
|
# SPACES_CDN_BASE=https://your-bucket.nyc3.cdn.digitaloceanspaces.com
|
||||||
|
# Discord bot subscriber. Leave unset to disable.
|
||||||
|
# DISCORD_BOT_TOKEN=
|
||||||
|
# DISCORD_CHANNEL_ID=
|
||||||
|
# DISCORD_ADMIN_MAP=123456789012345678:plumber,234567890123456789:otheradmin
|
||||||
|
|||||||
+17
-3
@@ -17,6 +17,8 @@ import (
|
|||||||
|
|
||||||
"plumber"
|
"plumber"
|
||||||
"plumber/internal/blob"
|
"plumber/internal/blob"
|
||||||
|
"plumber/internal/discord"
|
||||||
|
"plumber/internal/events"
|
||||||
"plumber/internal/mail"
|
"plumber/internal/mail"
|
||||||
"plumber/internal/store"
|
"plumber/internal/store"
|
||||||
"plumber/internal/web"
|
"plumber/internal/web"
|
||||||
@@ -34,7 +36,17 @@ func main() {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
log.Fatalf("mail: %v", err)
|
log.Fatalf("mail: %v", err)
|
||||||
}
|
}
|
||||||
handler := newHandler(db, sessions, uploader, notifier)
|
bus := events.New()
|
||||||
|
mail.Subscribe(bus, store.NewPostgres(db), notifier)
|
||||||
|
events.SubscribeRelease(bus)
|
||||||
|
bot, err := discord.FromEnv(store.NewDiscordLinks(db), bus, store.NewPostgres(db))
|
||||||
|
if err != nil {
|
||||||
|
log.Fatalf("discord: %v", err)
|
||||||
|
}
|
||||||
|
if bot != nil {
|
||||||
|
defer bot.Close()
|
||||||
|
}
|
||||||
|
handler := newHandler(db, sessions, uploader, bus, bot != nil)
|
||||||
run(&http.Server{
|
run(&http.Server{
|
||||||
Addr: listenAddr(),
|
Addr: listenAddr(),
|
||||||
Handler: handler,
|
Handler: handler,
|
||||||
@@ -58,13 +70,15 @@ func openDB() (*sql.DB, *store.SessionStore) {
|
|||||||
return db, sessions
|
return db, sessions
|
||||||
}
|
}
|
||||||
|
|
||||||
func newHandler(db *sql.DB, sessions *store.SessionStore, uploader blob.Uploader, notifier mail.Notifier) http.Handler {
|
func newHandler(db *sql.DB, sessions *store.SessionStore, uploader blob.Uploader, bus events.Publisher, holdUploads bool) http.Handler {
|
||||||
srv, err := web.New(store.NewPostgres(db), sessions.Store(), plumber.TemplateFS, plumber.StaticFS, web.Config{
|
srv, err := web.New(store.NewPostgres(db), sessions.Store(), plumber.TemplateFS, plumber.StaticFS, web.Config{
|
||||||
AdminSetupSecret: strings.TrimSpace(os.Getenv("ADMIN_SETUP_SECRET")),
|
AdminSetupSecret: strings.TrimSpace(os.Getenv("ADMIN_SETUP_SECRET")),
|
||||||
SecureCookie: secureCookieFromEnv(),
|
SecureCookie: secureCookieFromEnv(),
|
||||||
TrustedProxies: parseTrustedProxies(os.Getenv("TRUSTED_PROXY_CIDRS")),
|
TrustedProxies: parseTrustedProxies(os.Getenv("TRUSTED_PROXY_CIDRS")),
|
||||||
Blob: uploader,
|
Blob: uploader,
|
||||||
Mail: notifier,
|
Events: bus,
|
||||||
|
BaseURL: strings.TrimRight(strings.TrimSpace(os.Getenv("APP_BASE_URL")), "/"),
|
||||||
|
HoldUploadUntilDiscord: holdUploads,
|
||||||
})
|
})
|
||||||
if err != nil {
|
if err != nil {
|
||||||
log.Fatalf("server: %v", err)
|
log.Fatalf("server: %v", err)
|
||||||
|
|||||||
@@ -0,0 +1,32 @@
|
|||||||
|
-- name: GetDiscordPostLinkByPostID :one
|
||||||
|
SELECT post_id, discord_message_id, discord_thread_id, created_at
|
||||||
|
FROM discord_post_links
|
||||||
|
WHERE post_id = sqlc.arg(post_id);
|
||||||
|
|
||||||
|
-- name: GetDiscordPostLinkByMessageID :one
|
||||||
|
SELECT post_id, discord_message_id, discord_thread_id, created_at
|
||||||
|
FROM discord_post_links
|
||||||
|
WHERE discord_message_id = sqlc.arg(discord_message_id);
|
||||||
|
|
||||||
|
-- name: GetDiscordPostLinkByThreadID :one
|
||||||
|
SELECT post_id, discord_message_id, discord_thread_id, created_at
|
||||||
|
FROM discord_post_links
|
||||||
|
WHERE discord_thread_id = sqlc.arg(discord_thread_id)
|
||||||
|
AND discord_thread_id <> '';
|
||||||
|
|
||||||
|
-- name: UpsertDiscordPostLink :exec
|
||||||
|
INSERT INTO discord_post_links (
|
||||||
|
post_id, discord_message_id, discord_thread_id, created_at
|
||||||
|
)
|
||||||
|
VALUES (
|
||||||
|
sqlc.arg(post_id),
|
||||||
|
sqlc.arg(discord_message_id),
|
||||||
|
sqlc.arg(discord_thread_id),
|
||||||
|
sqlc.arg(created_at)
|
||||||
|
)
|
||||||
|
ON CONFLICT (post_id) DO UPDATE SET
|
||||||
|
discord_message_id = EXCLUDED.discord_message_id,
|
||||||
|
discord_thread_id = CASE
|
||||||
|
WHEN EXCLUDED.discord_thread_id <> '' THEN EXCLUDED.discord_thread_id
|
||||||
|
ELSE discord_post_links.discord_thread_id
|
||||||
|
END;
|
||||||
@@ -61,6 +61,53 @@ SET
|
|||||||
updated_at = sqlc.arg(updated_at)
|
updated_at = sqlc.arg(updated_at)
|
||||||
WHERE id = sqlc.arg(id);
|
WHERE id = sqlc.arg(id);
|
||||||
|
|
||||||
|
-- name: CreatePostImage :exec
|
||||||
|
INSERT INTO post_images (
|
||||||
|
id, post_id, object_key, public_url, description, kind, position, width, height, created_at
|
||||||
|
)
|
||||||
|
VALUES (
|
||||||
|
sqlc.arg(id),
|
||||||
|
sqlc.arg(post_id),
|
||||||
|
sqlc.arg(object_key),
|
||||||
|
sqlc.arg(public_url),
|
||||||
|
sqlc.arg(description),
|
||||||
|
sqlc.arg(kind),
|
||||||
|
sqlc.arg(position),
|
||||||
|
sqlc.arg(width),
|
||||||
|
sqlc.arg(height),
|
||||||
|
sqlc.arg(created_at)
|
||||||
|
);
|
||||||
|
|
||||||
|
-- name: DeletePostImages :exec
|
||||||
|
DELETE FROM post_images
|
||||||
|
WHERE post_id = sqlc.arg(post_id);
|
||||||
|
|
||||||
|
-- name: ListPostImages :many
|
||||||
|
SELECT
|
||||||
|
id, post_id, object_key, public_url, description, kind, position, width, height, created_at
|
||||||
|
FROM post_images
|
||||||
|
WHERE post_id = sqlc.arg(post_id)
|
||||||
|
ORDER BY position;
|
||||||
|
|
||||||
|
-- name: ListPostThreadImages :many
|
||||||
|
WITH RECURSIVE thread AS (
|
||||||
|
SELECT p.id
|
||||||
|
FROM posts p
|
||||||
|
WHERE p.id = sqlc.arg(root_id) AND p.parent_id IS NULL
|
||||||
|
|
||||||
|
UNION ALL
|
||||||
|
|
||||||
|
SELECT child.id
|
||||||
|
FROM posts child
|
||||||
|
JOIN thread parent ON child.parent_id = parent.id
|
||||||
|
)
|
||||||
|
SELECT
|
||||||
|
images.id, images.post_id, images.object_key, images.public_url,
|
||||||
|
images.description, images.kind, images.position, images.width, images.height, images.created_at
|
||||||
|
FROM post_images images
|
||||||
|
JOIN thread ON thread.id = images.post_id
|
||||||
|
ORDER BY images.post_id, images.position;
|
||||||
|
|
||||||
-- name: UpdateRootPostState :execrows
|
-- name: UpdateRootPostState :execrows
|
||||||
UPDATE posts
|
UPDATE posts
|
||||||
SET
|
SET
|
||||||
|
|||||||
@@ -7,10 +7,14 @@ require (
|
|||||||
github.com/aws/aws-sdk-go-v2 v1.43.7
|
github.com/aws/aws-sdk-go-v2 v1.43.7
|
||||||
github.com/aws/aws-sdk-go-v2/credentials v1.19.37
|
github.com/aws/aws-sdk-go-v2/credentials v1.19.37
|
||||||
github.com/aws/aws-sdk-go-v2/service/s3 v1.107.3
|
github.com/aws/aws-sdk-go-v2/service/s3 v1.107.3
|
||||||
|
github.com/aws/smithy-go v1.27.8
|
||||||
|
github.com/bwmarrin/discordgo v0.29.0
|
||||||
github.com/go-chi/chi/v5 v5.3.1
|
github.com/go-chi/chi/v5 v5.3.1
|
||||||
github.com/google/uuid v1.6.0
|
github.com/google/uuid v1.6.0
|
||||||
github.com/jackc/pgx/v5 v5.10.0
|
github.com/jackc/pgx/v5 v5.10.0
|
||||||
github.com/joho/godotenv v1.5.1
|
github.com/joho/godotenv v1.5.1
|
||||||
|
github.com/resend/resend-go/v3 v3.16.0
|
||||||
|
github.com/rwcarlsen/goexif v0.0.0-20190401172101-9e8deecbddbd
|
||||||
golang.org/x/crypto v0.55.0
|
golang.org/x/crypto v0.55.0
|
||||||
golang.org/x/image v0.45.0
|
golang.org/x/image v0.45.0
|
||||||
)
|
)
|
||||||
@@ -24,11 +28,11 @@ require (
|
|||||||
github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.9.31 // indirect
|
github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.9.31 // indirect
|
||||||
github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.13.38 // indirect
|
github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.13.38 // indirect
|
||||||
github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.19.39 // indirect
|
github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.19.39 // indirect
|
||||||
github.com/aws/smithy-go v1.27.8 // indirect
|
github.com/gorilla/websocket v1.4.2 // indirect
|
||||||
github.com/jackc/pgpassfile v1.0.0 // indirect
|
github.com/jackc/pgpassfile v1.0.0 // indirect
|
||||||
github.com/jackc/pgservicefile v0.0.0-20240606120523-5a60cdf6a761 // indirect
|
github.com/jackc/pgservicefile v0.0.0-20240606120523-5a60cdf6a761 // indirect
|
||||||
github.com/jackc/puddle/v2 v2.2.2 // indirect
|
github.com/jackc/puddle/v2 v2.2.2 // indirect
|
||||||
github.com/resend/resend-go/v3 v3.16.0 // indirect
|
|
||||||
golang.org/x/sync v0.22.0 // indirect
|
golang.org/x/sync v0.22.0 // indirect
|
||||||
|
golang.org/x/sys v0.47.0 // indirect
|
||||||
golang.org/x/text v0.41.0 // indirect
|
golang.org/x/text v0.41.0 // indirect
|
||||||
)
|
)
|
||||||
|
|||||||
@@ -24,6 +24,8 @@ github.com/aws/aws-sdk-go-v2/service/s3 v1.107.3 h1:IKoCZqfWfZzSBi16QFQ+QcbQ3LRQ
|
|||||||
github.com/aws/aws-sdk-go-v2/service/s3 v1.107.3/go.mod h1:RBpRcXiM4s2pOInVs32GsBonnje+fiAj4mcrStRmlCA=
|
github.com/aws/aws-sdk-go-v2/service/s3 v1.107.3/go.mod h1:RBpRcXiM4s2pOInVs32GsBonnje+fiAj4mcrStRmlCA=
|
||||||
github.com/aws/smithy-go v1.27.8 h1:FR0dxZfIlV7Z8eh2iHfIofdunw382XsDV3Mxt9nUvRY=
|
github.com/aws/smithy-go v1.27.8 h1:FR0dxZfIlV7Z8eh2iHfIofdunw382XsDV3Mxt9nUvRY=
|
||||||
github.com/aws/smithy-go v1.27.8/go.mod h1:YE2RhdIuDbA5E5bTdciG9KrW3+TiEONeUWCqxX9i1Fc=
|
github.com/aws/smithy-go v1.27.8/go.mod h1:YE2RhdIuDbA5E5bTdciG9KrW3+TiEONeUWCqxX9i1Fc=
|
||||||
|
github.com/bwmarrin/discordgo v0.29.0 h1:FmWeXFaKUwrcL3Cx65c20bTRW+vOb6k8AnaP+EgjDno=
|
||||||
|
github.com/bwmarrin/discordgo v0.29.0/go.mod h1:NJZpH+1AfhIcyQsPeuBKsUtYrRnjkyu0kIVMCHkZtRY=
|
||||||
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
|
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
|
||||||
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
|
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
|
||||||
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
|
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
|
||||||
@@ -31,6 +33,8 @@ github.com/go-chi/chi/v5 v5.3.1 h1:3j4HZLGZQ3JpMCrPJF/Jl3mYJfWLKBfNJ6quurUGCf8=
|
|||||||
github.com/go-chi/chi/v5 v5.3.1/go.mod h1:R+tYY2hNuVUUjxoPtqUdgBqevM9s9njzkTLutVsOCto=
|
github.com/go-chi/chi/v5 v5.3.1/go.mod h1:R+tYY2hNuVUUjxoPtqUdgBqevM9s9njzkTLutVsOCto=
|
||||||
github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
|
github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
|
||||||
github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
|
github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
|
||||||
|
github.com/gorilla/websocket v1.4.2 h1:+/TMaTYc4QFitKJxsQ7Yye35DkWvkdLcvGKqM+x0Ufc=
|
||||||
|
github.com/gorilla/websocket v1.4.2/go.mod h1:YR8l580nyteQvAITg2hZ9XVh4b55+EU/adAjf1fMHhE=
|
||||||
github.com/jackc/pgpassfile v1.0.0 h1:/6Hmqy13Ss2zCq62VdNG8tM1wchn8zjSGOBJ6icpsIM=
|
github.com/jackc/pgpassfile v1.0.0 h1:/6Hmqy13Ss2zCq62VdNG8tM1wchn8zjSGOBJ6icpsIM=
|
||||||
github.com/jackc/pgpassfile v1.0.0/go.mod h1:CEx0iS5ambNFdcRtxPj5JhEz+xB6uRky5eyVu/W2HEg=
|
github.com/jackc/pgpassfile v1.0.0/go.mod h1:CEx0iS5ambNFdcRtxPj5JhEz+xB6uRky5eyVu/W2HEg=
|
||||||
github.com/jackc/pgservicefile v0.0.0-20240606120523-5a60cdf6a761 h1:iCEnooe7UlwOQYpKFhBabPMi4aNAfoODPEFNiAnClxo=
|
github.com/jackc/pgservicefile v0.0.0-20240606120523-5a60cdf6a761 h1:iCEnooe7UlwOQYpKFhBabPMi4aNAfoODPEFNiAnClxo=
|
||||||
@@ -45,19 +49,29 @@ github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZb
|
|||||||
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
|
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
|
||||||
github.com/resend/resend-go/v3 v3.16.0 h1:t0Z/7k2sxnJGw8SjsCM9O8qkq3YRRHzTxWQNjhF2KhE=
|
github.com/resend/resend-go/v3 v3.16.0 h1:t0Z/7k2sxnJGw8SjsCM9O8qkq3YRRHzTxWQNjhF2KhE=
|
||||||
github.com/resend/resend-go/v3 v3.16.0/go.mod h1:iI7VA0NoGjWvsNii5iNC5Dy0llsI3HncXPejhniYzwE=
|
github.com/resend/resend-go/v3 v3.16.0/go.mod h1:iI7VA0NoGjWvsNii5iNC5Dy0llsI3HncXPejhniYzwE=
|
||||||
|
github.com/rwcarlsen/goexif v0.0.0-20190401172101-9e8deecbddbd h1:CmH9+J6ZSsIjUK3dcGsnCnO41eRBOnY12zwkn5qVwgc=
|
||||||
|
github.com/rwcarlsen/goexif v0.0.0-20190401172101-9e8deecbddbd/go.mod h1:hPqNNc0+uJM6H+SuU8sEs5K5IQeKccPqeSjfgcKGgPk=
|
||||||
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
|
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
|
||||||
github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
|
github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
|
||||||
github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
|
github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
|
||||||
github.com/stretchr/testify v1.11.1 h1:7s2iGBzp5EwR7/aIZr8ao5+dra3wiQyKjjFuvgVKu7U=
|
github.com/stretchr/testify v1.11.1 h1:7s2iGBzp5EwR7/aIZr8ao5+dra3wiQyKjjFuvgVKu7U=
|
||||||
github.com/stretchr/testify v1.11.1/go.mod h1:wZwfW3scLgRK+23gO65QZefKpKQRnfz6sD981Nm4B6U=
|
github.com/stretchr/testify v1.11.1/go.mod h1:wZwfW3scLgRK+23gO65QZefKpKQRnfz6sD981Nm4B6U=
|
||||||
|
golang.org/x/crypto v0.0.0-20210421170649-83a5a9bb288b/go.mod h1:T9bdIzuCu7OtxOm1hfPfRQxPLYneinmdGuTeoZ9dtd4=
|
||||||
golang.org/x/crypto v0.55.0 h1:+KWHjbgOaAQ66dh/YlkZKHlz9ZUlq61AFirAR9ntP8M=
|
golang.org/x/crypto v0.55.0 h1:+KWHjbgOaAQ66dh/YlkZKHlz9ZUlq61AFirAR9ntP8M=
|
||||||
golang.org/x/crypto v0.55.0/go.mod h1:uq0V9dE/fzQuJtbnL+2EhWOE63vo164FY8xqEnV9xis=
|
golang.org/x/crypto v0.55.0/go.mod h1:uq0V9dE/fzQuJtbnL+2EhWOE63vo164FY8xqEnV9xis=
|
||||||
golang.org/x/image v0.45.0 h1:FMb1nTbH5H9vF55SriQHgFw5GnNL9Jg6L25BwXKzhB0=
|
golang.org/x/image v0.45.0 h1:FMb1nTbH5H9vF55SriQHgFw5GnNL9Jg6L25BwXKzhB0=
|
||||||
golang.org/x/image v0.45.0/go.mod h1:n62x/7RqlwXDvGsSU4u6IUTUf6KghUZ9Bt7cG/T9Fx4=
|
golang.org/x/image v0.45.0/go.mod h1:n62x/7RqlwXDvGsSU4u6IUTUf6KghUZ9Bt7cG/T9Fx4=
|
||||||
|
golang.org/x/net v0.0.0-20210226172049-e18ecbb05110/go.mod h1:m0MpNAwzfU5UDzcl9v0D8zg8gWTRqZa9RBIspLL5mdg=
|
||||||
golang.org/x/sync v0.22.0 h1:SZjpbeLmrCk4xhRSZFNZW5gFUeCeFgjekvI/+gfScek=
|
golang.org/x/sync v0.22.0 h1:SZjpbeLmrCk4xhRSZFNZW5gFUeCeFgjekvI/+gfScek=
|
||||||
golang.org/x/sync v0.22.0/go.mod h1:9xrNwdLfx4jkKbNva9FpL6vEN7evnE43NNNJQ2LF3+0=
|
golang.org/x/sync v0.22.0/go.mod h1:9xrNwdLfx4jkKbNva9FpL6vEN7evnE43NNNJQ2LF3+0=
|
||||||
|
golang.org/x/sys v0.0.0-20201119102817-f84b799fce68/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
|
||||||
|
golang.org/x/sys v0.47.0 h1:o7XGOvZQCADBQQ4Y7VNq2dRWQR7JmOUW8Kxx4ZsNgWs=
|
||||||
|
golang.org/x/sys v0.47.0/go.mod h1:4GL1E5IUh+htKOUEOaiffhrAeqysfVGipDYzABqnCmw=
|
||||||
|
golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
|
||||||
|
golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
|
||||||
golang.org/x/text v0.41.0 h1:vz/seA0lnX87Othu2f/0L24RcgrXD9/YFTSuGjj3rH8=
|
golang.org/x/text v0.41.0 h1:vz/seA0lnX87Othu2f/0L24RcgrXD9/YFTSuGjj3rH8=
|
||||||
golang.org/x/text v0.41.0/go.mod h1:jvf1O8ajNzZqhSrQBPbutR/EB83Cc0CFrezNQIwbb5M=
|
golang.org/x/text v0.41.0/go.mod h1:jvf1O8ajNzZqhSrQBPbutR/EB83Cc0CFrezNQIwbb5M=
|
||||||
|
golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
|
||||||
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
|
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
|
||||||
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
|
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
|
||||||
gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
|
gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
|
||||||
|
|||||||
@@ -8,9 +8,11 @@ import (
|
|||||||
"strings"
|
"strings"
|
||||||
|
|
||||||
"github.com/aws/aws-sdk-go-v2/aws"
|
"github.com/aws/aws-sdk-go-v2/aws"
|
||||||
|
v4 "github.com/aws/aws-sdk-go-v2/aws/signer/v4"
|
||||||
"github.com/aws/aws-sdk-go-v2/credentials"
|
"github.com/aws/aws-sdk-go-v2/credentials"
|
||||||
"github.com/aws/aws-sdk-go-v2/service/s3"
|
"github.com/aws/aws-sdk-go-v2/service/s3"
|
||||||
"github.com/aws/aws-sdk-go-v2/service/s3/types"
|
"github.com/aws/aws-sdk-go-v2/service/s3/types"
|
||||||
|
"github.com/aws/smithy-go/middleware"
|
||||||
)
|
)
|
||||||
|
|
||||||
// Uploader stores public avatar objects.
|
// Uploader stores public avatar objects.
|
||||||
@@ -81,10 +83,23 @@ func NewSpaces(cfg SpacesConfig) Uploader {
|
|||||||
Region: cfg.Region,
|
Region: cfg.Region,
|
||||||
Credentials: credentials.NewStaticCredentialsProvider(cfg.Key, cfg.Secret, ""),
|
Credentials: credentials.NewStaticCredentialsProvider(cfg.Key, cfg.Secret, ""),
|
||||||
BaseEndpoint: aws.String(cfg.Endpoint),
|
BaseEndpoint: aws.String(cfg.Endpoint),
|
||||||
|
RequestChecksumCalculation: aws.RequestChecksumCalculationWhenRequired,
|
||||||
|
APIOptions: []func(*middleware.Stack) error{
|
||||||
|
spacesUnsignedPayload,
|
||||||
|
},
|
||||||
})
|
})
|
||||||
return &spaces{client: client, cfg: cfg}
|
return &spaces{client: client, cfg: cfg}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// spacesUnsignedPayload signs Spaces PUTs as UNSIGNED-PAYLOAD so the client
|
||||||
|
// can stream the body without hashing it first.
|
||||||
|
func spacesUnsignedPayload(stack *middleware.Stack) error {
|
||||||
|
if err := v4.SwapComputePayloadSHA256ForUnsignedPayloadMiddleware(stack); err != nil {
|
||||||
|
return v4.AddUnsignedPayloadMiddleware(stack)
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
func (s *spaces) Enabled() bool { return true }
|
func (s *spaces) Enabled() bool { return true }
|
||||||
|
|
||||||
func (s *spaces) Upload(ctx context.Context, obj FileUpload) (string, error) {
|
func (s *spaces) Upload(ctx context.Context, obj FileUpload) (string, error) {
|
||||||
|
|||||||
@@ -0,0 +1,133 @@
|
|||||||
|
package discord
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"strings"
|
||||||
|
|
||||||
|
"github.com/bwmarrin/discordgo"
|
||||||
|
)
|
||||||
|
|
||||||
|
// API is the Discord REST surface used by the outbound subscriber.
|
||||||
|
type API interface {
|
||||||
|
SendToChannel(ctx context.Context, channelID string, msg Message) (messageID string, err error)
|
||||||
|
StartThread(ctx context.Context, channelID, name string) (threadID string, err error)
|
||||||
|
SendToThread(ctx context.Context, threadID string, msg Message) (messageID string, err error)
|
||||||
|
Edit(ctx context.Context, channelID, messageID string, msg Message) error
|
||||||
|
Close() error
|
||||||
|
}
|
||||||
|
|
||||||
|
type sessionAPI struct {
|
||||||
|
session *discordgo.Session
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *sessionAPI) SendToChannel(_ context.Context, channelID string, msg Message) (string, error) {
|
||||||
|
sent, err := s.session.ChannelMessageSendComplex(channelID, toMessageSend(msg))
|
||||||
|
if err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
return sent.ID, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *sessionAPI) StartThread(_ context.Context, channelID, name string) (string, error) {
|
||||||
|
thread, err := s.session.ThreadStartComplex(channelID, &discordgo.ThreadStart{
|
||||||
|
Name: name,
|
||||||
|
Type: discordgo.ChannelTypeGuildPublicThread,
|
||||||
|
AutoArchiveDuration: 10080,
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
return thread.ID, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *sessionAPI) SendToThread(ctx context.Context, threadID string, msg Message) (string, error) {
|
||||||
|
return s.SendToChannel(ctx, threadID, msg)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *sessionAPI) Edit(_ context.Context, channelID, messageID string, msg Message) error {
|
||||||
|
content := messageContent(msg)
|
||||||
|
embeds := toEmbeds(msg)
|
||||||
|
_, err := s.session.ChannelMessageEditComplex(&discordgo.MessageEdit{
|
||||||
|
ID: messageID,
|
||||||
|
Channel: channelID,
|
||||||
|
Content: &content,
|
||||||
|
Embeds: &embeds,
|
||||||
|
})
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *sessionAPI) Close() error {
|
||||||
|
if s == nil || s.session == nil {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
return s.session.Close()
|
||||||
|
}
|
||||||
|
|
||||||
|
func toMessageSend(msg Message) *discordgo.MessageSend {
|
||||||
|
var files []*discordgo.File
|
||||||
|
for _, f := range msg.Files {
|
||||||
|
files = append(files, &discordgo.File{
|
||||||
|
Name: f.Name,
|
||||||
|
ContentType: f.ContentType,
|
||||||
|
Reader: f.Reader,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
return &discordgo.MessageSend{
|
||||||
|
Content: messageContent(msg),
|
||||||
|
Embeds: toEmbeds(msg),
|
||||||
|
Files: files,
|
||||||
|
AllowedMentions: &discordgo.MessageAllowedMentions{},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func toEmbeds(msg Message) []*discordgo.MessageEmbed {
|
||||||
|
imageURLs := embedImageURLs(msg)
|
||||||
|
if msg.Title == "" && msg.Description == "" && msg.City == "" && msg.Author == "" && len(imageURLs) == 0 {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
main := &discordgo.MessageEmbed{
|
||||||
|
Title: msg.Title,
|
||||||
|
URL: publicURL(msg.URL),
|
||||||
|
Description: msg.Description,
|
||||||
|
Color: embedColor,
|
||||||
|
}
|
||||||
|
if msg.City != "" {
|
||||||
|
main.Fields = append(main.Fields, &discordgo.MessageEmbedField{
|
||||||
|
Name: "City",
|
||||||
|
Value: msg.City,
|
||||||
|
Inline: true,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
if msg.Author != "" {
|
||||||
|
main.Fields = append(main.Fields, &discordgo.MessageEmbedField{
|
||||||
|
Name: "Author",
|
||||||
|
Value: msg.Author,
|
||||||
|
Inline: true,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
embeds := []*discordgo.MessageEmbed{main}
|
||||||
|
for i, url := range imageURLs {
|
||||||
|
if i == 0 {
|
||||||
|
main.Image = &discordgo.MessageEmbedImage{URL: url}
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
embeds = append(embeds, &discordgo.MessageEmbed{
|
||||||
|
Color: embedColor,
|
||||||
|
Image: &discordgo.MessageEmbedImage{URL: url},
|
||||||
|
})
|
||||||
|
}
|
||||||
|
return embeds
|
||||||
|
}
|
||||||
|
|
||||||
|
func embedImageURLs(msg Message) []string {
|
||||||
|
var attached []string
|
||||||
|
for _, f := range msg.Files {
|
||||||
|
if strings.HasPrefix(f.ContentType, "image/") {
|
||||||
|
attached = append(attached, "attachment://"+f.Name)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if len(attached) > 0 {
|
||||||
|
return attached
|
||||||
|
}
|
||||||
|
return msg.ImageURLs
|
||||||
|
}
|
||||||
@@ -0,0 +1,255 @@
|
|||||||
|
package discord
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"database/sql"
|
||||||
|
"errors"
|
||||||
|
"fmt"
|
||||||
|
"log"
|
||||||
|
"os"
|
||||||
|
"strings"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"github.com/bwmarrin/discordgo"
|
||||||
|
|
||||||
|
"plumber/internal/events"
|
||||||
|
"plumber/internal/store"
|
||||||
|
)
|
||||||
|
|
||||||
|
const discordTimeout = 60 * time.Second
|
||||||
|
|
||||||
|
// Bot posts site events to a Discord channel and owns post-to-message links.
|
||||||
|
type Bot struct {
|
||||||
|
channelID string
|
||||||
|
links store.DiscordLinkStore
|
||||||
|
api API
|
||||||
|
store store.Store
|
||||||
|
bus events.Publisher
|
||||||
|
admins map[string]string
|
||||||
|
botUserID string
|
||||||
|
}
|
||||||
|
|
||||||
|
// New constructs an outbound subscriber. Tests inject a fake API.
|
||||||
|
func New(channelID string, links store.DiscordLinkStore, api API) *Bot {
|
||||||
|
return &Bot{channelID: strings.TrimSpace(channelID), links: links, api: api}
|
||||||
|
}
|
||||||
|
|
||||||
|
// FromEnv builds a bot when Discord env is set. Missing config is a no-op.
|
||||||
|
func FromEnv(links store.DiscordLinkStore, bus *events.Bus, st store.Store) (*Bot, error) {
|
||||||
|
token := strings.TrimSpace(os.Getenv("DISCORD_BOT_TOKEN"))
|
||||||
|
channelID := strings.TrimSpace(os.Getenv("DISCORD_CHANNEL_ID"))
|
||||||
|
if token == "" && channelID == "" {
|
||||||
|
return nil, nil
|
||||||
|
}
|
||||||
|
if token == "" {
|
||||||
|
return nil, fmt.Errorf("DISCORD_BOT_TOKEN is required when DISCORD_CHANNEL_ID is set")
|
||||||
|
}
|
||||||
|
if channelID == "" {
|
||||||
|
return nil, fmt.Errorf("DISCORD_CHANNEL_ID is required when DISCORD_BOT_TOKEN is set")
|
||||||
|
}
|
||||||
|
if links == nil {
|
||||||
|
return nil, fmt.Errorf("discord links store is required")
|
||||||
|
}
|
||||||
|
session, err := discordgo.New("Bot " + token)
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
session.Identify.Intents = discordgo.IntentsGuilds | discordgo.IntentsGuildMessages | discordgo.IntentsMessageContent
|
||||||
|
bot := New(channelID, links, &sessionAPI{session: session})
|
||||||
|
bot.store = st
|
||||||
|
bot.bus = bus
|
||||||
|
bot.admins = parseAdminMap(os.Getenv("DISCORD_ADMIN_MAP"))
|
||||||
|
session.AddHandler(bot.onMessageCreate)
|
||||||
|
if bus != nil {
|
||||||
|
bus.Subscribe(bot.Handle)
|
||||||
|
}
|
||||||
|
if err := session.Open(); err != nil {
|
||||||
|
_ = session.Close()
|
||||||
|
return nil, fmt.Errorf("discord gateway: %w", err)
|
||||||
|
}
|
||||||
|
if session.State != nil && session.State.User != nil {
|
||||||
|
bot.botUserID = session.State.User.ID
|
||||||
|
}
|
||||||
|
log.Printf("discord: subscriber enabled")
|
||||||
|
return bot, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// Close releases the Discord session.
|
||||||
|
func (b *Bot) Close() error {
|
||||||
|
if b == nil || b.api == nil {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
return b.api.Close()
|
||||||
|
}
|
||||||
|
|
||||||
|
// Handle processes one site event. Failures are logged and do not fail the request.
|
||||||
|
func (b *Bot) Handle(_ context.Context, ev any) {
|
||||||
|
if b == nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
ctx, cancel := context.WithTimeout(context.Background(), discordTimeout)
|
||||||
|
defer cancel()
|
||||||
|
switch e := ev.(type) {
|
||||||
|
case events.PostCreated:
|
||||||
|
defer b.publishPosted(e)
|
||||||
|
b.onCreated(ctx, e)
|
||||||
|
case events.PostUpdated:
|
||||||
|
b.onUpdated(ctx, e.PostEvent)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *Bot) publishPosted(e events.PostCreated) {
|
||||||
|
if e.Release == nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
done := events.PostedToDiscord{PostID: e.PostID, Release: e.Release}
|
||||||
|
if b.bus == nil {
|
||||||
|
e.Release()
|
||||||
|
return
|
||||||
|
}
|
||||||
|
b.bus.Publish(context.Background(), done)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *Bot) onCreated(ctx context.Context, e events.PostCreated) {
|
||||||
|
ev := e.PostEvent
|
||||||
|
_, err := b.links.GetByPostID(ctx, ev.PostID)
|
||||||
|
if err == nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if !errors.Is(err, sql.ErrNoRows) {
|
||||||
|
log.Printf("discord: load link %s: %v", ev.PostID, err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if isRoot(ev) {
|
||||||
|
b.createRoot(ctx, e)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
b.createReply(ctx, e)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *Bot) onUpdated(ctx context.Context, ev events.PostEvent) {
|
||||||
|
link, err := b.links.GetByPostID(ctx, ev.PostID)
|
||||||
|
if err != nil {
|
||||||
|
if errors.Is(err, sql.ErrNoRows) {
|
||||||
|
b.onCreated(ctx, events.PostCreated{PostEvent: ev})
|
||||||
|
return
|
||||||
|
}
|
||||||
|
log.Printf("discord: load link %s: %v", ev.PostID, err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
channelID, err := b.editChannel(ctx, ev, link)
|
||||||
|
if err != nil {
|
||||||
|
log.Printf("discord: edit channel %s: %v", ev.PostID, err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if err := b.api.Edit(ctx, channelID, link.MessageID, formatMessage(ev)); err != nil {
|
||||||
|
log.Printf("discord: edit %s: %v", ev.PostID, err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
log.Printf("discord: edited %s", ev.PostID)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *Bot) createRoot(ctx context.Context, e events.PostCreated) {
|
||||||
|
msg := formatCreated(e)
|
||||||
|
threadID, err := b.api.StartThread(ctx, b.channelID, msg.ThreadName)
|
||||||
|
if err != nil {
|
||||||
|
log.Printf("discord: start thread %s: %v", e.PostID, err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
messageID, err := b.sendCreated(ctx, threadID, msg)
|
||||||
|
if err != nil {
|
||||||
|
log.Printf("discord: send root %s: %v", e.PostID, err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if err := b.links.Upsert(ctx, store.DiscordLink{
|
||||||
|
PostID: e.PostID,
|
||||||
|
MessageID: messageID,
|
||||||
|
ThreadID: threadID,
|
||||||
|
}); err != nil {
|
||||||
|
log.Printf("discord: save root link %s: %v", e.PostID, err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
log.Printf("discord: posted root %s", e.PostID)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *Bot) createReply(ctx context.Context, e events.PostCreated) {
|
||||||
|
root, err := b.links.GetByPostID(ctx, e.RootID)
|
||||||
|
if err != nil {
|
||||||
|
if errors.Is(err, sql.ErrNoRows) {
|
||||||
|
log.Printf("discord: skip reply %s: no root thread", e.PostID)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
log.Printf("discord: load root link %s: %v", e.RootID, err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if strings.TrimSpace(root.ThreadID) == "" {
|
||||||
|
log.Printf("discord: skip reply %s: no root thread", e.PostID)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
messageID, err := b.sendCreated(ctx, root.ThreadID, formatCreated(e))
|
||||||
|
if err != nil {
|
||||||
|
log.Printf("discord: send reply %s: %v", e.PostID, err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if err := b.links.Upsert(ctx, store.DiscordLink{
|
||||||
|
PostID: e.PostID,
|
||||||
|
MessageID: messageID,
|
||||||
|
}); err != nil {
|
||||||
|
log.Printf("discord: save reply link %s: %v", e.PostID, err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
log.Printf("discord: posted reply %s", e.PostID)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *Bot) sendCreated(ctx context.Context, threadID string, msg Message) (string, error) {
|
||||||
|
_, videos := splitAttachments(msg.Files)
|
||||||
|
msg.Files = nil
|
||||||
|
if len(videos) > 0 {
|
||||||
|
msg.VideoURLs = nil
|
||||||
|
}
|
||||||
|
messageID, err := b.send(ctx, threadID, msg)
|
||||||
|
if err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
for _, video := range videos {
|
||||||
|
if _, err := b.send(ctx, threadID, Message{Files: []Attachment{video}}); err != nil {
|
||||||
|
log.Printf("discord: send video %s: %v", threadID, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return messageID, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func splitAttachments(files []Attachment) (images, videos []Attachment) {
|
||||||
|
for _, f := range files {
|
||||||
|
if strings.HasPrefix(f.ContentType, "video/") || f.Kind == "video" {
|
||||||
|
videos = append(videos, f)
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
images = append(images, f)
|
||||||
|
}
|
||||||
|
return images, videos
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *Bot) send(ctx context.Context, threadID string, msg Message) (string, error) {
|
||||||
|
messageID, err := b.api.SendToThread(ctx, threadID, msg)
|
||||||
|
if err != nil && len(msg.Files) > 0 {
|
||||||
|
log.Printf("discord: send with files %s: %v; retrying without files", threadID, err)
|
||||||
|
msg.Files = nil
|
||||||
|
return b.api.SendToThread(ctx, threadID, msg)
|
||||||
|
}
|
||||||
|
return messageID, err
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *Bot) editChannel(ctx context.Context, ev events.PostEvent, link *store.DiscordLink) (string, error) {
|
||||||
|
if strings.TrimSpace(link.ThreadID) != "" {
|
||||||
|
return link.ThreadID, nil
|
||||||
|
}
|
||||||
|
root, err := b.links.GetByPostID(ctx, ev.RootID)
|
||||||
|
if err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
if strings.TrimSpace(root.ThreadID) == "" {
|
||||||
|
return "", fmt.Errorf("root %s has no thread", ev.RootID)
|
||||||
|
}
|
||||||
|
return root.ThreadID, nil
|
||||||
|
}
|
||||||
@@ -0,0 +1,417 @@
|
|||||||
|
package discord
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"strconv"
|
||||||
|
"strings"
|
||||||
|
"sync"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"plumber/internal/events"
|
||||||
|
"plumber/internal/store"
|
||||||
|
)
|
||||||
|
|
||||||
|
type recordedSend struct {
|
||||||
|
Kind string
|
||||||
|
ChannelID string
|
||||||
|
Name string
|
||||||
|
Msg Message
|
||||||
|
}
|
||||||
|
|
||||||
|
type fakeAPI struct {
|
||||||
|
mu sync.Mutex
|
||||||
|
sends []recordedSend
|
||||||
|
edits []recordedSend
|
||||||
|
next int
|
||||||
|
failSend error
|
||||||
|
}
|
||||||
|
|
||||||
|
func (f *fakeAPI) SendToChannel(_ context.Context, channelID string, msg Message) (string, error) {
|
||||||
|
return f.record("channel", channelID, "", msg)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (f *fakeAPI) StartThread(_ context.Context, channelID, name string) (string, error) {
|
||||||
|
f.mu.Lock()
|
||||||
|
defer f.mu.Unlock()
|
||||||
|
f.next++
|
||||||
|
id := "thread-" + strconv.Itoa(f.next)
|
||||||
|
f.sends = append(f.sends, recordedSend{
|
||||||
|
Kind: "thread",
|
||||||
|
ChannelID: channelID,
|
||||||
|
Name: name,
|
||||||
|
Msg: Message{ThreadName: name},
|
||||||
|
})
|
||||||
|
return id, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func (f *fakeAPI) SendToThread(_ context.Context, threadID string, msg Message) (string, error) {
|
||||||
|
return f.record("thread-msg", threadID, "", msg)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (f *fakeAPI) Edit(_ context.Context, channelID, messageID string, msg Message) error {
|
||||||
|
f.mu.Lock()
|
||||||
|
defer f.mu.Unlock()
|
||||||
|
f.edits = append(f.edits, recordedSend{
|
||||||
|
Kind: "edit",
|
||||||
|
ChannelID: channelID,
|
||||||
|
Name: messageID,
|
||||||
|
Msg: msg,
|
||||||
|
})
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func (f *fakeAPI) Close() error { return nil }
|
||||||
|
|
||||||
|
func (f *fakeAPI) record(kind, channelID, name string, msg Message) (string, error) {
|
||||||
|
f.mu.Lock()
|
||||||
|
defer f.mu.Unlock()
|
||||||
|
if f.failSend != nil {
|
||||||
|
return "", f.failSend
|
||||||
|
}
|
||||||
|
f.next++
|
||||||
|
id := "msg-" + strconv.Itoa(f.next)
|
||||||
|
f.sends = append(f.sends, recordedSend{Kind: kind, ChannelID: channelID, Name: name, Msg: msg})
|
||||||
|
return id, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestOutboundRootReplyAndEdit(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
links := newMemoryLinks()
|
||||||
|
api := &fakeAPI{}
|
||||||
|
bot := New("channel-1", links, api)
|
||||||
|
ctx := context.Background()
|
||||||
|
|
||||||
|
root := events.PostEvent{
|
||||||
|
PostID: "root-1",
|
||||||
|
RootID: "root-1",
|
||||||
|
Title: "Leaky sink",
|
||||||
|
Body: "Water under the cabinet.",
|
||||||
|
City: "Oakland",
|
||||||
|
AuthorName: "sam",
|
||||||
|
Permalink: "https://www.askaplumberfirst.com/questions/root-1#post-root-1",
|
||||||
|
Images: []events.Image{{URL: "https://cdn.example/a.jpg"}, {URL: "https://cdn.example/b.jpg"}},
|
||||||
|
}
|
||||||
|
bot.Handle(ctx, events.PostCreated{PostEvent: root})
|
||||||
|
|
||||||
|
if len(api.sends) != 2 ||
|
||||||
|
api.sends[0].Kind != "thread" ||
|
||||||
|
api.sends[1].Kind != "thread-msg" {
|
||||||
|
t.Fatalf("root sends = %+v", api.sends)
|
||||||
|
}
|
||||||
|
if api.sends[0].ChannelID != "channel-1" ||
|
||||||
|
api.sends[0].Name != "sam asks: Leaky sink" ||
|
||||||
|
api.sends[1].ChannelID != "thread-1" {
|
||||||
|
t.Fatalf("root routing = %+v", api.sends)
|
||||||
|
}
|
||||||
|
if got := api.sends[1].Msg.ImageURLs; len(got) != 2 || got[0] != "https://cdn.example/a.jpg" {
|
||||||
|
t.Fatalf("root images = %v", got)
|
||||||
|
}
|
||||||
|
link, err := links.GetByPostID(ctx, "root-1")
|
||||||
|
if err != nil || link.MessageID != "msg-2" || link.ThreadID != "thread-1" {
|
||||||
|
t.Fatalf("root link = %+v, %v", link, err)
|
||||||
|
}
|
||||||
|
|
||||||
|
reply := events.PostEvent{
|
||||||
|
PostID: "reply-1",
|
||||||
|
RootID: "root-1",
|
||||||
|
ParentID: "root-1",
|
||||||
|
Body: "Replace the cartridge.",
|
||||||
|
AuthorName: "plumber",
|
||||||
|
Permalink: "https://www.askaplumberfirst.com/questions/root-1#post-reply-1",
|
||||||
|
}
|
||||||
|
bot.Handle(ctx, events.PostCreated{PostEvent: reply})
|
||||||
|
if len(api.sends) != 3 || api.sends[2].Kind != "thread-msg" || api.sends[2].ChannelID != "thread-1" {
|
||||||
|
t.Fatalf("reply sends = %+v", api.sends)
|
||||||
|
}
|
||||||
|
replyLink, err := links.GetByPostID(ctx, "reply-1")
|
||||||
|
if err != nil || replyLink.MessageID != "msg-3" || replyLink.ThreadID != "" {
|
||||||
|
t.Fatalf("reply link = %+v, %v", replyLink, err)
|
||||||
|
}
|
||||||
|
|
||||||
|
root.Body = "Updated leak."
|
||||||
|
bot.Handle(ctx, events.PostUpdated{PostEvent: root})
|
||||||
|
if len(api.edits) != 1 || api.edits[0].ChannelID != "thread-1" || api.edits[0].Name != "msg-2" {
|
||||||
|
t.Fatalf("root edit = %+v", api.edits)
|
||||||
|
}
|
||||||
|
if api.edits[0].Msg.Description != "Updated leak." {
|
||||||
|
t.Fatalf("root edit body = %+v", api.edits[0].Msg)
|
||||||
|
}
|
||||||
|
|
||||||
|
reply.Body = "Use a ceramic cartridge."
|
||||||
|
bot.Handle(ctx, events.PostUpdated{PostEvent: reply})
|
||||||
|
if len(api.edits) != 2 || api.edits[1].ChannelID != "thread-1" || api.edits[1].Name != "msg-3" {
|
||||||
|
t.Fatalf("reply edit = %+v", api.edits)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestOutboundSkipsReplyWithoutRootLink(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
api := &fakeAPI{}
|
||||||
|
bot := New("channel-1", newMemoryLinks(), api)
|
||||||
|
bot.Handle(context.Background(), events.PostCreated{PostEvent: events.PostEvent{
|
||||||
|
PostID: "reply-1",
|
||||||
|
RootID: "missing",
|
||||||
|
ParentID: "missing",
|
||||||
|
Body: "Orphan reply",
|
||||||
|
}})
|
||||||
|
if len(api.sends) != 0 {
|
||||||
|
t.Fatalf("unexpected sends %+v", api.sends)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestOutboundSkipsAlreadyLinkedPost(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
links := newMemoryLinks()
|
||||||
|
api := &fakeAPI{}
|
||||||
|
bot := New("channel-1", links, api)
|
||||||
|
if err := links.Upsert(context.Background(), store.DiscordLink{
|
||||||
|
PostID: "reply-1",
|
||||||
|
MessageID: "d-reply-1",
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if err := links.Upsert(context.Background(), store.DiscordLink{
|
||||||
|
PostID: "root-1",
|
||||||
|
MessageID: "d-root",
|
||||||
|
ThreadID: "thread-1",
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
bot.Handle(context.Background(), events.PostCreated{PostEvent: events.PostEvent{
|
||||||
|
PostID: "reply-1",
|
||||||
|
RootID: "root-1",
|
||||||
|
ParentID: "root-1",
|
||||||
|
Body: "Already on Discord.",
|
||||||
|
}})
|
||||||
|
if len(api.sends) != 0 {
|
||||||
|
t.Fatalf("echoed already-linked reply: %+v", api.sends)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestOutboundUpdateWithoutLinkCreates(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
links := newMemoryLinks()
|
||||||
|
api := &fakeAPI{}
|
||||||
|
bot := New("channel-1", links, api)
|
||||||
|
bot.Handle(context.Background(), events.PostUpdated{PostEvent: events.PostEvent{
|
||||||
|
PostID: "root-2",
|
||||||
|
RootID: "root-2",
|
||||||
|
Title: "Late question",
|
||||||
|
Body: "Created while Discord was down.",
|
||||||
|
}})
|
||||||
|
link, err := links.GetByPostID(context.Background(), "root-2")
|
||||||
|
if err != nil || link.ThreadID == "" || len(api.sends) != 2 {
|
||||||
|
t.Fatalf("late create link=%+v sends=%+v err=%v", link, api.sends, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestOutboundAttachesVideoFile(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
bus := events.New()
|
||||||
|
defer bus.Close()
|
||||||
|
events.SubscribeRelease(bus)
|
||||||
|
links := newMemoryLinks()
|
||||||
|
api := &fakeAPI{}
|
||||||
|
bot := New("channel-1", links, api)
|
||||||
|
bot.bus = bus
|
||||||
|
|
||||||
|
released := make(chan struct{})
|
||||||
|
bot.Handle(context.Background(), events.PostCreated{
|
||||||
|
PostEvent: events.PostEvent{
|
||||||
|
PostID: "root-1",
|
||||||
|
RootID: "root-1",
|
||||||
|
Title: "Valve clip",
|
||||||
|
Body: "Watch the handle.",
|
||||||
|
AuthorName: "sam",
|
||||||
|
Permalink: "https://www.askaplumberfirst.com/questions/root-1#post-root-1",
|
||||||
|
Images: []events.Image{{URL: "https://cdn.example/clip.mp4", Kind: "video"}},
|
||||||
|
},
|
||||||
|
Media: []events.Media{{
|
||||||
|
Name: "clip.mp4",
|
||||||
|
ContentType: "video/mp4",
|
||||||
|
Kind: "video",
|
||||||
|
Bytes: []byte("fake-mp4"),
|
||||||
|
}},
|
||||||
|
Release: func() { close(released) },
|
||||||
|
})
|
||||||
|
|
||||||
|
if len(api.sends) != 3 ||
|
||||||
|
api.sends[1].Kind != "thread-msg" ||
|
||||||
|
api.sends[2].Kind != "thread-msg" {
|
||||||
|
t.Fatalf("sends = %+v", api.sends)
|
||||||
|
}
|
||||||
|
if len(api.sends[1].Msg.Files) != 0 {
|
||||||
|
t.Fatalf("text message files = %+v", api.sends[1].Msg.Files)
|
||||||
|
}
|
||||||
|
files := api.sends[2].Msg.Files
|
||||||
|
if len(files) != 1 || files[0].Name != "clip.mp4" || files[0].ContentType != "video/mp4" {
|
||||||
|
t.Fatalf("video files = %+v", files)
|
||||||
|
}
|
||||||
|
content := messageContent(api.sends[1].Msg)
|
||||||
|
if strings.Contains(content, "https://cdn.example/clip.mp4") {
|
||||||
|
t.Fatalf("content still has video URL: %q", content)
|
||||||
|
}
|
||||||
|
select {
|
||||||
|
case <-released:
|
||||||
|
case <-time.After(time.Second):
|
||||||
|
t.Fatal("PostedToDiscord did not release")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestOutboundPhotosThenVideo(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
api := &fakeAPI{}
|
||||||
|
bot := New("channel-1", newMemoryLinks(), api)
|
||||||
|
bot.Handle(context.Background(), events.PostCreated{
|
||||||
|
PostEvent: events.PostEvent{
|
||||||
|
PostID: "root-1",
|
||||||
|
RootID: "root-1",
|
||||||
|
Title: "Valve clip",
|
||||||
|
Body: "Photo and video.",
|
||||||
|
AuthorName: "sam",
|
||||||
|
Images: []events.Image{
|
||||||
|
{URL: "https://cdn.example/a.jpg"},
|
||||||
|
{URL: "https://cdn.example/clip.mp4", Kind: "video"},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Media: []events.Media{
|
||||||
|
{Name: "still.jpg", ContentType: "image/jpeg", Kind: "image", Bytes: []byte("jpeg")},
|
||||||
|
{Name: "clip.mp4", ContentType: "video/mp4", Kind: "video", Bytes: []byte("mp4")},
|
||||||
|
},
|
||||||
|
})
|
||||||
|
if len(api.sends) != 3 ||
|
||||||
|
api.sends[1].Kind != "thread-msg" ||
|
||||||
|
api.sends[2].Kind != "thread-msg" {
|
||||||
|
t.Fatalf("sends = %+v", api.sends)
|
||||||
|
}
|
||||||
|
photos := api.sends[1].Msg.Files
|
||||||
|
if len(photos) != 0 {
|
||||||
|
t.Fatalf("text message should not attach files: %+v", photos)
|
||||||
|
}
|
||||||
|
if got := api.sends[1].Msg.ImageURLs; len(got) != 1 || got[0] != "https://cdn.example/a.jpg" {
|
||||||
|
t.Fatalf("text message images = %v", got)
|
||||||
|
}
|
||||||
|
if embeds := toEmbeds(api.sends[1].Msg); len(embeds) == 0 || embeds[0].Image == nil || embeds[0].Image.URL != "https://cdn.example/a.jpg" {
|
||||||
|
t.Fatalf("text embeds = %+v", toEmbeds(api.sends[1].Msg))
|
||||||
|
}
|
||||||
|
videos := api.sends[2].Msg.Files
|
||||||
|
if len(videos) != 1 || videos[0].Name != "clip.mp4" {
|
||||||
|
t.Fatalf("video files = %+v", videos)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestOutboundReleasesWhenAlreadyLinked(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
links := newMemoryLinks()
|
||||||
|
if err := links.Upsert(context.Background(), store.DiscordLink{
|
||||||
|
PostID: "root-1",
|
||||||
|
MessageID: "d-root",
|
||||||
|
ThreadID: "thread-1",
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
released := false
|
||||||
|
bot := New("channel-1", links, &fakeAPI{})
|
||||||
|
bot.Handle(context.Background(), events.PostCreated{
|
||||||
|
PostEvent: events.PostEvent{PostID: "root-1", RootID: "root-1", Title: "Already posted"},
|
||||||
|
Release: func() { released = true },
|
||||||
|
})
|
||||||
|
if !released {
|
||||||
|
t.Fatal("skipped send did not release held upload")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestFormatMessage(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
got := formatMessage(events.PostEvent{
|
||||||
|
Title: "Leaky sink",
|
||||||
|
Body: "It drips.",
|
||||||
|
City: "Oakland",
|
||||||
|
AuthorName: "sam",
|
||||||
|
Permalink: "https://example.com/q",
|
||||||
|
Images: []events.Image{
|
||||||
|
{URL: "https://cdn.example/a.jpg", Description: "ignored"},
|
||||||
|
{URL: "https://cdn.example/clip.mp4", Kind: "video"},
|
||||||
|
},
|
||||||
|
})
|
||||||
|
if got.Title != "Leaky sink" ||
|
||||||
|
got.Description != "It drips." ||
|
||||||
|
got.City != "Oakland" ||
|
||||||
|
got.Author != "sam" ||
|
||||||
|
got.URL != "https://example.com/q" ||
|
||||||
|
got.ThreadName != "sam asks: Leaky sink" ||
|
||||||
|
len(got.ImageURLs) != 1 || got.ImageURLs[0] != "https://cdn.example/a.jpg" ||
|
||||||
|
len(got.VideoURLs) != 1 || got.VideoURLs[0] != "https://cdn.example/clip.mp4" {
|
||||||
|
t.Fatalf("format = %+v", got)
|
||||||
|
}
|
||||||
|
|
||||||
|
reply := formatMessage(events.PostEvent{Body: "Thanks", AuthorName: ""})
|
||||||
|
if reply.Title != "Reply" || reply.Author != "Someone" || reply.ThreadName != "Someone asks: Question" {
|
||||||
|
t.Fatalf("reply format = %+v", reply)
|
||||||
|
}
|
||||||
|
content := messageContent(got)
|
||||||
|
if strings.Contains(content, "Leaky sink") ||
|
||||||
|
!strings.Contains(content, "It drips.") ||
|
||||||
|
!strings.Contains(content, "Oakland") ||
|
||||||
|
!strings.Contains(content, "https://cdn.example/a.jpg") ||
|
||||||
|
!strings.Contains(content, "https://cdn.example/clip.mp4") {
|
||||||
|
t.Fatalf("content = %q", content)
|
||||||
|
}
|
||||||
|
if publicURL("/questions/x") != "" || publicURL("http://localhost:8080/q") != "" {
|
||||||
|
t.Fatal("localhost or relative permalink should not be an embed URL")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestFromEnvDisabled(t *testing.T) {
|
||||||
|
t.Setenv("DISCORD_BOT_TOKEN", "")
|
||||||
|
t.Setenv("DISCORD_CHANNEL_ID", "")
|
||||||
|
bot, err := FromEnv(newMemoryLinks(), nil, nil)
|
||||||
|
if err != nil || bot != nil {
|
||||||
|
t.Fatalf("disabled FromEnv = (%v, %v)", bot, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestFromEnvRequiresBoth(t *testing.T) {
|
||||||
|
t.Setenv("DISCORD_BOT_TOKEN", "token")
|
||||||
|
t.Setenv("DISCORD_CHANNEL_ID", "")
|
||||||
|
if _, err := FromEnv(newMemoryLinks(), nil, nil); err == nil {
|
||||||
|
t.Fatal("expected error when channel is missing")
|
||||||
|
}
|
||||||
|
t.Setenv("DISCORD_BOT_TOKEN", "")
|
||||||
|
t.Setenv("DISCORD_CHANNEL_ID", "channel")
|
||||||
|
if _, err := FromEnv(newMemoryLinks(), nil, nil); err == nil {
|
||||||
|
t.Fatal("expected error when token is missing")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestMemoryLinkUpsertKeepsThread(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
links := newMemoryLinks()
|
||||||
|
ctx := context.Background()
|
||||||
|
if err := links.Upsert(ctx, store.DiscordLink{PostID: "p", MessageID: "m1", ThreadID: "t1"}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if err := links.Upsert(ctx, store.DiscordLink{PostID: "p", MessageID: "m2"}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
got, err := links.GetByPostID(ctx, "p")
|
||||||
|
if err != nil || got.MessageID != "m2" || got.ThreadID != "t1" {
|
||||||
|
t.Fatalf("upsert keep thread = %+v, %v", got, err)
|
||||||
|
}
|
||||||
|
if _, err := links.GetByMessageID(ctx, "m2"); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if _, err := links.GetRootByThreadID(ctx, "t1"); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,173 @@
|
|||||||
|
package discord
|
||||||
|
|
||||||
|
import (
|
||||||
|
"bytes"
|
||||||
|
"io"
|
||||||
|
"strings"
|
||||||
|
|
||||||
|
"plumber/internal/events"
|
||||||
|
)
|
||||||
|
|
||||||
|
const (
|
||||||
|
embedTitleLimit = 256
|
||||||
|
embedDescriptionLimit = 4096
|
||||||
|
threadNameLimit = 100
|
||||||
|
embedColor = 0xe96a26
|
||||||
|
)
|
||||||
|
|
||||||
|
// Attachment is a local file Discord should upload with the message.
|
||||||
|
type Attachment struct {
|
||||||
|
Name string
|
||||||
|
ContentType string
|
||||||
|
Kind string
|
||||||
|
Reader io.Reader
|
||||||
|
}
|
||||||
|
|
||||||
|
// Message is a Discord-ready snapshot of a site post event.
|
||||||
|
type Message struct {
|
||||||
|
Title string
|
||||||
|
URL string
|
||||||
|
Description string
|
||||||
|
City string
|
||||||
|
Author string
|
||||||
|
ImageURLs []string
|
||||||
|
VideoURLs []string
|
||||||
|
Files []Attachment
|
||||||
|
ThreadName string
|
||||||
|
}
|
||||||
|
|
||||||
|
func formatMessage(ev events.PostEvent) Message {
|
||||||
|
return formatCreated(events.PostCreated{PostEvent: ev})
|
||||||
|
}
|
||||||
|
|
||||||
|
func formatCreated(e events.PostCreated) Message {
|
||||||
|
title := strings.TrimSpace(e.Title)
|
||||||
|
if title == "" {
|
||||||
|
title = "Reply"
|
||||||
|
}
|
||||||
|
author := strings.TrimSpace(e.AuthorName)
|
||||||
|
if author == "" {
|
||||||
|
author = "Someone"
|
||||||
|
}
|
||||||
|
msg := Message{
|
||||||
|
Title: truncateRunes(title, embedTitleLimit),
|
||||||
|
URL: strings.TrimSpace(e.Permalink),
|
||||||
|
Description: truncateRunes(strings.TrimSpace(e.Body), embedDescriptionLimit),
|
||||||
|
City: strings.TrimSpace(e.City),
|
||||||
|
Author: author,
|
||||||
|
ThreadName: threadName(author, e.Title),
|
||||||
|
Files: filesFromMedia(e.Media),
|
||||||
|
}
|
||||||
|
for _, img := range e.Images {
|
||||||
|
url := strings.TrimSpace(img.URL)
|
||||||
|
if url == "" {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if img.Kind == "video" {
|
||||||
|
msg.VideoURLs = append(msg.VideoURLs, url)
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
msg.ImageURLs = append(msg.ImageURLs, url)
|
||||||
|
}
|
||||||
|
return msg
|
||||||
|
}
|
||||||
|
|
||||||
|
func filesFromMedia(media []events.Media) []Attachment {
|
||||||
|
if len(media) == 0 {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
files := make([]Attachment, 0, len(media))
|
||||||
|
for _, m := range media {
|
||||||
|
var r io.Reader
|
||||||
|
switch {
|
||||||
|
case len(m.Bytes) > 0:
|
||||||
|
r = bytes.NewReader(m.Bytes)
|
||||||
|
case m.Body != nil:
|
||||||
|
r = m.Body
|
||||||
|
default:
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
name := strings.TrimSpace(m.Name)
|
||||||
|
if name == "" {
|
||||||
|
name = "upload"
|
||||||
|
}
|
||||||
|
files = append(files, Attachment{
|
||||||
|
Name: name,
|
||||||
|
ContentType: m.ContentType,
|
||||||
|
Kind: m.Kind,
|
||||||
|
Reader: r,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
return files
|
||||||
|
}
|
||||||
|
|
||||||
|
func threadName(author, title string) string {
|
||||||
|
author = strings.TrimSpace(author)
|
||||||
|
if author == "" {
|
||||||
|
author = "Someone"
|
||||||
|
}
|
||||||
|
title = strings.TrimSpace(title)
|
||||||
|
if title == "" {
|
||||||
|
title = "Question"
|
||||||
|
}
|
||||||
|
return truncateRunes(author+" asks: "+title, threadNameLimit)
|
||||||
|
}
|
||||||
|
|
||||||
|
func truncateRunes(s string, max int) string {
|
||||||
|
if max <= 0 {
|
||||||
|
return ""
|
||||||
|
}
|
||||||
|
runes := []rune(s)
|
||||||
|
if len(runes) <= max {
|
||||||
|
return s
|
||||||
|
}
|
||||||
|
return string(runes[:max])
|
||||||
|
}
|
||||||
|
|
||||||
|
func isRoot(ev events.PostEvent) bool {
|
||||||
|
return strings.TrimSpace(ev.ParentID) == ""
|
||||||
|
}
|
||||||
|
|
||||||
|
func messageContent(msg Message) string {
|
||||||
|
var parts []string
|
||||||
|
if body := strings.TrimSpace(msg.Description); body != "" {
|
||||||
|
parts = append(parts, body)
|
||||||
|
}
|
||||||
|
var meta []string
|
||||||
|
if msg.City != "" {
|
||||||
|
meta = append(meta, msg.City)
|
||||||
|
}
|
||||||
|
if msg.Author != "" {
|
||||||
|
meta = append(meta, msg.Author)
|
||||||
|
}
|
||||||
|
if len(meta) > 0 {
|
||||||
|
parts = append(parts, strings.Join(meta, " · "))
|
||||||
|
}
|
||||||
|
if u := publicURL(msg.URL); u != "" {
|
||||||
|
parts = append(parts, u)
|
||||||
|
}
|
||||||
|
if len(msg.Files) == 0 {
|
||||||
|
for _, mediaURL := range msg.ImageURLs {
|
||||||
|
if u := publicURL(mediaURL); u != "" {
|
||||||
|
parts = append(parts, u)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
for _, mediaURL := range msg.VideoURLs {
|
||||||
|
if u := publicURL(mediaURL); u != "" {
|
||||||
|
parts = append(parts, u)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return truncateRunes(strings.Join(parts, "\n"), 2000)
|
||||||
|
}
|
||||||
|
|
||||||
|
func publicURL(raw string) string {
|
||||||
|
raw = strings.TrimSpace(raw)
|
||||||
|
if !strings.HasPrefix(raw, "https://") {
|
||||||
|
return ""
|
||||||
|
}
|
||||||
|
if strings.Contains(raw, "localhost") || strings.Contains(raw, "127.0.0.1") {
|
||||||
|
return ""
|
||||||
|
}
|
||||||
|
return raw
|
||||||
|
}
|
||||||
@@ -0,0 +1,203 @@
|
|||||||
|
package discord
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"database/sql"
|
||||||
|
"errors"
|
||||||
|
"fmt"
|
||||||
|
"log"
|
||||||
|
"strings"
|
||||||
|
|
||||||
|
"github.com/bwmarrin/discordgo"
|
||||||
|
|
||||||
|
"plumber/internal/events"
|
||||||
|
"plumber/internal/store"
|
||||||
|
)
|
||||||
|
|
||||||
|
const inboundBodyLimit = 12000
|
||||||
|
|
||||||
|
type inboundMessage struct {
|
||||||
|
ID string
|
||||||
|
ChannelID string
|
||||||
|
GuildID string
|
||||||
|
AuthorID string
|
||||||
|
Content string
|
||||||
|
ReferencedMessageID string
|
||||||
|
Bot bool
|
||||||
|
Attachments int
|
||||||
|
}
|
||||||
|
|
||||||
|
func parseAdminMap(raw string) map[string]string {
|
||||||
|
out := map[string]string{}
|
||||||
|
for _, part := range strings.Split(raw, ",") {
|
||||||
|
part = strings.TrimSpace(part)
|
||||||
|
if part == "" {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
id, username, ok := strings.Cut(part, ":")
|
||||||
|
id = strings.TrimSpace(id)
|
||||||
|
username = store.NormalizeUsername(username)
|
||||||
|
if !ok || id == "" || username == "" {
|
||||||
|
log.Printf("discord: skip invalid DISCORD_ADMIN_MAP entry %q", part)
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
out[id] = username
|
||||||
|
}
|
||||||
|
return out
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *Bot) onMessageCreate(_ *discordgo.Session, m *discordgo.MessageCreate) {
|
||||||
|
if b == nil || m == nil || m.Author == nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
in := inboundMessage{
|
||||||
|
ID: m.ID,
|
||||||
|
ChannelID: m.ChannelID,
|
||||||
|
GuildID: m.GuildID,
|
||||||
|
AuthorID: m.Author.ID,
|
||||||
|
Content: m.Content,
|
||||||
|
Bot: m.Author.Bot,
|
||||||
|
Attachments: len(m.Attachments),
|
||||||
|
}
|
||||||
|
if m.MessageReference != nil {
|
||||||
|
in.ReferencedMessageID = m.MessageReference.MessageID
|
||||||
|
}
|
||||||
|
b.handleInbound(in)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *Bot) handleInbound(in inboundMessage) {
|
||||||
|
if b == nil || b.store == nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if in.Bot || strings.TrimSpace(in.GuildID) == "" {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if b.botUserID != "" && in.AuthorID == b.botUserID {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
body := strings.TrimSpace(in.Content)
|
||||||
|
if in.Attachments > 0 {
|
||||||
|
log.Printf("discord: ignoring %d attachment(s) on %s", in.Attachments, in.ID)
|
||||||
|
}
|
||||||
|
if body == "" {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
ctx, cancel := context.WithTimeout(context.Background(), discordTimeout)
|
||||||
|
defer cancel()
|
||||||
|
if !b.knownChannel(ctx, in.ChannelID) {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
username := b.admins[in.AuthorID]
|
||||||
|
if username == "" {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
author, err := b.store.UserByUsername(ctx, username)
|
||||||
|
if err != nil {
|
||||||
|
if !errors.Is(err, sql.ErrNoRows) {
|
||||||
|
log.Printf("discord: inbound author %s: %v", username, err)
|
||||||
|
}
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if !author.Admin() {
|
||||||
|
log.Printf("discord: inbound %s is not an admin", username)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
parent, root, err := b.inboundParent(ctx, in)
|
||||||
|
if err != nil {
|
||||||
|
if !errors.Is(err, sql.ErrNoRows) {
|
||||||
|
log.Printf("discord: inbound parent %s: %v", in.ID, err)
|
||||||
|
}
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if root.PostState == store.PostStateHidden {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
reply := &store.Post{
|
||||||
|
AuthorID: author.ID,
|
||||||
|
Body: truncateRunes(body, inboundBodyLimit),
|
||||||
|
ParentID: &parent.ID,
|
||||||
|
}
|
||||||
|
if err := b.store.CreatePost(ctx, reply); err != nil {
|
||||||
|
log.Printf("discord: create inbound %s: %v", in.ID, err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if err := b.links.Upsert(ctx, store.DiscordLink{
|
||||||
|
PostID: reply.ID,
|
||||||
|
MessageID: in.ID,
|
||||||
|
}); err != nil {
|
||||||
|
log.Printf("discord: save inbound link %s: %v", reply.ID, err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
b.publishInbound(reply, root, author)
|
||||||
|
log.Printf("discord: inbound reply %s -> post %s", in.ID, reply.ID)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *Bot) knownChannel(ctx context.Context, channelID string) bool {
|
||||||
|
if strings.TrimSpace(channelID) == "" {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
if channelID == b.channelID {
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
_, err := b.links.GetRootByThreadID(ctx, channelID)
|
||||||
|
return err == nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *Bot) inboundParent(ctx context.Context, in inboundMessage) (*store.Post, *store.Post, error) {
|
||||||
|
if ref := strings.TrimSpace(in.ReferencedMessageID); ref != "" {
|
||||||
|
link, err := b.links.GetByMessageID(ctx, ref)
|
||||||
|
if err == nil {
|
||||||
|
return b.postAndRoot(ctx, link.PostID)
|
||||||
|
}
|
||||||
|
if !errors.Is(err, sql.ErrNoRows) {
|
||||||
|
return nil, nil, err
|
||||||
|
}
|
||||||
|
}
|
||||||
|
link, err := b.links.GetRootByThreadID(ctx, in.ChannelID)
|
||||||
|
if err != nil {
|
||||||
|
return nil, nil, err
|
||||||
|
}
|
||||||
|
return b.postAndRoot(ctx, link.PostID)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *Bot) postAndRoot(ctx context.Context, postID string) (*store.Post, *store.Post, error) {
|
||||||
|
postID = strings.TrimSpace(postID)
|
||||||
|
if postID == "" {
|
||||||
|
return nil, nil, sql.ErrNoRows
|
||||||
|
}
|
||||||
|
post, err := b.store.GetPost(ctx, postID)
|
||||||
|
if err != nil {
|
||||||
|
return nil, nil, err
|
||||||
|
}
|
||||||
|
current := post
|
||||||
|
seen := map[string]bool{}
|
||||||
|
for current.ParentID != nil {
|
||||||
|
if seen[current.ID] {
|
||||||
|
return nil, nil, fmt.Errorf("post ancestry cycle at %s", current.ID)
|
||||||
|
}
|
||||||
|
seen[current.ID] = true
|
||||||
|
current, err = b.store.GetPost(ctx, *current.ParentID)
|
||||||
|
if err != nil {
|
||||||
|
return nil, nil, err
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return post, current, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *Bot) publishInbound(reply, root *store.Post, author *store.User) {
|
||||||
|
if b == nil || b.bus == nil || reply == nil || root == nil || author == nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
ev := events.PostEvent{
|
||||||
|
PostID: reply.ID,
|
||||||
|
RootID: root.ID,
|
||||||
|
Body: reply.Body,
|
||||||
|
AuthorID: author.ID,
|
||||||
|
AuthorName: author.Name,
|
||||||
|
AuthorRole: string(author.Role),
|
||||||
|
}
|
||||||
|
if reply.ParentID != nil {
|
||||||
|
ev.ParentID = *reply.ParentID
|
||||||
|
}
|
||||||
|
b.bus.Publish(context.Background(), events.PostCreated{PostEvent: ev})
|
||||||
|
}
|
||||||
@@ -0,0 +1,219 @@
|
|||||||
|
package discord
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"plumber/internal/events"
|
||||||
|
"plumber/internal/mail"
|
||||||
|
"plumber/internal/pacific"
|
||||||
|
"plumber/internal/store"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestParseAdminMap(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
got := parseAdminMap(" 123:Plumber ,456:other,bad, :empty,789: ")
|
||||||
|
if got["123"] != "plumber" || got["456"] != "other" || len(got) != 2 {
|
||||||
|
t.Fatalf("parseAdminMap = %#v", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestInboundCreatesSiteReply(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
mem, homeowner, admin := seedInboundUsers(t)
|
||||||
|
links := newMemoryLinks()
|
||||||
|
api := &fakeAPI{}
|
||||||
|
mailer := &mail.Recording{}
|
||||||
|
bot := inboundTestBot(mem, links, api, admin.Username)
|
||||||
|
bus := events.New()
|
||||||
|
defer bus.Close()
|
||||||
|
bot.bus = bus
|
||||||
|
mail.Subscribe(bus, mem, mailer)
|
||||||
|
bus.Subscribe(bot.Handle)
|
||||||
|
root := seedLinkedRoot(t, mem, links, homeowner.ID, "thread-1")
|
||||||
|
|
||||||
|
bot.handleInbound(inboundMessage{
|
||||||
|
ID: "d-reply-1",
|
||||||
|
ChannelID: "thread-1",
|
||||||
|
GuildID: "guild-1",
|
||||||
|
AuthorID: "snow-admin",
|
||||||
|
Content: "Replace the cartridge.",
|
||||||
|
})
|
||||||
|
|
||||||
|
thread, err := mem.GetPostThread(context.Background(), root.ID)
|
||||||
|
if err != nil || len(thread.Replies) != 1 {
|
||||||
|
t.Fatalf("thread = %+v, %v", thread, err)
|
||||||
|
}
|
||||||
|
reply := thread.Replies[0]
|
||||||
|
if reply.AuthorID != admin.ID || reply.Body != "Replace the cartridge." || reply.ParentID == nil || *reply.ParentID != root.ID {
|
||||||
|
t.Fatalf("reply = %+v", reply)
|
||||||
|
}
|
||||||
|
link, err := links.GetByPostID(context.Background(), reply.ID)
|
||||||
|
if err != nil || link.MessageID != "d-reply-1" || link.ThreadID != "" {
|
||||||
|
t.Fatalf("inbound link = %+v, %v", link, err)
|
||||||
|
}
|
||||||
|
time.Sleep(20 * time.Millisecond)
|
||||||
|
if len(api.sends) != 0 || len(api.edits) != 0 {
|
||||||
|
t.Fatalf("inbound echoed to Discord: sends=%+v edits=%+v", api.sends, api.edits)
|
||||||
|
}
|
||||||
|
msgs := waitForMail(t, mailer, 1)
|
||||||
|
if msgs[0].ToEmail != homeowner.Email || msgs[0].ReplyID != reply.ID || msgs[0].RootID != root.ID {
|
||||||
|
t.Fatalf("mail = %+v", msgs[0])
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestInboundParentsFromReference(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
mem, homeowner, admin := seedInboundUsers(t)
|
||||||
|
links := newMemoryLinks()
|
||||||
|
bot := inboundTestBot(mem, links, &fakeAPI{}, admin.Username)
|
||||||
|
root := seedLinkedRoot(t, mem, links, homeowner.ID, "thread-1")
|
||||||
|
plumberReply := &store.Post{ParentID: &root.ID, AuthorID: admin.ID, Body: "First look."}
|
||||||
|
if err := mem.CreatePost(context.Background(), plumberReply); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if err := links.Upsert(context.Background(), store.DiscordLink{
|
||||||
|
PostID: plumberReply.ID,
|
||||||
|
MessageID: "d-plumber-1",
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
bot.handleInbound(inboundMessage{
|
||||||
|
ID: "d-nested",
|
||||||
|
ChannelID: "thread-1",
|
||||||
|
GuildID: "guild-1",
|
||||||
|
AuthorID: "snow-admin",
|
||||||
|
Content: "More detail.",
|
||||||
|
ReferencedMessageID: "d-plumber-1",
|
||||||
|
})
|
||||||
|
|
||||||
|
thread, err := mem.GetPostThread(context.Background(), root.ID)
|
||||||
|
if err != nil || len(thread.Replies) != 1 || len(thread.Replies[0].Replies) != 1 {
|
||||||
|
t.Fatalf("thread = %+v, %v", thread, err)
|
||||||
|
}
|
||||||
|
nested := thread.Replies[0].Replies[0]
|
||||||
|
if nested.ParentID == nil || *nested.ParentID != plumberReply.ID {
|
||||||
|
t.Fatalf("nested parent = %+v", nested)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestInboundIgnoresAllowlistHiddenAndEchoSources(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
mem, homeowner, admin := seedInboundUsers(t)
|
||||||
|
links := newMemoryLinks()
|
||||||
|
api := &fakeAPI{}
|
||||||
|
bot := inboundTestBot(mem, links, api, admin.Username)
|
||||||
|
root := seedLinkedRoot(t, mem, links, homeowner.ID, "thread-1")
|
||||||
|
hidden := &store.Post{
|
||||||
|
AuthorID: homeowner.ID,
|
||||||
|
Title: "Hidden",
|
||||||
|
Body: "No.",
|
||||||
|
PostDate: pacific.Today(),
|
||||||
|
PostState: store.PostStateHidden,
|
||||||
|
}
|
||||||
|
if err := mem.CreatePost(context.Background(), hidden); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if err := links.Upsert(context.Background(), store.DiscordLink{
|
||||||
|
PostID: hidden.ID,
|
||||||
|
MessageID: "d-hidden",
|
||||||
|
ThreadID: "thread-hidden",
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
cases := []inboundMessage{
|
||||||
|
{ID: "bot", ChannelID: "thread-1", GuildID: "g", AuthorID: "snow-admin", Content: "x", Bot: true},
|
||||||
|
{ID: "dm", ChannelID: "thread-1", AuthorID: "snow-admin", Content: "x"},
|
||||||
|
{ID: "self", ChannelID: "thread-1", GuildID: "g", AuthorID: "bot-1", Content: "x"},
|
||||||
|
{ID: "stranger", ChannelID: "thread-1", GuildID: "g", AuthorID: "snow-other", Content: "x"},
|
||||||
|
{ID: "elsewhere", ChannelID: "other-thread", GuildID: "g", AuthorID: "snow-admin", Content: "x"},
|
||||||
|
{ID: "empty", ChannelID: "thread-1", GuildID: "g", AuthorID: "snow-admin", Content: " ", Attachments: 1},
|
||||||
|
{ID: "hidden", ChannelID: "thread-hidden", GuildID: "g", AuthorID: "snow-admin", Content: "x"},
|
||||||
|
{ID: "channel-root", ChannelID: "channel-1", GuildID: "g", AuthorID: "snow-admin", Content: "new question"},
|
||||||
|
}
|
||||||
|
for _, in := range cases {
|
||||||
|
bot.handleInbound(in)
|
||||||
|
}
|
||||||
|
thread, err := mem.GetPostThread(context.Background(), root.ID)
|
||||||
|
if err != nil || len(thread.Replies) != 0 {
|
||||||
|
t.Fatalf("unexpected replies: %+v, %v", thread, err)
|
||||||
|
}
|
||||||
|
if len(api.sends) != 0 {
|
||||||
|
t.Fatalf("unexpected discord sends %+v", api.sends)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func inboundTestBot(mem *store.Memory, links *memoryLinks, api *fakeAPI, adminUsername string) *Bot {
|
||||||
|
bot := New("channel-1", links, api)
|
||||||
|
bot.store = mem
|
||||||
|
bot.admins = map[string]string{"snow-admin": adminUsername}
|
||||||
|
bot.botUserID = "bot-1"
|
||||||
|
return bot
|
||||||
|
}
|
||||||
|
|
||||||
|
func seedInboundUsers(t *testing.T) (*store.Memory, *store.User, *store.User) {
|
||||||
|
t.Helper()
|
||||||
|
mem := store.NewMemory()
|
||||||
|
homeowner := &store.User{
|
||||||
|
Username: "homeowner",
|
||||||
|
Name: "Sam",
|
||||||
|
Email: "sam@example.com",
|
||||||
|
PasswordHash: "x",
|
||||||
|
Role: store.RoleUser,
|
||||||
|
}
|
||||||
|
if err := mem.CreateUser(context.Background(), homeowner); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
admin := &store.User{
|
||||||
|
Username: "plumber",
|
||||||
|
Name: "Pat",
|
||||||
|
Email: "pat@example.com",
|
||||||
|
PasswordHash: "x",
|
||||||
|
Role: store.RoleAdmin,
|
||||||
|
}
|
||||||
|
if err := mem.CreateUser(context.Background(), admin); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
return mem, homeowner, admin
|
||||||
|
}
|
||||||
|
|
||||||
|
func seedLinkedRoot(t *testing.T, mem *store.Memory, links *memoryLinks, authorID, threadID string) *store.Post {
|
||||||
|
t.Helper()
|
||||||
|
root := &store.Post{
|
||||||
|
AuthorID: authorID,
|
||||||
|
Title: "Leaky sink",
|
||||||
|
Body: "It drips.",
|
||||||
|
PostDate: pacific.Today(),
|
||||||
|
}
|
||||||
|
if err := mem.CreatePost(context.Background(), root); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if err := links.Upsert(context.Background(), store.DiscordLink{
|
||||||
|
PostID: root.ID,
|
||||||
|
MessageID: "d-root",
|
||||||
|
ThreadID: threadID,
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
return root
|
||||||
|
}
|
||||||
|
|
||||||
|
func waitForMail(t *testing.T, recording *mail.Recording, want int) []mail.PostReply {
|
||||||
|
t.Helper()
|
||||||
|
deadline := time.Now().Add(2 * time.Second)
|
||||||
|
for time.Now().Before(deadline) {
|
||||||
|
if recording.Len() >= want {
|
||||||
|
return recording.Snapshot()
|
||||||
|
}
|
||||||
|
time.Sleep(10 * time.Millisecond)
|
||||||
|
}
|
||||||
|
t.Fatalf("recorded %d notifications, want %d", recording.Len(), want)
|
||||||
|
return nil
|
||||||
|
}
|
||||||
@@ -0,0 +1,88 @@
|
|||||||
|
package discord
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"database/sql"
|
||||||
|
"strings"
|
||||||
|
"sync"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"plumber/internal/store"
|
||||||
|
)
|
||||||
|
|
||||||
|
// memoryLinks is an in-process DiscordLinkStore for tests.
|
||||||
|
type memoryLinks struct {
|
||||||
|
mu sync.Mutex
|
||||||
|
byPost map[string]store.DiscordLink
|
||||||
|
byMessage map[string]string
|
||||||
|
byThread map[string]string
|
||||||
|
}
|
||||||
|
|
||||||
|
func newMemoryLinks() *memoryLinks {
|
||||||
|
return &memoryLinks{
|
||||||
|
byPost: map[string]store.DiscordLink{},
|
||||||
|
byMessage: map[string]string{},
|
||||||
|
byThread: map[string]string{},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (m *memoryLinks) GetByPostID(_ context.Context, postID string) (*store.DiscordLink, error) {
|
||||||
|
m.mu.Lock()
|
||||||
|
defer m.mu.Unlock()
|
||||||
|
link, ok := m.byPost[strings.TrimSpace(postID)]
|
||||||
|
if !ok {
|
||||||
|
return nil, sql.ErrNoRows
|
||||||
|
}
|
||||||
|
cp := link
|
||||||
|
return &cp, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func (m *memoryLinks) GetByMessageID(_ context.Context, messageID string) (*store.DiscordLink, error) {
|
||||||
|
m.mu.Lock()
|
||||||
|
defer m.mu.Unlock()
|
||||||
|
postID, ok := m.byMessage[strings.TrimSpace(messageID)]
|
||||||
|
if !ok {
|
||||||
|
return nil, sql.ErrNoRows
|
||||||
|
}
|
||||||
|
link := m.byPost[postID]
|
||||||
|
cp := link
|
||||||
|
return &cp, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func (m *memoryLinks) GetRootByThreadID(_ context.Context, threadID string) (*store.DiscordLink, error) {
|
||||||
|
m.mu.Lock()
|
||||||
|
defer m.mu.Unlock()
|
||||||
|
postID, ok := m.byThread[strings.TrimSpace(threadID)]
|
||||||
|
if !ok {
|
||||||
|
return nil, sql.ErrNoRows
|
||||||
|
}
|
||||||
|
link := m.byPost[postID]
|
||||||
|
cp := link
|
||||||
|
return &cp, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func (m *memoryLinks) Upsert(_ context.Context, link store.DiscordLink) error {
|
||||||
|
m.mu.Lock()
|
||||||
|
defer m.mu.Unlock()
|
||||||
|
link.PostID = strings.TrimSpace(link.PostID)
|
||||||
|
link.MessageID = strings.TrimSpace(link.MessageID)
|
||||||
|
link.ThreadID = strings.TrimSpace(link.ThreadID)
|
||||||
|
if link.CreatedAt == "" {
|
||||||
|
link.CreatedAt = time.Now().UTC().Format(time.RFC3339Nano)
|
||||||
|
}
|
||||||
|
if prev, ok := m.byPost[link.PostID]; ok {
|
||||||
|
delete(m.byMessage, prev.MessageID)
|
||||||
|
if prev.ThreadID != "" {
|
||||||
|
delete(m.byThread, prev.ThreadID)
|
||||||
|
}
|
||||||
|
if link.ThreadID == "" {
|
||||||
|
link.ThreadID = prev.ThreadID
|
||||||
|
}
|
||||||
|
}
|
||||||
|
m.byPost[link.PostID] = link
|
||||||
|
m.byMessage[link.MessageID] = link.PostID
|
||||||
|
if link.ThreadID != "" {
|
||||||
|
m.byThread[link.ThreadID] = link.PostID
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
@@ -0,0 +1,81 @@
|
|||||||
|
package events
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"log"
|
||||||
|
"sync"
|
||||||
|
)
|
||||||
|
|
||||||
|
const defaultBuffer = 64
|
||||||
|
|
||||||
|
// Publisher is the site-facing write side of the bus.
|
||||||
|
type Publisher interface {
|
||||||
|
Publish(ctx context.Context, ev any)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Bus is an in-process pub/sub with one worker and a bounded queue.
|
||||||
|
type Bus struct {
|
||||||
|
ch chan any
|
||||||
|
mu sync.Mutex
|
||||||
|
subs []func(context.Context, any)
|
||||||
|
closed sync.Once
|
||||||
|
}
|
||||||
|
|
||||||
|
// New starts a worker that delivers events to subscribers in publish order.
|
||||||
|
func New() *Bus {
|
||||||
|
return newBus(defaultBuffer, true)
|
||||||
|
}
|
||||||
|
|
||||||
|
func newBus(buffer int, start bool) *Bus {
|
||||||
|
if buffer < 1 {
|
||||||
|
buffer = 1
|
||||||
|
}
|
||||||
|
b := &Bus{ch: make(chan any, buffer)}
|
||||||
|
if start {
|
||||||
|
go b.loop()
|
||||||
|
}
|
||||||
|
return b
|
||||||
|
}
|
||||||
|
|
||||||
|
// Publish enqueues ev. It never blocks the caller; a full buffer is dropped.
|
||||||
|
func (b *Bus) Publish(_ context.Context, ev any) {
|
||||||
|
if b == nil {
|
||||||
|
CallRelease(ev)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
select {
|
||||||
|
case b.ch <- ev:
|
||||||
|
default:
|
||||||
|
log.Printf("events: dropped %T", ev)
|
||||||
|
CallRelease(ev)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Subscribe adds a handler. Handlers run serially on the worker.
|
||||||
|
func (b *Bus) Subscribe(fn func(context.Context, any)) {
|
||||||
|
if b == nil || fn == nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
b.mu.Lock()
|
||||||
|
b.subs = append(b.subs, fn)
|
||||||
|
b.mu.Unlock()
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *Bus) loop() {
|
||||||
|
for ev := range b.ch {
|
||||||
|
b.mu.Lock()
|
||||||
|
subs := append([]func(context.Context, any){}, b.subs...)
|
||||||
|
b.mu.Unlock()
|
||||||
|
for _, fn := range subs {
|
||||||
|
fn(context.Background(), ev)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Close stops the worker. Safe to call more than once.
|
||||||
|
func (b *Bus) Close() {
|
||||||
|
if b == nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
b.closed.Do(func() { close(b.ch) })
|
||||||
|
}
|
||||||
@@ -0,0 +1,145 @@
|
|||||||
|
package events
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"sync"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestPermalink(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
tests := []struct {
|
||||||
|
base, root, post, want string
|
||||||
|
}{
|
||||||
|
{"", "root-1", "post-2", "/questions/root-1#post-post-2"},
|
||||||
|
{"https://www.askaplumberfirst.com/", "root-1", "post-2", "https://www.askaplumberfirst.com/questions/root-1#post-post-2"},
|
||||||
|
{"https://www.askaplumberfirst.com", "a b", "c/d", "https://www.askaplumberfirst.com/questions/a%20b#post-c%2Fd"},
|
||||||
|
}
|
||||||
|
for _, tc := range tests {
|
||||||
|
if got := Permalink(tc.base, tc.root, tc.post); got != tc.want {
|
||||||
|
t.Fatalf("Permalink(%q, %q, %q) = %q, want %q", tc.base, tc.root, tc.post, got, tc.want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestNopAndRecording(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
Nop{}.Publish(context.Background(), PostCreated{})
|
||||||
|
|
||||||
|
rec := &Recording{}
|
||||||
|
rec.Publish(context.Background(), PostCreated{PostEvent: PostEvent{PostID: "a"}})
|
||||||
|
rec.Publish(context.Background(), PostUpdated{PostEvent: PostEvent{PostID: "b"}})
|
||||||
|
if rec.Len() != 2 {
|
||||||
|
t.Fatalf("len = %d", rec.Len())
|
||||||
|
}
|
||||||
|
got := rec.Snapshot()
|
||||||
|
created, ok := got[0].(PostCreated)
|
||||||
|
if !ok || created.PostID != "a" {
|
||||||
|
t.Fatalf("first = %#v", got[0])
|
||||||
|
}
|
||||||
|
updated, ok := got[1].(PostUpdated)
|
||||||
|
if !ok || updated.PostID != "b" {
|
||||||
|
t.Fatalf("second = %#v", got[1])
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestBusDeliversInOrder(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
bus := New()
|
||||||
|
defer bus.Close()
|
||||||
|
|
||||||
|
var mu sync.Mutex
|
||||||
|
var got []string
|
||||||
|
done := make(chan struct{})
|
||||||
|
bus.Subscribe(func(_ context.Context, ev any) {
|
||||||
|
mu.Lock()
|
||||||
|
got = append(got, ev.(string))
|
||||||
|
if len(got) == 3 {
|
||||||
|
close(done)
|
||||||
|
}
|
||||||
|
mu.Unlock()
|
||||||
|
})
|
||||||
|
|
||||||
|
ctx := context.Background()
|
||||||
|
bus.Publish(ctx, "one")
|
||||||
|
bus.Publish(ctx, "two")
|
||||||
|
bus.Publish(ctx, "three")
|
||||||
|
|
||||||
|
select {
|
||||||
|
case <-done:
|
||||||
|
case <-time.After(time.Second):
|
||||||
|
t.Fatal("timed out waiting for events")
|
||||||
|
}
|
||||||
|
mu.Lock()
|
||||||
|
defer mu.Unlock()
|
||||||
|
if len(got) != 3 || got[0] != "one" || got[1] != "two" || got[2] != "three" {
|
||||||
|
t.Fatalf("got %v", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestBusDropsWhenFull(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
bus := newBus(1, false)
|
||||||
|
bus.Publish(context.Background(), "kept")
|
||||||
|
bus.Publish(context.Background(), "dropped")
|
||||||
|
|
||||||
|
select {
|
||||||
|
case ev := <-bus.ch:
|
||||||
|
if ev != "kept" {
|
||||||
|
t.Fatalf("got %v", ev)
|
||||||
|
}
|
||||||
|
default:
|
||||||
|
t.Fatal("expected buffered event")
|
||||||
|
}
|
||||||
|
select {
|
||||||
|
case ev := <-bus.ch:
|
||||||
|
t.Fatalf("unexpected extra event %v", ev)
|
||||||
|
default:
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestNopReleasesPostCreated(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
released := false
|
||||||
|
Nop{}.Publish(context.Background(), PostCreated{Release: func() { released = true }})
|
||||||
|
if !released {
|
||||||
|
t.Fatal("Nop.Publish did not release held upload")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestBusDropReleasesPostCreated(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
bus := newBus(1, false)
|
||||||
|
bus.Publish(context.Background(), "kept")
|
||||||
|
released := false
|
||||||
|
bus.Publish(context.Background(), PostCreated{Release: func() { released = true }})
|
||||||
|
if !released {
|
||||||
|
t.Fatal("dropped PostCreated did not release held upload")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestSubscribeReleasePostedToDiscord(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
bus := New()
|
||||||
|
defer bus.Close()
|
||||||
|
SubscribeRelease(bus)
|
||||||
|
|
||||||
|
released := make(chan struct{})
|
||||||
|
bus.Publish(context.Background(), PostedToDiscord{
|
||||||
|
PostID: "post-1",
|
||||||
|
Release: func() { close(released) },
|
||||||
|
})
|
||||||
|
select {
|
||||||
|
case <-released:
|
||||||
|
case <-time.After(time.Second):
|
||||||
|
t.Fatal("PostedToDiscord did not release")
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,69 @@
|
|||||||
|
package events
|
||||||
|
|
||||||
|
import (
|
||||||
|
"io"
|
||||||
|
"net/url"
|
||||||
|
"strings"
|
||||||
|
)
|
||||||
|
|
||||||
|
// Image is a public photo or video already attached to a site post.
|
||||||
|
type Image struct {
|
||||||
|
URL string
|
||||||
|
Description string
|
||||||
|
Kind string
|
||||||
|
}
|
||||||
|
|
||||||
|
// Media is a local upload still held from the create request so Discord can
|
||||||
|
// attach the bytes. Photos carry re-encoded Bytes; videos carry an open Body.
|
||||||
|
type Media struct {
|
||||||
|
Name string
|
||||||
|
ContentType string
|
||||||
|
Kind string
|
||||||
|
Size int64
|
||||||
|
Body io.ReadCloser
|
||||||
|
Bytes []byte
|
||||||
|
}
|
||||||
|
|
||||||
|
// PostEvent is a Discord-free snapshot of a site post after a successful write.
|
||||||
|
type PostEvent struct {
|
||||||
|
PostID string
|
||||||
|
RootID string
|
||||||
|
ParentID string
|
||||||
|
Title string
|
||||||
|
Body string
|
||||||
|
City string
|
||||||
|
AuthorID string
|
||||||
|
AuthorName string
|
||||||
|
AuthorRole string
|
||||||
|
Images []Image
|
||||||
|
Permalink string
|
||||||
|
}
|
||||||
|
|
||||||
|
// PostCreated is emitted after a successful site create.
|
||||||
|
type PostCreated struct {
|
||||||
|
PostEvent
|
||||||
|
Media []Media `json:"-"`
|
||||||
|
Release func() `json:"-"`
|
||||||
|
}
|
||||||
|
|
||||||
|
// PostUpdated is emitted after a successful site edit.
|
||||||
|
type PostUpdated struct {
|
||||||
|
PostEvent
|
||||||
|
}
|
||||||
|
|
||||||
|
// PostedToDiscord is emitted after the Discord subscriber finishes with a
|
||||||
|
// PostCreated (sent, skipped, or failed). Release deletes held upload files.
|
||||||
|
type PostedToDiscord struct {
|
||||||
|
PostID string
|
||||||
|
Release func() `json:"-"`
|
||||||
|
}
|
||||||
|
|
||||||
|
// Permalink builds /questions/{root}#post-{id}, prefixed by baseURL when set.
|
||||||
|
func Permalink(baseURL, rootID, postID string) string {
|
||||||
|
path := "/questions/" + url.PathEscape(rootID) + "#post-" + url.PathEscape(postID)
|
||||||
|
base := strings.TrimRight(strings.TrimSpace(baseURL), "/")
|
||||||
|
if base == "" {
|
||||||
|
return path
|
||||||
|
}
|
||||||
|
return base + path
|
||||||
|
}
|
||||||
@@ -0,0 +1,11 @@
|
|||||||
|
package events
|
||||||
|
|
||||||
|
import "context"
|
||||||
|
|
||||||
|
// Nop is a Publisher used when nothing is subscribed.
|
||||||
|
type Nop struct{}
|
||||||
|
|
||||||
|
// Publish discards ev after releasing any held upload.
|
||||||
|
func (Nop) Publish(_ context.Context, ev any) {
|
||||||
|
CallRelease(ev)
|
||||||
|
}
|
||||||
@@ -0,0 +1,44 @@
|
|||||||
|
package events
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"sync"
|
||||||
|
)
|
||||||
|
|
||||||
|
// Recording is a test Publisher that records events synchronously.
|
||||||
|
type Recording struct {
|
||||||
|
mu sync.Mutex
|
||||||
|
evs []any
|
||||||
|
}
|
||||||
|
|
||||||
|
// Publish appends ev.
|
||||||
|
func (r *Recording) Publish(_ context.Context, ev any) {
|
||||||
|
if r == nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
r.mu.Lock()
|
||||||
|
defer r.mu.Unlock()
|
||||||
|
r.evs = append(r.evs, ev)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Len returns the number of recorded events.
|
||||||
|
func (r *Recording) Len() int {
|
||||||
|
if r == nil {
|
||||||
|
return 0
|
||||||
|
}
|
||||||
|
r.mu.Lock()
|
||||||
|
defer r.mu.Unlock()
|
||||||
|
return len(r.evs)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Snapshot returns a copy of recorded events.
|
||||||
|
func (r *Recording) Snapshot() []any {
|
||||||
|
if r == nil {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
r.mu.Lock()
|
||||||
|
defer r.mu.Unlock()
|
||||||
|
out := make([]any, len(r.evs))
|
||||||
|
copy(out, r.evs)
|
||||||
|
return out
|
||||||
|
}
|
||||||
@@ -0,0 +1,41 @@
|
|||||||
|
package events
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"sync"
|
||||||
|
)
|
||||||
|
|
||||||
|
// Once returns fn wrapped so it runs at most once.
|
||||||
|
func Once(fn func()) func() {
|
||||||
|
if fn == nil {
|
||||||
|
return func() {}
|
||||||
|
}
|
||||||
|
var once sync.Once
|
||||||
|
return func() { once.Do(fn) }
|
||||||
|
}
|
||||||
|
|
||||||
|
// CallRelease runs Release on PostCreated or PostedToDiscord when set.
|
||||||
|
func CallRelease(ev any) {
|
||||||
|
switch e := ev.(type) {
|
||||||
|
case PostCreated:
|
||||||
|
if e.Release != nil {
|
||||||
|
e.Release()
|
||||||
|
}
|
||||||
|
case PostedToDiscord:
|
||||||
|
if e.Release != nil {
|
||||||
|
e.Release()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// SubscribeRelease runs PostedToDiscord.Release on the worker.
|
||||||
|
func SubscribeRelease(bus *Bus) {
|
||||||
|
if bus == nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
bus.Subscribe(func(_ context.Context, ev any) {
|
||||||
|
if _, ok := ev.(PostedToDiscord); ok {
|
||||||
|
CallRelease(ev)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
@@ -0,0 +1,89 @@
|
|||||||
|
package mail
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"log"
|
||||||
|
"strings"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"plumber/internal/events"
|
||||||
|
"plumber/internal/store"
|
||||||
|
)
|
||||||
|
|
||||||
|
// Subscribe sends reply emails from PostCreated events. Nop or nil is a no-op.
|
||||||
|
func Subscribe(bus *events.Bus, st store.Store, n Notifier) {
|
||||||
|
if bus == nil || st == nil || n == nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if _, disabled := n.(Nop); disabled {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
s := subscriber{store: st, mail: n}
|
||||||
|
bus.Subscribe(s.handle)
|
||||||
|
}
|
||||||
|
|
||||||
|
type subscriber struct {
|
||||||
|
store store.Store
|
||||||
|
mail Notifier
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s subscriber) handle(_ context.Context, ev any) {
|
||||||
|
created, ok := ev.(events.PostCreated)
|
||||||
|
if !ok {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if strings.TrimSpace(created.ParentID) == "" {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
go s.notifyReply(created.PostEvent)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s subscriber) notifyReply(ev events.PostEvent) {
|
||||||
|
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
|
||||||
|
defer cancel()
|
||||||
|
|
||||||
|
parent, err := s.store.GetPost(ctx, ev.ParentID)
|
||||||
|
if err != nil {
|
||||||
|
log.Printf("notify reply %s: load parent: %v", ev.PostID, err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
root, err := s.store.GetPost(ctx, ev.RootID)
|
||||||
|
if err != nil {
|
||||||
|
log.Printf("notify reply %s: load root: %v", ev.PostID, err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
author, err := s.store.UserByID(ctx, ev.AuthorID)
|
||||||
|
if err != nil {
|
||||||
|
log.Printf("notify reply %s: load author: %v", ev.PostID, err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
recipientID := parent.AuthorID
|
||||||
|
if author.Admin() {
|
||||||
|
recipientID = root.AuthorID
|
||||||
|
}
|
||||||
|
if recipientID == author.ID {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
msg := PostReply{
|
||||||
|
RootID: root.ID,
|
||||||
|
RootTitle: root.Title,
|
||||||
|
ReplyID: ev.PostID,
|
||||||
|
ReplyBody: ev.Body,
|
||||||
|
ReplyAuthorName: author.Name,
|
||||||
|
}
|
||||||
|
recipient, err := s.store.UserByID(ctx, recipientID)
|
||||||
|
if err != nil {
|
||||||
|
log.Printf("notify reply %s: load recipient: %v", msg.ReplyID, err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if recipient == nil || strings.TrimSpace(recipient.Email) == "" {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
msg.ToEmail = recipient.Email
|
||||||
|
msg.ToName = recipient.Name
|
||||||
|
if err := s.mail.NotifyPostReply(ctx, msg); err != nil {
|
||||||
|
log.Printf("notify reply %s: %v", msg.ReplyID, err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
log.Printf("notify reply %s: accepted", msg.ReplyID)
|
||||||
|
}
|
||||||
@@ -0,0 +1,200 @@
|
|||||||
|
package mail
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"plumber/internal/events"
|
||||||
|
"plumber/internal/pacific"
|
||||||
|
"plumber/internal/store"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestSubscribeReplyNotifications(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
mem := store.NewMemory()
|
||||||
|
homeowner := seedMailUser(t, mem, "homeowner", store.RoleUser, "sam@example.com")
|
||||||
|
admin := seedMailUser(t, mem, "plumber", store.RoleAdmin, "pat@example.com")
|
||||||
|
root := seedMailRoot(t, mem, homeowner.ID, "Leaky sink", "It drips.")
|
||||||
|
adminReply := seedMailReply(t, mem, admin.ID, root.ID)
|
||||||
|
homeownerReply := seedMailReply(t, mem, homeowner.ID, adminReply.ID)
|
||||||
|
|
||||||
|
bus := events.New()
|
||||||
|
defer bus.Close()
|
||||||
|
recording := &Recording{}
|
||||||
|
Subscribe(bus, mem, recording)
|
||||||
|
|
||||||
|
ctx := context.Background()
|
||||||
|
bus.Publish(ctx, events.PostCreated{PostEvent: events.PostEvent{
|
||||||
|
PostID: root.ID,
|
||||||
|
RootID: root.ID,
|
||||||
|
Title: root.Title,
|
||||||
|
Body: root.Body,
|
||||||
|
AuthorID: homeowner.ID,
|
||||||
|
}})
|
||||||
|
bus.Publish(ctx, events.PostUpdated{PostEvent: events.PostEvent{
|
||||||
|
PostID: adminReply.ID,
|
||||||
|
RootID: root.ID,
|
||||||
|
ParentID: root.ID,
|
||||||
|
Body: "Edited",
|
||||||
|
AuthorID: admin.ID,
|
||||||
|
}})
|
||||||
|
|
||||||
|
bus.Publish(ctx, events.PostCreated{PostEvent: events.PostEvent{
|
||||||
|
PostID: adminReply.ID,
|
||||||
|
RootID: root.ID,
|
||||||
|
ParentID: root.ID,
|
||||||
|
Body: adminReply.Body,
|
||||||
|
AuthorID: admin.ID,
|
||||||
|
}})
|
||||||
|
msgs := waitForMail(t, recording, 1)
|
||||||
|
if msg := msgs[0]; msg.ToEmail != homeowner.Email ||
|
||||||
|
msg.RootID != root.ID ||
|
||||||
|
msg.RootTitle != root.Title ||
|
||||||
|
msg.ReplyID != adminReply.ID ||
|
||||||
|
msg.ReplyBody != adminReply.Body ||
|
||||||
|
msg.ReplyAuthorName != admin.Name {
|
||||||
|
t.Fatalf("admin reply = %+v", msg)
|
||||||
|
}
|
||||||
|
|
||||||
|
bus.Publish(ctx, events.PostCreated{PostEvent: events.PostEvent{
|
||||||
|
PostID: homeownerReply.ID,
|
||||||
|
RootID: root.ID,
|
||||||
|
ParentID: adminReply.ID,
|
||||||
|
Body: homeownerReply.Body,
|
||||||
|
AuthorID: homeowner.ID,
|
||||||
|
}})
|
||||||
|
msgs = waitForMail(t, recording, 2)
|
||||||
|
if msg := msgs[1]; msg.ToEmail != admin.Email ||
|
||||||
|
msg.RootID != root.ID ||
|
||||||
|
msg.ReplyID != homeownerReply.ID ||
|
||||||
|
msg.ReplyAuthorName != homeowner.Name {
|
||||||
|
t.Fatalf("homeowner reply = %+v", msg)
|
||||||
|
}
|
||||||
|
|
||||||
|
nestedAdmin := seedMailReply(t, mem, admin.ID, adminReply.ID)
|
||||||
|
bus.Publish(ctx, events.PostCreated{PostEvent: events.PostEvent{
|
||||||
|
PostID: nestedAdmin.ID,
|
||||||
|
RootID: root.ID,
|
||||||
|
ParentID: adminReply.ID,
|
||||||
|
Body: nestedAdmin.Body,
|
||||||
|
AuthorID: admin.ID,
|
||||||
|
}})
|
||||||
|
msgs = waitForMail(t, recording, 3)
|
||||||
|
if msg := msgs[2]; msg.ToEmail != homeowner.Email ||
|
||||||
|
msg.RootID != root.ID ||
|
||||||
|
msg.ReplyBody != nestedAdmin.Body ||
|
||||||
|
msg.ReplyAuthorName != admin.Name {
|
||||||
|
t.Fatalf("nested admin reply = %+v", msg)
|
||||||
|
}
|
||||||
|
|
||||||
|
self := seedMailReply(t, mem, homeowner.ID, root.ID)
|
||||||
|
bus.Publish(ctx, events.PostCreated{PostEvent: events.PostEvent{
|
||||||
|
PostID: self.ID,
|
||||||
|
RootID: root.ID,
|
||||||
|
ParentID: root.ID,
|
||||||
|
Body: self.Body,
|
||||||
|
AuthorID: homeowner.ID,
|
||||||
|
}})
|
||||||
|
|
||||||
|
noEmail := seedMailUser(t, mem, "quiet", store.RoleUser, "")
|
||||||
|
quietRoot := seedMailRoot(t, mem, noEmail.ID, "Quiet thread", "No email.")
|
||||||
|
quietReply := seedMailReply(t, mem, admin.ID, quietRoot.ID)
|
||||||
|
bus.Publish(ctx, events.PostCreated{PostEvent: events.PostEvent{
|
||||||
|
PostID: quietReply.ID,
|
||||||
|
RootID: quietRoot.ID,
|
||||||
|
ParentID: quietRoot.ID,
|
||||||
|
Body: quietReply.Body,
|
||||||
|
AuthorID: admin.ID,
|
||||||
|
}})
|
||||||
|
|
||||||
|
time.Sleep(50 * time.Millisecond)
|
||||||
|
if recording.Len() != 3 {
|
||||||
|
t.Fatalf("self, root, edit, or no-email sent mail: %+v", recording.Snapshot())
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestSubscribeNopIgnoresReplies(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
mem := store.NewMemory()
|
||||||
|
homeowner := seedMailUser(t, mem, "homeowner", store.RoleUser, "sam@example.com")
|
||||||
|
admin := seedMailUser(t, mem, "plumber", store.RoleAdmin, "pat@example.com")
|
||||||
|
root := seedMailRoot(t, mem, homeowner.ID, "Leaky sink", "It drips.")
|
||||||
|
reply := seedMailReply(t, mem, admin.ID, root.ID)
|
||||||
|
|
||||||
|
bus := events.New()
|
||||||
|
defer bus.Close()
|
||||||
|
recording := &Recording{}
|
||||||
|
Subscribe(bus, mem, Nop{})
|
||||||
|
Subscribe(nil, mem, recording)
|
||||||
|
Subscribe(bus, mem, nil)
|
||||||
|
|
||||||
|
bus.Publish(context.Background(), events.PostCreated{PostEvent: events.PostEvent{
|
||||||
|
PostID: reply.ID,
|
||||||
|
RootID: root.ID,
|
||||||
|
ParentID: root.ID,
|
||||||
|
Body: reply.Body,
|
||||||
|
AuthorID: admin.ID,
|
||||||
|
}})
|
||||||
|
time.Sleep(50 * time.Millisecond)
|
||||||
|
if recording.Len() != 0 {
|
||||||
|
t.Fatalf("Nop or nil subscribe sent mail: %+v", recording.Snapshot())
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func seedMailUser(t *testing.T, mem *store.Memory, username string, role store.Role, email string) *store.User {
|
||||||
|
t.Helper()
|
||||||
|
u := &store.User{
|
||||||
|
Username: username,
|
||||||
|
Name: username,
|
||||||
|
Email: email,
|
||||||
|
PasswordHash: "x",
|
||||||
|
Role: role,
|
||||||
|
}
|
||||||
|
if err := mem.CreateUser(context.Background(), u); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
return u
|
||||||
|
}
|
||||||
|
|
||||||
|
func seedMailRoot(t *testing.T, mem *store.Memory, authorID, title, body string) *store.Post {
|
||||||
|
t.Helper()
|
||||||
|
root := &store.Post{
|
||||||
|
AuthorID: authorID,
|
||||||
|
Title: title,
|
||||||
|
Body: body,
|
||||||
|
PostDate: pacific.Today(),
|
||||||
|
}
|
||||||
|
if err := mem.CreatePost(context.Background(), root); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
return root
|
||||||
|
}
|
||||||
|
|
||||||
|
func seedMailReply(t *testing.T, mem *store.Memory, authorID, parentID string) *store.Post {
|
||||||
|
t.Helper()
|
||||||
|
reply := &store.Post{
|
||||||
|
ParentID: &parentID,
|
||||||
|
AuthorID: authorID,
|
||||||
|
Body: "Reply from " + authorID,
|
||||||
|
}
|
||||||
|
if err := mem.CreatePost(context.Background(), reply); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
return reply
|
||||||
|
}
|
||||||
|
|
||||||
|
func waitForMail(t *testing.T, recording *Recording, want int) []PostReply {
|
||||||
|
t.Helper()
|
||||||
|
deadline := time.Now().Add(2 * time.Second)
|
||||||
|
for time.Now().Before(deadline) {
|
||||||
|
if recording.Len() >= want {
|
||||||
|
return recording.Snapshot()
|
||||||
|
}
|
||||||
|
time.Sleep(10 * time.Millisecond)
|
||||||
|
}
|
||||||
|
t.Fatalf("recorded %d notifications, want %d", recording.Len(), want)
|
||||||
|
return nil
|
||||||
|
}
|
||||||
@@ -0,0 +1,105 @@
|
|||||||
|
package store
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"database/sql"
|
||||||
|
"fmt"
|
||||||
|
"strings"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"plumber/internal/store/sqlc"
|
||||||
|
)
|
||||||
|
|
||||||
|
// DiscordLink is the bot-owned mapping from a site post to a Discord message.
|
||||||
|
type DiscordLink struct {
|
||||||
|
PostID string
|
||||||
|
MessageID string
|
||||||
|
ThreadID string
|
||||||
|
CreatedAt string
|
||||||
|
}
|
||||||
|
|
||||||
|
// DiscordLinkStore is the mapping table used only by the Discord subscriber.
|
||||||
|
// It is not part of Store.
|
||||||
|
type DiscordLinkStore interface {
|
||||||
|
GetByPostID(ctx context.Context, postID string) (*DiscordLink, error)
|
||||||
|
GetByMessageID(ctx context.Context, messageID string) (*DiscordLink, error)
|
||||||
|
GetRootByThreadID(ctx context.Context, threadID string) (*DiscordLink, error)
|
||||||
|
Upsert(ctx context.Context, link DiscordLink) error
|
||||||
|
}
|
||||||
|
|
||||||
|
// DiscordLinks implements DiscordLinkStore against Postgres.
|
||||||
|
type DiscordLinks struct {
|
||||||
|
db *sql.DB
|
||||||
|
}
|
||||||
|
|
||||||
|
// NewDiscordLinks wraps db. It is independent of Store.
|
||||||
|
func NewDiscordLinks(db *sql.DB) *DiscordLinks {
|
||||||
|
return &DiscordLinks{db: db}
|
||||||
|
}
|
||||||
|
|
||||||
|
// GetByPostID returns the link for a site post.
|
||||||
|
func (d *DiscordLinks) GetByPostID(ctx context.Context, postID string) (*DiscordLink, error) {
|
||||||
|
if d == nil || d.db == nil {
|
||||||
|
return nil, fmt.Errorf("discord links: no database")
|
||||||
|
}
|
||||||
|
row, err := sqlc.New(d.db).GetDiscordPostLinkByPostID(ctx, strings.TrimSpace(postID))
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
return discordLinkFromRow(row), nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// GetByMessageID returns the link for a Discord message.
|
||||||
|
func (d *DiscordLinks) GetByMessageID(ctx context.Context, messageID string) (*DiscordLink, error) {
|
||||||
|
if d == nil || d.db == nil {
|
||||||
|
return nil, fmt.Errorf("discord links: no database")
|
||||||
|
}
|
||||||
|
row, err := sqlc.New(d.db).GetDiscordPostLinkByMessageID(ctx, strings.TrimSpace(messageID))
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
return discordLinkFromRow(row), nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// GetRootByThreadID returns the root link for a Discord thread.
|
||||||
|
func (d *DiscordLinks) GetRootByThreadID(ctx context.Context, threadID string) (*DiscordLink, error) {
|
||||||
|
if d == nil || d.db == nil {
|
||||||
|
return nil, fmt.Errorf("discord links: no database")
|
||||||
|
}
|
||||||
|
row, err := sqlc.New(d.db).GetDiscordPostLinkByThreadID(ctx, strings.TrimSpace(threadID))
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
return discordLinkFromRow(row), nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// Upsert inserts or replaces the Discord IDs for a post.
|
||||||
|
func (d *DiscordLinks) Upsert(ctx context.Context, link DiscordLink) error {
|
||||||
|
if d == nil || d.db == nil {
|
||||||
|
return fmt.Errorf("discord links: no database")
|
||||||
|
}
|
||||||
|
link.PostID = strings.TrimSpace(link.PostID)
|
||||||
|
link.MessageID = strings.TrimSpace(link.MessageID)
|
||||||
|
link.ThreadID = strings.TrimSpace(link.ThreadID)
|
||||||
|
if link.PostID == "" || link.MessageID == "" {
|
||||||
|
return fmt.Errorf("discord links: post and message ids are required")
|
||||||
|
}
|
||||||
|
if link.CreatedAt == "" {
|
||||||
|
link.CreatedAt = time.Now().UTC().Format(time.RFC3339Nano)
|
||||||
|
}
|
||||||
|
return sqlc.New(d.db).UpsertDiscordPostLink(ctx, sqlc.UpsertDiscordPostLinkParams{
|
||||||
|
PostID: link.PostID,
|
||||||
|
DiscordMessageID: link.MessageID,
|
||||||
|
DiscordThreadID: link.ThreadID,
|
||||||
|
CreatedAt: link.CreatedAt,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
func discordLinkFromRow(row sqlc.DiscordPostLink) *DiscordLink {
|
||||||
|
return &DiscordLink{
|
||||||
|
PostID: row.PostID,
|
||||||
|
MessageID: row.DiscordMessageID,
|
||||||
|
ThreadID: row.DiscordThreadID,
|
||||||
|
CreatedAt: row.CreatedAt,
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -209,6 +209,9 @@ func (m *Memory) CreatePost(_ context.Context, post *Post) error {
|
|||||||
if err := preparePost(post); err != nil {
|
if err := preparePost(post); err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
if err := preparePostImages(post); err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
m.mu.Lock()
|
m.mu.Lock()
|
||||||
defer m.mu.Unlock()
|
defer m.mu.Unlock()
|
||||||
if _, ok := m.users[post.AuthorID]; !ok {
|
if _, ok := m.users[post.AuthorID]; !ok {
|
||||||
@@ -287,6 +290,10 @@ func (m *Memory) UpdatePost(_ context.Context, post *Post) error {
|
|||||||
if body == "" {
|
if body == "" {
|
||||||
return fmt.Errorf("%w: body is required", ErrInvalidPost)
|
return fmt.Errorf("%w: body is required", ErrInvalidPost)
|
||||||
}
|
}
|
||||||
|
post.Body = body
|
||||||
|
if err := preparePostImages(post); err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
m.mu.Lock()
|
m.mu.Lock()
|
||||||
defer m.mu.Unlock()
|
defer m.mu.Unlock()
|
||||||
existing, ok := m.posts[post.ID]
|
existing, ok := m.posts[post.ID]
|
||||||
@@ -294,6 +301,7 @@ func (m *Memory) UpdatePost(_ context.Context, post *Post) error {
|
|||||||
return sql.ErrNoRows
|
return sql.ErrNoRows
|
||||||
}
|
}
|
||||||
existing.Body = body
|
existing.Body = body
|
||||||
|
existing.Images = append([]PostImage(nil), post.Images...)
|
||||||
existing.UpdatedAt = time.Now().UTC().Format(time.RFC3339Nano)
|
existing.UpdatedAt = time.Now().UTC().Format(time.RFC3339Nano)
|
||||||
*post = *clonePostWithAuthor(existing, m.users)
|
*post = *clonePostWithAuthor(existing, m.users)
|
||||||
return nil
|
return nil
|
||||||
@@ -451,6 +459,7 @@ func clonePost(post *Post) *Post {
|
|||||||
parentID := *post.ParentID
|
parentID := *post.ParentID
|
||||||
cp.ParentID = &parentID
|
cp.ParentID = &parentID
|
||||||
}
|
}
|
||||||
|
cp.Images = append([]PostImage(nil), post.Images...)
|
||||||
cp.Replies = nil
|
cp.Replies = nil
|
||||||
return &cp
|
return &cp
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -120,6 +120,70 @@ func migrateDropLegacyPostTables(ctx context.Context, exec execContext) error {
|
|||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func migratePostImages(ctx context.Context, exec execContext) error {
|
||||||
|
if _, err := exec.ExecContext(ctx, `
|
||||||
|
CREATE TABLE IF NOT EXISTS post_images (
|
||||||
|
id TEXT PRIMARY KEY,
|
||||||
|
post_id TEXT NOT NULL REFERENCES posts(id) ON DELETE CASCADE,
|
||||||
|
object_key TEXT NOT NULL UNIQUE,
|
||||||
|
public_url TEXT NOT NULL,
|
||||||
|
description TEXT NOT NULL DEFAULT '' CHECK (char_length(description) <= 500),
|
||||||
|
position SMALLINT NOT NULL CHECK (position BETWEEN 0 AND 3),
|
||||||
|
width INTEGER NOT NULL CHECK (width > 0),
|
||||||
|
height INTEGER NOT NULL CHECK (height > 0),
|
||||||
|
created_at TEXT NOT NULL,
|
||||||
|
UNIQUE (post_id, position)
|
||||||
|
)`); err != nil {
|
||||||
|
return fmt.Errorf("create post images: %w", err)
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func migrateDiscordPostLinks(ctx context.Context, exec execContext) error {
|
||||||
|
if _, err := exec.ExecContext(ctx, `
|
||||||
|
CREATE TABLE IF NOT EXISTS discord_post_links (
|
||||||
|
post_id TEXT PRIMARY KEY REFERENCES posts(id) ON DELETE CASCADE,
|
||||||
|
discord_message_id TEXT NOT NULL UNIQUE,
|
||||||
|
discord_thread_id TEXT NOT NULL DEFAULT '',
|
||||||
|
created_at TEXT NOT NULL
|
||||||
|
)`); err != nil {
|
||||||
|
return fmt.Errorf("create discord_post_links: %w", err)
|
||||||
|
}
|
||||||
|
if _, err := exec.ExecContext(ctx, `
|
||||||
|
CREATE UNIQUE INDEX IF NOT EXISTS discord_post_links_thread_uidx
|
||||||
|
ON discord_post_links (discord_thread_id)
|
||||||
|
WHERE discord_thread_id <> ''`); err != nil {
|
||||||
|
return fmt.Errorf("discord_post_links_thread_uidx: %w", err)
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func migratePostImageVideo(ctx context.Context, exec execContext) error {
|
||||||
|
steps := []struct {
|
||||||
|
name string
|
||||||
|
sql string
|
||||||
|
}{
|
||||||
|
{"add kind", `ALTER TABLE post_images ADD COLUMN IF NOT EXISTS kind TEXT NOT NULL DEFAULT 'image'`},
|
||||||
|
{"drop kind check", `ALTER TABLE post_images DROP CONSTRAINT IF EXISTS post_images_kind_check`},
|
||||||
|
{"add kind check", `ALTER TABLE post_images ADD CONSTRAINT post_images_kind_check CHECK (kind IN ('image', 'video'))`},
|
||||||
|
{"drop width check", `ALTER TABLE post_images DROP CONSTRAINT IF EXISTS post_images_width_check`},
|
||||||
|
{"drop height check", `ALTER TABLE post_images DROP CONSTRAINT IF EXISTS post_images_height_check`},
|
||||||
|
{"add width check", `ALTER TABLE post_images ADD CONSTRAINT post_images_width_check CHECK (width >= 0)`},
|
||||||
|
{"add height check", `ALTER TABLE post_images ADD CONSTRAINT post_images_height_check CHECK (height >= 0)`},
|
||||||
|
{"drop image dims check", `ALTER TABLE post_images DROP CONSTRAINT IF EXISTS post_images_image_dims_check`},
|
||||||
|
{"add image dims check", `ALTER TABLE post_images ADD CONSTRAINT post_images_image_dims_check CHECK (kind <> 'image' OR (width > 0 AND height > 0))`},
|
||||||
|
{"drop position check", `ALTER TABLE post_images DROP CONSTRAINT IF EXISTS post_images_position_check`},
|
||||||
|
{"add position check", `ALTER TABLE post_images ADD CONSTRAINT post_images_position_check CHECK (position BETWEEN 0 AND 4)`},
|
||||||
|
{"one video index", `CREATE UNIQUE INDEX IF NOT EXISTS post_images_one_video_uidx ON post_images (post_id) WHERE kind = 'video'`},
|
||||||
|
}
|
||||||
|
for _, step := range steps {
|
||||||
|
if _, err := exec.ExecContext(ctx, step.sql); err != nil {
|
||||||
|
return fmt.Errorf("%s: %w", step.name, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
func migratePostDate(ctx context.Context, exec execContext) error {
|
func migratePostDate(ctx context.Context, exec execContext) error {
|
||||||
steps := []struct {
|
steps := []struct {
|
||||||
name string
|
name string
|
||||||
@@ -311,6 +375,9 @@ CREATE TABLE IF NOT EXISTS schema_migrations (
|
|||||||
{"007_post_state", migratePostState},
|
{"007_post_state", migratePostState},
|
||||||
{"008_post_author_index", migratePostAuthorIndex},
|
{"008_post_author_index", migratePostAuthorIndex},
|
||||||
{"009_drop_legacy_post_tables", migrateDropLegacyPostTables},
|
{"009_drop_legacy_post_tables", migrateDropLegacyPostTables},
|
||||||
|
{"010_post_images", migratePostImages},
|
||||||
|
{"011_discord_post_links", migrateDiscordPostLinks},
|
||||||
|
{"012_post_image_video", migratePostImageVideo},
|
||||||
}
|
}
|
||||||
for _, m := range migrations {
|
for _, m := range migrations {
|
||||||
if applied[m.version] {
|
if applied[m.version] {
|
||||||
|
|||||||
@@ -75,6 +75,24 @@ CREATE TABLE users (
|
|||||||
if err := migratePostAuthorIndex(ctx, conn); err != nil {
|
if err := migratePostAuthorIndex(ctx, conn); err != nil {
|
||||||
t.Fatalf("post author index migration is not idempotent: %v", err)
|
t.Fatalf("post author index migration is not idempotent: %v", err)
|
||||||
}
|
}
|
||||||
|
if err := migratePostImages(ctx, conn); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if err := migratePostImages(ctx, conn); err != nil {
|
||||||
|
t.Fatalf("post images migration is not idempotent: %v", err)
|
||||||
|
}
|
||||||
|
if err := migrateDiscordPostLinks(ctx, conn); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if err := migrateDiscordPostLinks(ctx, conn); err != nil {
|
||||||
|
t.Fatalf("discord post links migration is not idempotent: %v", err)
|
||||||
|
}
|
||||||
|
if err := migratePostImageVideo(ctx, conn); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if err := migratePostImageVideo(ctx, conn); err != nil {
|
||||||
|
t.Fatalf("post image video migration is not idempotent: %v", err)
|
||||||
|
}
|
||||||
if _, err := conn.ExecContext(ctx, `
|
if _, err := conn.ExecContext(ctx, `
|
||||||
INSERT INTO users (id, name, role)
|
INSERT INTO users (id, name, role)
|
||||||
VALUES ('homeowner', 'Home Owner', 'user'), ('plumber', 'The Plumber', 'admin');
|
VALUES ('homeowner', 'Home Owner', 'user'), ('plumber', 'The Plumber', 'admin');
|
||||||
@@ -104,6 +122,89 @@ VALUES ('homeowner', 'root-1', 1);`); err != nil {
|
|||||||
if postCount != 2 || voteCount != 1 {
|
if postCount != 2 || voteCount != 1 {
|
||||||
t.Fatalf("counts posts=%d votes=%d", postCount, voteCount)
|
t.Fatalf("counts posts=%d votes=%d", postCount, voteCount)
|
||||||
}
|
}
|
||||||
|
imageQueries := sqlc.New(conn)
|
||||||
|
for _, image := range []sqlc.CreatePostImageParams{
|
||||||
|
{ID: "root-image-1", PostID: "root-1", ObjectKey: "posts/root-1/1.jpg", PublicUrl: "https://cdn.example/root-1.jpg", Description: "Valve", Kind: "image", Position: 0, Width: 1200, Height: 900, CreatedAt: "2026-08-26T08:00:00Z"},
|
||||||
|
{ID: "root-image-2", PostID: "root-1", ObjectKey: "posts/root-1/2.png", PublicUrl: "https://cdn.example/root-2.png", Kind: "image", Position: 1, Width: 900, Height: 1200, CreatedAt: "2026-08-26T08:00:00Z"},
|
||||||
|
{ID: "reply-image-1", PostID: "reply-1", ObjectKey: "posts/reply-1/1.jpg", PublicUrl: "https://cdn.example/reply-1.jpg", Description: "Cartridge", Kind: "image", Position: 0, Width: 1000, Height: 1000, CreatedAt: "2026-08-26T09:00:00Z"},
|
||||||
|
} {
|
||||||
|
if err := imageQueries.CreatePostImage(ctx, image); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
rootImages, err := imageQueries.ListPostImages(ctx, "root-1")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if len(rootImages) != 2 ||
|
||||||
|
rootImages[0].ID != "root-image-1" ||
|
||||||
|
rootImages[1].ID != "root-image-2" {
|
||||||
|
t.Fatalf("root images = %+v", rootImages)
|
||||||
|
}
|
||||||
|
threadImages, err := imageQueries.ListPostThreadImages(ctx, "root-1")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if len(threadImages) != 3 {
|
||||||
|
t.Fatalf("thread images = %+v", threadImages)
|
||||||
|
}
|
||||||
|
if err := imageQueries.CreatePostImage(ctx, sqlc.CreatePostImageParams{
|
||||||
|
ID: "too-many", PostID: "root-1", ObjectKey: "posts/root-1/5.jpg",
|
||||||
|
PublicUrl: "https://cdn.example/root-5.jpg", Kind: "image", Position: 5,
|
||||||
|
Width: 100, Height: 100, CreatedAt: "2026-08-26T08:00:00Z",
|
||||||
|
}); err == nil {
|
||||||
|
t.Fatal("position 5 unexpectedly succeeded")
|
||||||
|
}
|
||||||
|
if err := imageQueries.CreatePostImage(ctx, sqlc.CreatePostImageParams{
|
||||||
|
ID: "root-video-1", PostID: "root-1", ObjectKey: "posts/root-1/clip.mp4",
|
||||||
|
PublicUrl: "https://cdn.example/clip.mp4", Kind: "video", Position: 2,
|
||||||
|
Width: 0, Height: 0, CreatedAt: "2026-08-26T08:00:00Z",
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if err := imageQueries.CreatePostImage(ctx, sqlc.CreatePostImageParams{
|
||||||
|
ID: "root-video-2", PostID: "root-1", ObjectKey: "posts/root-1/clip-2.mp4",
|
||||||
|
PublicUrl: "https://cdn.example/clip-2.mp4", Kind: "video", Position: 3,
|
||||||
|
Width: 0, Height: 0, CreatedAt: "2026-08-26T08:00:00Z",
|
||||||
|
}); err == nil {
|
||||||
|
t.Fatal("second video unexpectedly succeeded")
|
||||||
|
}
|
||||||
|
if err := imageQueries.UpsertDiscordPostLink(ctx, sqlc.UpsertDiscordPostLinkParams{
|
||||||
|
PostID: "root-1",
|
||||||
|
DiscordMessageID: "msg-root",
|
||||||
|
DiscordThreadID: "thread-root",
|
||||||
|
CreatedAt: "2026-08-26T08:00:00Z",
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if err := imageQueries.UpsertDiscordPostLink(ctx, sqlc.UpsertDiscordPostLinkParams{
|
||||||
|
PostID: "reply-1",
|
||||||
|
DiscordMessageID: "msg-reply",
|
||||||
|
DiscordThreadID: "",
|
||||||
|
CreatedAt: "2026-08-26T09:00:00Z",
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
rootLink, err := imageQueries.GetDiscordPostLinkByPostID(ctx, "root-1")
|
||||||
|
if err != nil || rootLink.DiscordMessageID != "msg-root" || rootLink.DiscordThreadID != "thread-root" {
|
||||||
|
t.Fatalf("root discord link = %+v, %v", rootLink, err)
|
||||||
|
}
|
||||||
|
threadLink, err := imageQueries.GetDiscordPostLinkByThreadID(ctx, "thread-root")
|
||||||
|
if err != nil || threadLink.PostID != "root-1" {
|
||||||
|
t.Fatalf("thread discord link = %+v, %v", threadLink, err)
|
||||||
|
}
|
||||||
|
if err := imageQueries.UpsertDiscordPostLink(ctx, sqlc.UpsertDiscordPostLinkParams{
|
||||||
|
PostID: "reply-1",
|
||||||
|
DiscordMessageID: "msg-reply-2",
|
||||||
|
DiscordThreadID: "",
|
||||||
|
CreatedAt: "2026-08-26T09:01:00Z",
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
replyLink, err := imageQueries.GetDiscordPostLinkByPostID(ctx, "reply-1")
|
||||||
|
if err != nil || replyLink.DiscordMessageID != "msg-reply-2" || replyLink.DiscordThreadID != "" {
|
||||||
|
t.Fatalf("reply upsert = %+v, %v", replyLink, err)
|
||||||
|
}
|
||||||
var postVoteIndexCount int
|
var postVoteIndexCount int
|
||||||
if err := conn.QueryRowContext(ctx, `
|
if err := conn.QueryRowContext(ctx, `
|
||||||
SELECT count(*)
|
SELECT count(*)
|
||||||
|
|||||||
+185
-7
@@ -5,6 +5,7 @@ import (
|
|||||||
"database/sql"
|
"database/sql"
|
||||||
"errors"
|
"errors"
|
||||||
"fmt"
|
"fmt"
|
||||||
|
"math"
|
||||||
"sort"
|
"sort"
|
||||||
"strings"
|
"strings"
|
||||||
"time"
|
"time"
|
||||||
@@ -27,8 +28,27 @@ const (
|
|||||||
PostStateVisible PostState = "visible"
|
PostStateVisible PostState = "visible"
|
||||||
PostStateHidden PostState = "hidden"
|
PostStateHidden PostState = "hidden"
|
||||||
PostStateLocked PostState = "locked"
|
PostStateLocked PostState = "locked"
|
||||||
|
MaxPostImages = 4
|
||||||
|
MaxPostVideos = 1
|
||||||
|
MaxImageDescriptionRunes = 500
|
||||||
|
MediaKindImage = "image"
|
||||||
|
MediaKindVideo = "video"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
// PostImage is one ordered public image or video attached to a post.
|
||||||
|
type PostImage struct {
|
||||||
|
ID string
|
||||||
|
PostID string
|
||||||
|
ObjectKey string
|
||||||
|
PublicURL string
|
||||||
|
Description string
|
||||||
|
Kind string
|
||||||
|
Position int
|
||||||
|
Width int
|
||||||
|
Height int
|
||||||
|
CreatedAt string
|
||||||
|
}
|
||||||
|
|
||||||
// Post is either a root question (ParentID nil) or a reply to another post.
|
// Post is either a root question (ParentID nil) or a reply to another post.
|
||||||
type Post struct {
|
type Post struct {
|
||||||
ID string
|
ID string
|
||||||
@@ -46,6 +66,7 @@ type Post struct {
|
|||||||
Score int
|
Score int
|
||||||
Answered bool
|
Answered bool
|
||||||
UserVote int
|
UserVote int
|
||||||
|
Images []PostImage
|
||||||
Replies []*Post
|
Replies []*Post
|
||||||
db *sql.DB
|
db *sql.DB
|
||||||
}
|
}
|
||||||
@@ -63,7 +84,16 @@ func (p *Post) Create(ctx context.Context) error {
|
|||||||
if err := preparePost(p); err != nil {
|
if err := preparePost(p); err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
err := sqlc.New(p.db).CreatePost(ctx, sqlc.CreatePostParams{
|
if err := preparePostImages(p); err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
tx, err := p.db.BeginTx(ctx, nil)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
defer tx.Rollback()
|
||||||
|
q := sqlc.New(tx)
|
||||||
|
if err := q.CreatePost(ctx, sqlc.CreatePostParams{
|
||||||
ID: p.ID,
|
ID: p.ID,
|
||||||
ParentID: nullableParentID(p.ParentID),
|
ParentID: nullableParentID(p.ParentID),
|
||||||
AuthorID: p.AuthorID,
|
AuthorID: p.AuthorID,
|
||||||
@@ -74,11 +104,16 @@ func (p *Post) Create(ctx context.Context) error {
|
|||||||
PostState: string(p.PostState),
|
PostState: string(p.PostState),
|
||||||
CreatedAt: p.CreatedAt,
|
CreatedAt: p.CreatedAt,
|
||||||
UpdatedAt: p.UpdatedAt,
|
UpdatedAt: p.UpdatedAt,
|
||||||
})
|
}); err != nil {
|
||||||
return mapPostCreateError(err)
|
return mapPostCreateError(err)
|
||||||
}
|
}
|
||||||
|
if err := createPostImages(ctx, q, p.Images); err != nil {
|
||||||
|
return mapPostCreateError(err)
|
||||||
|
}
|
||||||
|
return tx.Commit()
|
||||||
|
}
|
||||||
|
|
||||||
// Update changes only the post body and update timestamp.
|
// Update changes the post body, update timestamp, and complete image set.
|
||||||
func (p *Post) Update(ctx context.Context) error {
|
func (p *Post) Update(ctx context.Context) error {
|
||||||
if p == nil || p.db == nil {
|
if p == nil || p.db == nil {
|
||||||
return fmt.Errorf("post: no database")
|
return fmt.Errorf("post: no database")
|
||||||
@@ -88,7 +123,16 @@ func (p *Post) Update(ctx context.Context) error {
|
|||||||
return fmt.Errorf("%w: body is required", ErrInvalidPost)
|
return fmt.Errorf("%w: body is required", ErrInvalidPost)
|
||||||
}
|
}
|
||||||
p.UpdatedAt = time.Now().UTC().Format(time.RFC3339Nano)
|
p.UpdatedAt = time.Now().UTC().Format(time.RFC3339Nano)
|
||||||
n, err := sqlc.New(p.db).UpdatePost(ctx, sqlc.UpdatePostParams{
|
if err := preparePostImages(p); err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
tx, err := p.db.BeginTx(ctx, nil)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
defer tx.Rollback()
|
||||||
|
q := sqlc.New(tx)
|
||||||
|
n, err := q.UpdatePost(ctx, sqlc.UpdatePostParams{
|
||||||
ID: p.ID,
|
ID: p.ID,
|
||||||
Body: p.Body,
|
Body: p.Body,
|
||||||
UpdatedAt: p.UpdatedAt,
|
UpdatedAt: p.UpdatedAt,
|
||||||
@@ -99,7 +143,13 @@ func (p *Post) Update(ctx context.Context) error {
|
|||||||
if n == 0 {
|
if n == 0 {
|
||||||
return sql.ErrNoRows
|
return sql.ErrNoRows
|
||||||
}
|
}
|
||||||
return nil
|
if err := q.DeletePostImages(ctx, p.ID); err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
if err := createPostImages(ctx, q, p.Images); err != nil {
|
||||||
|
return mapPostCreateError(err)
|
||||||
|
}
|
||||||
|
return tx.Commit()
|
||||||
}
|
}
|
||||||
|
|
||||||
func preparePost(p *Post) error {
|
func preparePost(p *Post) error {
|
||||||
@@ -153,6 +203,110 @@ func preparePost(p *Post) error {
|
|||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func preparePostImages(p *Post) error {
|
||||||
|
if len(p.Images) > MaxPostImages+MaxPostVideos {
|
||||||
|
return fmt.Errorf("%w: at most %d images and %d video are allowed", ErrInvalidPost, MaxPostImages, MaxPostVideos)
|
||||||
|
}
|
||||||
|
ids := make(map[string]bool, len(p.Images))
|
||||||
|
keys := make(map[string]bool, len(p.Images))
|
||||||
|
now := time.Now().UTC().Format(time.RFC3339Nano)
|
||||||
|
images, videos := 0, 0
|
||||||
|
for i := range p.Images {
|
||||||
|
image := &p.Images[i]
|
||||||
|
image.ID = strings.TrimSpace(image.ID)
|
||||||
|
image.PostID = strings.TrimSpace(image.PostID)
|
||||||
|
image.ObjectKey = strings.TrimSpace(image.ObjectKey)
|
||||||
|
image.PublicURL = strings.TrimSpace(image.PublicURL)
|
||||||
|
image.Description = strings.TrimSpace(image.Description)
|
||||||
|
image.Kind = strings.TrimSpace(image.Kind)
|
||||||
|
if image.Kind == "" {
|
||||||
|
image.Kind = MediaKindImage
|
||||||
|
}
|
||||||
|
if image.Kind != MediaKindImage && image.Kind != MediaKindVideo {
|
||||||
|
return fmt.Errorf("%w: invalid media kind", ErrInvalidPost)
|
||||||
|
}
|
||||||
|
if image.ID == "" {
|
||||||
|
image.ID = uuid.NewString()
|
||||||
|
}
|
||||||
|
if image.PostID == "" {
|
||||||
|
image.PostID = p.ID
|
||||||
|
}
|
||||||
|
if image.PostID != p.ID {
|
||||||
|
return fmt.Errorf("%w: image belongs to another post", ErrInvalidPost)
|
||||||
|
}
|
||||||
|
if image.ObjectKey == "" || image.PublicURL == "" {
|
||||||
|
return fmt.Errorf("%w: image storage metadata is required", ErrInvalidPost)
|
||||||
|
}
|
||||||
|
if len([]rune(image.Description)) > MaxImageDescriptionRunes {
|
||||||
|
return fmt.Errorf("%w: image description is too long", ErrInvalidPost)
|
||||||
|
}
|
||||||
|
if image.Kind == MediaKindImage {
|
||||||
|
images++
|
||||||
|
if image.Width <= 0 || image.Height <= 0 ||
|
||||||
|
image.Width > math.MaxInt32 || image.Height > math.MaxInt32 {
|
||||||
|
return fmt.Errorf("%w: invalid image dimensions", ErrInvalidPost)
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
videos++
|
||||||
|
if image.Width < 0 || image.Height < 0 ||
|
||||||
|
image.Width > math.MaxInt32 || image.Height > math.MaxInt32 {
|
||||||
|
return fmt.Errorf("%w: invalid video dimensions", ErrInvalidPost)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if ids[image.ID] || keys[image.ObjectKey] {
|
||||||
|
return fmt.Errorf("%w: duplicate image", ErrInvalidPost)
|
||||||
|
}
|
||||||
|
ids[image.ID] = true
|
||||||
|
keys[image.ObjectKey] = true
|
||||||
|
image.Position = i
|
||||||
|
if image.CreatedAt == "" {
|
||||||
|
image.CreatedAt = now
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if images > MaxPostImages {
|
||||||
|
return fmt.Errorf("%w: at most %d images are allowed", ErrInvalidPost, MaxPostImages)
|
||||||
|
}
|
||||||
|
if videos > MaxPostVideos {
|
||||||
|
return fmt.Errorf("%w: at most %d video is allowed", ErrInvalidPost, MaxPostVideos)
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func createPostImages(ctx context.Context, q *sqlc.Queries, images []PostImage) error {
|
||||||
|
for _, image := range images {
|
||||||
|
if err := q.CreatePostImage(ctx, sqlc.CreatePostImageParams{
|
||||||
|
ID: image.ID,
|
||||||
|
PostID: image.PostID,
|
||||||
|
ObjectKey: image.ObjectKey,
|
||||||
|
PublicUrl: image.PublicURL,
|
||||||
|
Description: image.Description,
|
||||||
|
Kind: image.Kind,
|
||||||
|
Position: int16(image.Position),
|
||||||
|
Width: int32(image.Width),
|
||||||
|
Height: int32(image.Height),
|
||||||
|
CreatedAt: image.CreatedAt,
|
||||||
|
}); err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func postImageFromSQL(image sqlc.PostImage) PostImage {
|
||||||
|
return PostImage{
|
||||||
|
ID: image.ID,
|
||||||
|
PostID: image.PostID,
|
||||||
|
ObjectKey: image.ObjectKey,
|
||||||
|
PublicURL: image.PublicUrl,
|
||||||
|
Description: image.Description,
|
||||||
|
Kind: image.Kind,
|
||||||
|
Position: int(image.Position),
|
||||||
|
Width: int(image.Width),
|
||||||
|
Height: int(image.Height),
|
||||||
|
CreatedAt: image.CreatedAt,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func nullableParentID(parentID *string) sql.NullString {
|
func nullableParentID(parentID *string) sql.NullString {
|
||||||
if parentID == nil {
|
if parentID == nil {
|
||||||
return sql.NullString{}
|
return sql.NullString{}
|
||||||
@@ -209,7 +363,8 @@ func postFromValues(
|
|||||||
|
|
||||||
// GetPost returns one post without loading its replies.
|
// GetPost returns one post without loading its replies.
|
||||||
func GetPost(ctx context.Context, db *sql.DB, id string) (*Post, error) {
|
func GetPost(ctx context.Context, db *sql.DB, id string) (*Post, error) {
|
||||||
r, err := sqlc.New(db).GetPost(ctx, id)
|
q := sqlc.New(db)
|
||||||
|
r, err := q.GetPost(ctx, id)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
@@ -228,12 +383,20 @@ func GetPost(ctx context.Context, db *sql.DB, id string) (*Post, error) {
|
|||||||
r.CreatedAt,
|
r.CreatedAt,
|
||||||
r.UpdatedAt,
|
r.UpdatedAt,
|
||||||
)
|
)
|
||||||
|
imageRows, err := q.ListPostImages(ctx, id)
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
for _, image := range imageRows {
|
||||||
|
p.Images = append(p.Images, postImageFromSQL(image))
|
||||||
|
}
|
||||||
return &p, nil
|
return &p, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// GetPostThread returns a root post with all descendants nested under Replies.
|
// GetPostThread returns a root post with all descendants nested under Replies.
|
||||||
func GetPostThread(ctx context.Context, db *sql.DB, rootID string) (*Post, error) {
|
func GetPostThread(ctx context.Context, db *sql.DB, rootID string) (*Post, error) {
|
||||||
rows, err := sqlc.New(db).ListPostThread(ctx, rootID)
|
q := sqlc.New(db)
|
||||||
|
rows, err := q.ListPostThread(ctx, rootID)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
@@ -255,6 +418,21 @@ func GetPostThread(ctx context.Context, db *sql.DB, rootID string) (*Post, error
|
|||||||
r.UpdatedAt,
|
r.UpdatedAt,
|
||||||
))
|
))
|
||||||
}
|
}
|
||||||
|
imageRows, err := q.ListPostThreadImages(ctx, rootID)
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
postsByID := make(map[string]*Post, len(posts))
|
||||||
|
for i := range posts {
|
||||||
|
postsByID[posts[i].ID] = &posts[i]
|
||||||
|
}
|
||||||
|
for _, image := range imageRows {
|
||||||
|
post, ok := postsByID[image.PostID]
|
||||||
|
if !ok {
|
||||||
|
return nil, fmt.Errorf("image %s belongs to missing post %s", image.ID, image.PostID)
|
||||||
|
}
|
||||||
|
post.Images = append(post.Images, postImageFromSQL(image))
|
||||||
|
}
|
||||||
return buildPostTree(posts, rootID)
|
return buildPostTree(posts, rootID)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -267,6 +267,123 @@ func TestMemoryPostValidation(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestMemoryPostImages(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
ctx := context.Background()
|
||||||
|
mem := NewMemory()
|
||||||
|
homeowner := &User{Username: "images", PasswordHash: "hash", Role: RoleUser}
|
||||||
|
if err := mem.CreateUser(ctx, homeowner); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
root := &Post{
|
||||||
|
ID: "image-root",
|
||||||
|
AuthorID: homeowner.ID,
|
||||||
|
Title: "What is leaking?",
|
||||||
|
Body: "Here are two photos.",
|
||||||
|
Images: []PostImage{
|
||||||
|
{ID: "image-a", ObjectKey: "posts/image-root/image-a.jpg", PublicURL: "https://cdn.example/image-a.jpg", Description: " Supply valve ", Position: 3, Width: 1200, Height: 900},
|
||||||
|
{ID: "image-b", ObjectKey: "posts/image-root/image-b.png", PublicURL: "https://cdn.example/image-b.png", Width: 900, Height: 1200},
|
||||||
|
},
|
||||||
|
}
|
||||||
|
if err := mem.CreatePost(ctx, root); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if root.Images[0].Position != 0 ||
|
||||||
|
root.Images[1].Position != 1 ||
|
||||||
|
root.Images[0].PostID != root.ID ||
|
||||||
|
root.Images[0].Description != "Supply valve" {
|
||||||
|
t.Fatalf("created images were not normalized: %+v", root.Images)
|
||||||
|
}
|
||||||
|
|
||||||
|
loaded, err := mem.GetPost(ctx, root.ID)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
loaded.Images[0].Description = "mutated outside store"
|
||||||
|
reloaded, err := mem.GetPost(ctx, root.ID)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if reloaded.Images[0].Description != "Supply valve" {
|
||||||
|
t.Fatalf("stored image mutated through clone: %+v", reloaded.Images[0])
|
||||||
|
}
|
||||||
|
|
||||||
|
reloaded.Body = "Updated photos."
|
||||||
|
reloaded.Images = []PostImage{
|
||||||
|
reloaded.Images[1],
|
||||||
|
{ID: "image-c", ObjectKey: "posts/image-root/image-c.jpg", PublicURL: "https://cdn.example/image-c.jpg", Description: "Trap connection", Width: 1600, Height: 1000},
|
||||||
|
}
|
||||||
|
if err := mem.UpdatePost(ctx, reloaded); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
updated, err := mem.GetPost(ctx, root.ID)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if len(updated.Images) != 2 ||
|
||||||
|
updated.Images[0].ID != "image-b" ||
|
||||||
|
updated.Images[0].Position != 0 ||
|
||||||
|
updated.Images[1].ID != "image-c" ||
|
||||||
|
updated.Images[1].Position != 1 {
|
||||||
|
t.Fatalf("updated images = %+v", updated.Images)
|
||||||
|
}
|
||||||
|
|
||||||
|
tooMany := &Post{
|
||||||
|
AuthorID: homeowner.ID,
|
||||||
|
Title: "Too many",
|
||||||
|
Body: "Five photos.",
|
||||||
|
Images: validPostImages(5),
|
||||||
|
}
|
||||||
|
if err := mem.CreatePost(ctx, tooMany); !errors.Is(err, ErrInvalidPost) {
|
||||||
|
t.Fatalf("five-image create error = %v, want ErrInvalidPost", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
withVideo := &Post{
|
||||||
|
AuthorID: homeowner.ID,
|
||||||
|
Title: "With video",
|
||||||
|
Body: "Four photos and a clip.",
|
||||||
|
Images: append(validPostImages(4), PostImage{
|
||||||
|
ID: "clip-1",
|
||||||
|
ObjectKey: "posts/clip-1.mp4",
|
||||||
|
PublicURL: "https://cdn.example/clip-1.mp4",
|
||||||
|
Kind: MediaKindVideo,
|
||||||
|
}),
|
||||||
|
}
|
||||||
|
if err := mem.CreatePost(ctx, withVideo); err != nil {
|
||||||
|
t.Fatalf("four images and one video: %v", err)
|
||||||
|
}
|
||||||
|
if withVideo.Images[4].Kind != MediaKindVideo || withVideo.Images[4].Position != 4 {
|
||||||
|
t.Fatalf("video not stored: %+v", withVideo.Images[4])
|
||||||
|
}
|
||||||
|
twoVideos := &Post{
|
||||||
|
AuthorID: homeowner.ID,
|
||||||
|
Title: "Two clips",
|
||||||
|
Body: "Not allowed.",
|
||||||
|
Images: []PostImage{
|
||||||
|
{ObjectKey: "posts/a.mp4", PublicURL: "https://cdn.example/a.mp4", Kind: MediaKindVideo},
|
||||||
|
{ObjectKey: "posts/b.mp4", PublicURL: "https://cdn.example/b.mp4", Kind: MediaKindVideo},
|
||||||
|
},
|
||||||
|
}
|
||||||
|
if err := mem.CreatePost(ctx, twoVideos); !errors.Is(err, ErrInvalidPost) {
|
||||||
|
t.Fatalf("two-video create error = %v, want ErrInvalidPost", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func validPostImages(count int) []PostImage {
|
||||||
|
images := make([]PostImage, count)
|
||||||
|
for i := range images {
|
||||||
|
images[i] = PostImage{
|
||||||
|
ID: "image-" + string(rune('a'+i)),
|
||||||
|
ObjectKey: "posts/key-" + string(rune('a'+i)) + ".jpg",
|
||||||
|
PublicURL: "https://cdn.example/" + string(rune('a'+i)) + ".jpg",
|
||||||
|
Width: 100,
|
||||||
|
Height: 100,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return images
|
||||||
|
}
|
||||||
|
|
||||||
func ptr(value string) *string {
|
func ptr(value string) *string {
|
||||||
return &value
|
return &value
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,100 @@
|
|||||||
|
// Code generated by sqlc. DO NOT EDIT.
|
||||||
|
// versions:
|
||||||
|
// sqlc v1.31.1
|
||||||
|
// source: discord_links.sql
|
||||||
|
|
||||||
|
package sqlc
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
)
|
||||||
|
|
||||||
|
const getDiscordPostLinkByMessageID = `-- name: GetDiscordPostLinkByMessageID :one
|
||||||
|
SELECT post_id, discord_message_id, discord_thread_id, created_at
|
||||||
|
FROM discord_post_links
|
||||||
|
WHERE discord_message_id = $1
|
||||||
|
`
|
||||||
|
|
||||||
|
func (q *Queries) GetDiscordPostLinkByMessageID(ctx context.Context, discordMessageID string) (DiscordPostLink, error) {
|
||||||
|
row := q.db.QueryRowContext(ctx, getDiscordPostLinkByMessageID, discordMessageID)
|
||||||
|
var i DiscordPostLink
|
||||||
|
err := row.Scan(
|
||||||
|
&i.PostID,
|
||||||
|
&i.DiscordMessageID,
|
||||||
|
&i.DiscordThreadID,
|
||||||
|
&i.CreatedAt,
|
||||||
|
)
|
||||||
|
return i, err
|
||||||
|
}
|
||||||
|
|
||||||
|
const getDiscordPostLinkByPostID = `-- name: GetDiscordPostLinkByPostID :one
|
||||||
|
SELECT post_id, discord_message_id, discord_thread_id, created_at
|
||||||
|
FROM discord_post_links
|
||||||
|
WHERE post_id = $1
|
||||||
|
`
|
||||||
|
|
||||||
|
func (q *Queries) GetDiscordPostLinkByPostID(ctx context.Context, postID string) (DiscordPostLink, error) {
|
||||||
|
row := q.db.QueryRowContext(ctx, getDiscordPostLinkByPostID, postID)
|
||||||
|
var i DiscordPostLink
|
||||||
|
err := row.Scan(
|
||||||
|
&i.PostID,
|
||||||
|
&i.DiscordMessageID,
|
||||||
|
&i.DiscordThreadID,
|
||||||
|
&i.CreatedAt,
|
||||||
|
)
|
||||||
|
return i, err
|
||||||
|
}
|
||||||
|
|
||||||
|
const getDiscordPostLinkByThreadID = `-- name: GetDiscordPostLinkByThreadID :one
|
||||||
|
SELECT post_id, discord_message_id, discord_thread_id, created_at
|
||||||
|
FROM discord_post_links
|
||||||
|
WHERE discord_thread_id = $1
|
||||||
|
AND discord_thread_id <> ''
|
||||||
|
`
|
||||||
|
|
||||||
|
func (q *Queries) GetDiscordPostLinkByThreadID(ctx context.Context, discordThreadID string) (DiscordPostLink, error) {
|
||||||
|
row := q.db.QueryRowContext(ctx, getDiscordPostLinkByThreadID, discordThreadID)
|
||||||
|
var i DiscordPostLink
|
||||||
|
err := row.Scan(
|
||||||
|
&i.PostID,
|
||||||
|
&i.DiscordMessageID,
|
||||||
|
&i.DiscordThreadID,
|
||||||
|
&i.CreatedAt,
|
||||||
|
)
|
||||||
|
return i, err
|
||||||
|
}
|
||||||
|
|
||||||
|
const upsertDiscordPostLink = `-- name: UpsertDiscordPostLink :exec
|
||||||
|
INSERT INTO discord_post_links (
|
||||||
|
post_id, discord_message_id, discord_thread_id, created_at
|
||||||
|
)
|
||||||
|
VALUES (
|
||||||
|
$1,
|
||||||
|
$2,
|
||||||
|
$3,
|
||||||
|
$4
|
||||||
|
)
|
||||||
|
ON CONFLICT (post_id) DO UPDATE SET
|
||||||
|
discord_message_id = EXCLUDED.discord_message_id,
|
||||||
|
discord_thread_id = CASE
|
||||||
|
WHEN EXCLUDED.discord_thread_id <> '' THEN EXCLUDED.discord_thread_id
|
||||||
|
ELSE discord_post_links.discord_thread_id
|
||||||
|
END
|
||||||
|
`
|
||||||
|
|
||||||
|
type UpsertDiscordPostLinkParams struct {
|
||||||
|
PostID string
|
||||||
|
DiscordMessageID string
|
||||||
|
DiscordThreadID string
|
||||||
|
CreatedAt string
|
||||||
|
}
|
||||||
|
|
||||||
|
func (q *Queries) UpsertDiscordPostLink(ctx context.Context, arg UpsertDiscordPostLinkParams) error {
|
||||||
|
_, err := q.db.ExecContext(ctx, upsertDiscordPostLink,
|
||||||
|
arg.PostID,
|
||||||
|
arg.DiscordMessageID,
|
||||||
|
arg.DiscordThreadID,
|
||||||
|
arg.CreatedAt,
|
||||||
|
)
|
||||||
|
return err
|
||||||
|
}
|
||||||
@@ -9,6 +9,13 @@ import (
|
|||||||
"time"
|
"time"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
type DiscordPostLink struct {
|
||||||
|
PostID string
|
||||||
|
DiscordMessageID string
|
||||||
|
DiscordThreadID string
|
||||||
|
CreatedAt string
|
||||||
|
}
|
||||||
|
|
||||||
type Post struct {
|
type Post struct {
|
||||||
ID string
|
ID string
|
||||||
ParentID sql.NullString
|
ParentID sql.NullString
|
||||||
@@ -22,6 +29,19 @@ type Post struct {
|
|||||||
UpdatedAt string
|
UpdatedAt string
|
||||||
}
|
}
|
||||||
|
|
||||||
|
type PostImage struct {
|
||||||
|
ID string
|
||||||
|
PostID string
|
||||||
|
ObjectKey string
|
||||||
|
PublicUrl string
|
||||||
|
Description string
|
||||||
|
Kind string
|
||||||
|
Position int16
|
||||||
|
Width int32
|
||||||
|
Height int32
|
||||||
|
CreatedAt string
|
||||||
|
}
|
||||||
|
|
||||||
type PostVote struct {
|
type PostVote struct {
|
||||||
UserID string
|
UserID string
|
||||||
PostID string
|
PostID string
|
||||||
|
|||||||
@@ -57,6 +57,63 @@ func (q *Queries) CreatePost(ctx context.Context, arg CreatePostParams) error {
|
|||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const createPostImage = `-- name: CreatePostImage :exec
|
||||||
|
INSERT INTO post_images (
|
||||||
|
id, post_id, object_key, public_url, description, kind, position, width, height, created_at
|
||||||
|
)
|
||||||
|
VALUES (
|
||||||
|
$1,
|
||||||
|
$2,
|
||||||
|
$3,
|
||||||
|
$4,
|
||||||
|
$5,
|
||||||
|
$6,
|
||||||
|
$7,
|
||||||
|
$8,
|
||||||
|
$9,
|
||||||
|
$10
|
||||||
|
)
|
||||||
|
`
|
||||||
|
|
||||||
|
type CreatePostImageParams struct {
|
||||||
|
ID string
|
||||||
|
PostID string
|
||||||
|
ObjectKey string
|
||||||
|
PublicUrl string
|
||||||
|
Description string
|
||||||
|
Kind string
|
||||||
|
Position int16
|
||||||
|
Width int32
|
||||||
|
Height int32
|
||||||
|
CreatedAt string
|
||||||
|
}
|
||||||
|
|
||||||
|
func (q *Queries) CreatePostImage(ctx context.Context, arg CreatePostImageParams) error {
|
||||||
|
_, err := q.db.ExecContext(ctx, createPostImage,
|
||||||
|
arg.ID,
|
||||||
|
arg.PostID,
|
||||||
|
arg.ObjectKey,
|
||||||
|
arg.PublicUrl,
|
||||||
|
arg.Description,
|
||||||
|
arg.Kind,
|
||||||
|
arg.Position,
|
||||||
|
arg.Width,
|
||||||
|
arg.Height,
|
||||||
|
arg.CreatedAt,
|
||||||
|
)
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
|
||||||
|
const deletePostImages = `-- name: DeletePostImages :exec
|
||||||
|
DELETE FROM post_images
|
||||||
|
WHERE post_id = $1
|
||||||
|
`
|
||||||
|
|
||||||
|
func (q *Queries) DeletePostImages(ctx context.Context, postID string) error {
|
||||||
|
_, err := q.db.ExecContext(ctx, deletePostImages, postID)
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
|
||||||
const deletePostVote = `-- name: DeletePostVote :exec
|
const deletePostVote = `-- name: DeletePostVote :exec
|
||||||
DELETE FROM post_votes
|
DELETE FROM post_votes
|
||||||
WHERE user_id = $1
|
WHERE user_id = $1
|
||||||
@@ -145,6 +202,48 @@ func (q *Queries) GetRootPostVoteSummary(ctx context.Context, arg GetRootPostVot
|
|||||||
return i, err
|
return i, err
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const listPostImages = `-- name: ListPostImages :many
|
||||||
|
SELECT
|
||||||
|
id, post_id, object_key, public_url, description, kind, position, width, height, created_at
|
||||||
|
FROM post_images
|
||||||
|
WHERE post_id = $1
|
||||||
|
ORDER BY position
|
||||||
|
`
|
||||||
|
|
||||||
|
func (q *Queries) ListPostImages(ctx context.Context, postID string) ([]PostImage, error) {
|
||||||
|
rows, err := q.db.QueryContext(ctx, listPostImages, postID)
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
defer rows.Close()
|
||||||
|
items := []PostImage{}
|
||||||
|
for rows.Next() {
|
||||||
|
var i PostImage
|
||||||
|
if err := rows.Scan(
|
||||||
|
&i.ID,
|
||||||
|
&i.PostID,
|
||||||
|
&i.ObjectKey,
|
||||||
|
&i.PublicUrl,
|
||||||
|
&i.Description,
|
||||||
|
&i.Kind,
|
||||||
|
&i.Position,
|
||||||
|
&i.Width,
|
||||||
|
&i.Height,
|
||||||
|
&i.CreatedAt,
|
||||||
|
); err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
items = append(items, i)
|
||||||
|
}
|
||||||
|
if err := rows.Close(); err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
if err := rows.Err(); err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
return items, nil
|
||||||
|
}
|
||||||
|
|
||||||
const listPostThread = `-- name: ListPostThread :many
|
const listPostThread = `-- name: ListPostThread :many
|
||||||
WITH RECURSIVE thread AS (
|
WITH RECURSIVE thread AS (
|
||||||
SELECT p.id, p.parent_id, p.author_id, p.title, p.body, p.city, p.post_date, p.post_state, p.created_at, p.updated_at
|
SELECT p.id, p.parent_id, p.author_id, p.title, p.body, p.city, p.post_date, p.post_state, p.created_at, p.updated_at
|
||||||
@@ -218,6 +317,60 @@ func (q *Queries) ListPostThread(ctx context.Context, rootID string) ([]ListPost
|
|||||||
return items, nil
|
return items, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const listPostThreadImages = `-- name: ListPostThreadImages :many
|
||||||
|
WITH RECURSIVE thread AS (
|
||||||
|
SELECT p.id
|
||||||
|
FROM posts p
|
||||||
|
WHERE p.id = $1 AND p.parent_id IS NULL
|
||||||
|
|
||||||
|
UNION ALL
|
||||||
|
|
||||||
|
SELECT child.id
|
||||||
|
FROM posts child
|
||||||
|
JOIN thread parent ON child.parent_id = parent.id
|
||||||
|
)
|
||||||
|
SELECT
|
||||||
|
images.id, images.post_id, images.object_key, images.public_url,
|
||||||
|
images.description, images.kind, images.position, images.width, images.height, images.created_at
|
||||||
|
FROM post_images images
|
||||||
|
JOIN thread ON thread.id = images.post_id
|
||||||
|
ORDER BY images.post_id, images.position
|
||||||
|
`
|
||||||
|
|
||||||
|
func (q *Queries) ListPostThreadImages(ctx context.Context, rootID string) ([]PostImage, error) {
|
||||||
|
rows, err := q.db.QueryContext(ctx, listPostThreadImages, rootID)
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
defer rows.Close()
|
||||||
|
items := []PostImage{}
|
||||||
|
for rows.Next() {
|
||||||
|
var i PostImage
|
||||||
|
if err := rows.Scan(
|
||||||
|
&i.ID,
|
||||||
|
&i.PostID,
|
||||||
|
&i.ObjectKey,
|
||||||
|
&i.PublicUrl,
|
||||||
|
&i.Description,
|
||||||
|
&i.Kind,
|
||||||
|
&i.Position,
|
||||||
|
&i.Width,
|
||||||
|
&i.Height,
|
||||||
|
&i.CreatedAt,
|
||||||
|
); err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
items = append(items, i)
|
||||||
|
}
|
||||||
|
if err := rows.Close(); err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
if err := rows.Err(); err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
return items, nil
|
||||||
|
}
|
||||||
|
|
||||||
const listRootPosts = `-- name: ListRootPosts :many
|
const listRootPosts = `-- name: ListRootPosts :many
|
||||||
WITH RECURSIVE roots AS (
|
WITH RECURSIVE roots AS (
|
||||||
SELECT p.id, p.parent_id, p.author_id, p.title, p.body, p.city, p.post_date, p.post_state, p.created_at, p.updated_at
|
SELECT p.id, p.parent_id, p.author_id, p.title, p.body, p.city, p.post_date, p.post_state, p.created_at, p.updated_at
|
||||||
|
|||||||
@@ -0,0 +1,84 @@
|
|||||||
|
package web
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
|
||||||
|
"plumber/internal/events"
|
||||||
|
"plumber/internal/store"
|
||||||
|
)
|
||||||
|
|
||||||
|
func (s *Server) publishPostCreated(post, root *store.Post, author *store.User, media []events.Media, cleanup func()) {
|
||||||
|
release := events.Once(func() {
|
||||||
|
closeHeldMedia(media)
|
||||||
|
if cleanup != nil {
|
||||||
|
cleanup()
|
||||||
|
}
|
||||||
|
})
|
||||||
|
if root != nil && root.PostState == store.PostStateHidden {
|
||||||
|
release()
|
||||||
|
return
|
||||||
|
}
|
||||||
|
ev := events.PostCreated{PostEvent: s.postEvent(post, root, author)}
|
||||||
|
if s.cfg.HoldUploadUntilDiscord && len(media) > 0 {
|
||||||
|
ev.Media = media
|
||||||
|
ev.Release = release
|
||||||
|
s.cfg.Events.Publish(context.Background(), ev)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
release()
|
||||||
|
s.cfg.Events.Publish(context.Background(), events.PostCreated{PostEvent: ev.PostEvent})
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *Server) publishPostUpdated(post, root *store.Post, author *store.User) {
|
||||||
|
s.publishPost(events.PostUpdated{PostEvent: s.postEvent(post, root, author)}, root)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *Server) publishPost(ev any, root *store.Post) {
|
||||||
|
if root != nil && root.PostState == store.PostStateHidden {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
s.cfg.Events.Publish(context.Background(), ev)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *Server) postEvent(post, root *store.Post, author *store.User) events.PostEvent {
|
||||||
|
if post == nil {
|
||||||
|
return events.PostEvent{}
|
||||||
|
}
|
||||||
|
rootID := post.ID
|
||||||
|
if root != nil {
|
||||||
|
rootID = root.ID
|
||||||
|
}
|
||||||
|
ev := events.PostEvent{
|
||||||
|
PostID: post.ID,
|
||||||
|
RootID: rootID,
|
||||||
|
Title: post.Title,
|
||||||
|
Body: post.Body,
|
||||||
|
City: post.City,
|
||||||
|
AuthorID: post.AuthorID,
|
||||||
|
AuthorName: post.AuthorName,
|
||||||
|
AuthorRole: string(post.AuthorRole),
|
||||||
|
Permalink: events.Permalink(s.cfg.BaseURL, rootID, post.ID),
|
||||||
|
}
|
||||||
|
if post.ParentID != nil {
|
||||||
|
ev.ParentID = *post.ParentID
|
||||||
|
}
|
||||||
|
if author != nil {
|
||||||
|
if ev.AuthorName == "" {
|
||||||
|
ev.AuthorName = author.Name
|
||||||
|
}
|
||||||
|
if ev.AuthorRole == "" {
|
||||||
|
ev.AuthorRole = string(author.Role)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if n := len(post.Images); n > 0 {
|
||||||
|
ev.Images = make([]events.Image, 0, n)
|
||||||
|
for _, img := range post.Images {
|
||||||
|
ev.Images = append(ev.Images, events.Image{
|
||||||
|
URL: img.PublicURL,
|
||||||
|
Description: img.Description,
|
||||||
|
Kind: img.Kind,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return ev
|
||||||
|
}
|
||||||
@@ -0,0 +1,310 @@
|
|||||||
|
package web
|
||||||
|
|
||||||
|
import (
|
||||||
|
"bytes"
|
||||||
|
"context"
|
||||||
|
"encoding/json"
|
||||||
|
"io"
|
||||||
|
"net/http"
|
||||||
|
"net/url"
|
||||||
|
"strings"
|
||||||
|
"testing"
|
||||||
|
|
||||||
|
"plumber/internal/events"
|
||||||
|
"plumber/internal/pacific"
|
||||||
|
"plumber/internal/store"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestPostHandlersPublishEvents(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
rec := &events.Recording{}
|
||||||
|
srv, mem := newTestServer(t, Config{
|
||||||
|
Events: rec,
|
||||||
|
BaseURL: "https://www.askaplumberfirst.com",
|
||||||
|
})
|
||||||
|
handler := srv.Handler()
|
||||||
|
homeowner := seedUser(t, mem, uniq("homeowner"), "hunter22", store.RoleUser)
|
||||||
|
admin := seedUser(t, mem, uniq("admin"), "hunter22", store.RoleAdmin)
|
||||||
|
homeownerCookies := loginUser(t, handler, homeowner.Username, "hunter22")
|
||||||
|
adminCookies := loginUser(t, handler, admin.Username, "hunter22")
|
||||||
|
homeownerCSRF := csrfForCookies(t, handler, homeownerCookies)
|
||||||
|
adminCSRF := csrfForCookies(t, handler, adminCookies)
|
||||||
|
|
||||||
|
submit := postForm(handler, "/submit", url.Values{
|
||||||
|
"_csrf": {homeownerCSRF},
|
||||||
|
"title": {"Leaky sink"},
|
||||||
|
"body": {"Water under the cabinet."},
|
||||||
|
"city": {"Oakland"},
|
||||||
|
}, homeownerCookies)
|
||||||
|
if submit.Code != http.StatusSeeOther {
|
||||||
|
t.Fatalf("submit status = %d: %s", submit.Code, submit.Body.String())
|
||||||
|
}
|
||||||
|
|
||||||
|
create := postForm(handler, "/posts", url.Values{
|
||||||
|
"_csrf": {homeownerCSRF},
|
||||||
|
"title": {"Second question"},
|
||||||
|
"body": {"Another leak."},
|
||||||
|
"city": {"Berkeley"},
|
||||||
|
}, homeownerCookies)
|
||||||
|
if create.Code != http.StatusSeeOther {
|
||||||
|
t.Fatalf("create status = %d: %s", create.Code, create.Body.String())
|
||||||
|
}
|
||||||
|
|
||||||
|
roots, err := mem.ListRootPosts(context.Background(), pacific.Today(), homeowner.ID)
|
||||||
|
if err != nil || len(roots) != 2 {
|
||||||
|
t.Fatalf("roots = %+v, %v", roots, err)
|
||||||
|
}
|
||||||
|
var submitRoot, createRoot store.Post
|
||||||
|
for _, root := range roots {
|
||||||
|
switch root.Title {
|
||||||
|
case "Leaky sink":
|
||||||
|
submitRoot = root
|
||||||
|
case "Second question":
|
||||||
|
createRoot = root
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if submitRoot.ID == "" || createRoot.ID == "" {
|
||||||
|
t.Fatalf("missing created roots: %+v", roots)
|
||||||
|
}
|
||||||
|
|
||||||
|
reply := postForm(handler, "/posts", url.Values{
|
||||||
|
"_csrf": {adminCSRF},
|
||||||
|
"parent_id": {createRoot.ID},
|
||||||
|
"body": {"Replace the cartridge."},
|
||||||
|
}, adminCookies)
|
||||||
|
if reply.Code != http.StatusSeeOther {
|
||||||
|
t.Fatalf("reply status = %d: %s", reply.Code, reply.Body.String())
|
||||||
|
}
|
||||||
|
thread, err := mem.GetPostThread(context.Background(), createRoot.ID)
|
||||||
|
if err != nil || len(thread.Replies) != 1 {
|
||||||
|
t.Fatalf("thread = %+v, %v", thread, err)
|
||||||
|
}
|
||||||
|
adminReply := thread.Replies[0]
|
||||||
|
|
||||||
|
edit := postForm(handler, "/posts/"+createRoot.ID+"/edit", url.Values{
|
||||||
|
"_csrf": {homeownerCSRF},
|
||||||
|
"body": {"Updated leak description."},
|
||||||
|
}, homeownerCookies)
|
||||||
|
if edit.Code != http.StatusSeeOther {
|
||||||
|
t.Fatalf("edit status = %d: %s", edit.Code, edit.Body.String())
|
||||||
|
}
|
||||||
|
|
||||||
|
empty := postForm(handler, "/posts", url.Values{
|
||||||
|
"_csrf": {homeownerCSRF},
|
||||||
|
"title": {"Missing body"},
|
||||||
|
}, homeownerCookies)
|
||||||
|
if empty.Code != http.StatusBadRequest {
|
||||||
|
t.Fatalf("empty body status = %d, want 400", empty.Code)
|
||||||
|
}
|
||||||
|
|
||||||
|
hidden := &store.Post{
|
||||||
|
AuthorID: homeowner.ID,
|
||||||
|
Title: "Hidden thread",
|
||||||
|
Body: "Not public.",
|
||||||
|
PostDate: pacific.Today(),
|
||||||
|
PostState: store.PostStateHidden,
|
||||||
|
}
|
||||||
|
if err := mem.CreatePost(context.Background(), hidden); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
hiddenReply := postForm(handler, "/posts", url.Values{
|
||||||
|
"_csrf": {homeownerCSRF},
|
||||||
|
"parent_id": {hidden.ID},
|
||||||
|
"body": {"Should not publish."},
|
||||||
|
}, homeownerCookies)
|
||||||
|
if hiddenReply.Code != http.StatusNotFound {
|
||||||
|
t.Fatalf("hidden reply status = %d, want 404", hiddenReply.Code)
|
||||||
|
}
|
||||||
|
hiddenEdit := postForm(handler, "/posts/"+hidden.ID+"/edit", url.Values{
|
||||||
|
"_csrf": {homeownerCSRF},
|
||||||
|
"body": {"Still hidden."},
|
||||||
|
}, homeownerCookies)
|
||||||
|
if hiddenEdit.Code != http.StatusSeeOther {
|
||||||
|
t.Fatalf("hidden edit status = %d: %s", hiddenEdit.Code, hiddenEdit.Body.String())
|
||||||
|
}
|
||||||
|
|
||||||
|
got := rec.Snapshot()
|
||||||
|
if len(got) != 4 {
|
||||||
|
t.Fatalf("published %d events, want 4: %#v", len(got), got)
|
||||||
|
}
|
||||||
|
|
||||||
|
submitEv, ok := got[0].(events.PostCreated)
|
||||||
|
if !ok {
|
||||||
|
t.Fatalf("first event %T, want PostCreated", got[0])
|
||||||
|
}
|
||||||
|
assertPostEvent(t, submitEv.PostEvent, events.PostEvent{
|
||||||
|
PostID: submitRoot.ID,
|
||||||
|
RootID: submitRoot.ID,
|
||||||
|
Title: "Leaky sink",
|
||||||
|
Body: "Water under the cabinet.",
|
||||||
|
City: "Oakland",
|
||||||
|
AuthorID: homeowner.ID,
|
||||||
|
AuthorName: homeowner.Name,
|
||||||
|
AuthorRole: string(store.RoleUser),
|
||||||
|
Permalink: "https://www.askaplumberfirst.com/questions/" + submitRoot.ID + "#post-" + submitRoot.ID,
|
||||||
|
})
|
||||||
|
|
||||||
|
createEv, ok := got[1].(events.PostCreated)
|
||||||
|
if !ok {
|
||||||
|
t.Fatalf("second event %T, want PostCreated", got[1])
|
||||||
|
}
|
||||||
|
assertPostEvent(t, createEv.PostEvent, events.PostEvent{
|
||||||
|
PostID: createRoot.ID,
|
||||||
|
RootID: createRoot.ID,
|
||||||
|
Title: "Second question",
|
||||||
|
Body: "Another leak.",
|
||||||
|
City: "Berkeley",
|
||||||
|
AuthorID: homeowner.ID,
|
||||||
|
AuthorName: homeowner.Name,
|
||||||
|
AuthorRole: string(store.RoleUser),
|
||||||
|
Permalink: "https://www.askaplumberfirst.com/questions/" + createRoot.ID + "#post-" + createRoot.ID,
|
||||||
|
})
|
||||||
|
|
||||||
|
replyEv, ok := got[2].(events.PostCreated)
|
||||||
|
if !ok {
|
||||||
|
t.Fatalf("third event %T, want PostCreated", got[2])
|
||||||
|
}
|
||||||
|
assertPostEvent(t, replyEv.PostEvent, events.PostEvent{
|
||||||
|
PostID: adminReply.ID,
|
||||||
|
RootID: createRoot.ID,
|
||||||
|
ParentID: createRoot.ID,
|
||||||
|
Body: "Replace the cartridge.",
|
||||||
|
AuthorID: admin.ID,
|
||||||
|
AuthorName: admin.Name,
|
||||||
|
AuthorRole: string(store.RoleAdmin),
|
||||||
|
Permalink: "https://www.askaplumberfirst.com/questions/" + createRoot.ID + "#post-" + adminReply.ID,
|
||||||
|
})
|
||||||
|
|
||||||
|
editEv, ok := got[3].(events.PostUpdated)
|
||||||
|
if !ok {
|
||||||
|
t.Fatalf("fourth event %T, want PostUpdated", got[3])
|
||||||
|
}
|
||||||
|
assertPostEvent(t, editEv.PostEvent, events.PostEvent{
|
||||||
|
PostID: createRoot.ID,
|
||||||
|
RootID: createRoot.ID,
|
||||||
|
Title: "Second question",
|
||||||
|
Body: "Updated leak description.",
|
||||||
|
City: "Berkeley",
|
||||||
|
AuthorID: homeowner.ID,
|
||||||
|
AuthorName: homeowner.Name,
|
||||||
|
AuthorRole: string(store.RoleUser),
|
||||||
|
Permalink: "https://www.askaplumberfirst.com/questions/" + createRoot.ID + "#post-" + createRoot.ID,
|
||||||
|
})
|
||||||
|
|
||||||
|
for i, ev := range got {
|
||||||
|
raw, err := json.Marshal(ev)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if strings.Contains(strings.ToLower(string(raw)), "discord") {
|
||||||
|
t.Fatalf("event %d contains discord fields: %s", i, raw)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestStoreCreateDoesNotPublish(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
rec := &events.Recording{}
|
||||||
|
_, mem := newTestServer(t, Config{Events: rec})
|
||||||
|
homeowner := seedUser(t, mem, uniq("homeowner"), "hunter22", store.RoleUser)
|
||||||
|
if err := mem.CreatePost(context.Background(), &store.Post{
|
||||||
|
AuthorID: homeowner.ID,
|
||||||
|
Title: "Direct write",
|
||||||
|
Body: "No handler.",
|
||||||
|
PostDate: pacific.Today(),
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if rec.Len() != 0 {
|
||||||
|
t.Fatalf("store.CreatePost published %d events", rec.Len())
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func assertPostEvent(t *testing.T, got, want events.PostEvent) {
|
||||||
|
t.Helper()
|
||||||
|
if got.PostID != want.PostID ||
|
||||||
|
got.RootID != want.RootID ||
|
||||||
|
got.ParentID != want.ParentID ||
|
||||||
|
got.Title != want.Title ||
|
||||||
|
got.Body != want.Body ||
|
||||||
|
got.City != want.City ||
|
||||||
|
got.AuthorID != want.AuthorID ||
|
||||||
|
got.AuthorName != want.AuthorName ||
|
||||||
|
got.AuthorRole != want.AuthorRole ||
|
||||||
|
got.Permalink != want.Permalink ||
|
||||||
|
len(got.Images) != 0 {
|
||||||
|
t.Fatalf("event = %+v, want %+v", got, want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestPostEventIncludesPhotosAndVideos(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
srv, _ := newTestServer(t, Config{})
|
||||||
|
got := srv.postEvent(&store.Post{
|
||||||
|
ID: "root-1",
|
||||||
|
Title: "Clip",
|
||||||
|
Body: "Photo and video.",
|
||||||
|
Images: []store.PostImage{
|
||||||
|
{PublicURL: "https://cdn.example/a.jpg", Description: "Still", Kind: store.MediaKindImage},
|
||||||
|
{PublicURL: "https://cdn.example/a.mp4", Description: "Walkthrough", Kind: store.MediaKindVideo},
|
||||||
|
},
|
||||||
|
}, nil, nil)
|
||||||
|
if len(got.Images) != 2 ||
|
||||||
|
got.Images[0].URL != "https://cdn.example/a.jpg" || got.Images[0].Kind != store.MediaKindImage ||
|
||||||
|
got.Images[1].URL != "https://cdn.example/a.mp4" || got.Images[1].Kind != store.MediaKindVideo {
|
||||||
|
t.Fatalf("event images = %+v", got.Images)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestCreatePostHoldsVideoUntilRelease(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
rec := &events.Recording{}
|
||||||
|
blobs := &recordingImageBlob{}
|
||||||
|
srv, mem := newTestServer(t, Config{
|
||||||
|
Events: rec,
|
||||||
|
Blob: blobs,
|
||||||
|
HoldUploadUntilDiscord: true,
|
||||||
|
})
|
||||||
|
handler := srv.Handler()
|
||||||
|
user := seedUser(t, mem, uniq("hold-video"), "hunter22", store.RoleUser)
|
||||||
|
cookies := loginUser(t, handler, user.Username, "hunter22")
|
||||||
|
csrf := csrfForCookies(t, handler, cookies)
|
||||||
|
clip := tinyMP4()
|
||||||
|
|
||||||
|
res := multipartPost(t, handler, "/submit", map[string][]string{
|
||||||
|
"_csrf": {csrf},
|
||||||
|
"title": {"Valve clip"},
|
||||||
|
"body": {"Watch the handle."},
|
||||||
|
"city": {"Oakland"},
|
||||||
|
}, []multipartTestFile{{name: "walk.mp4", body: clip}}, cookies)
|
||||||
|
if res.Code != http.StatusSeeOther {
|
||||||
|
t.Fatalf("submit status = %d: %s", res.Code, res.Body.String())
|
||||||
|
}
|
||||||
|
|
||||||
|
got := rec.Snapshot()
|
||||||
|
if len(got) != 1 {
|
||||||
|
t.Fatalf("published %d events, want 1: %#v", len(got), got)
|
||||||
|
}
|
||||||
|
created, ok := got[0].(events.PostCreated)
|
||||||
|
if !ok {
|
||||||
|
t.Fatalf("event %T, want PostCreated", got[0])
|
||||||
|
}
|
||||||
|
if len(created.Media) != 1 ||
|
||||||
|
created.Media[0].Kind != store.MediaKindVideo ||
|
||||||
|
created.Media[0].ContentType != "video/mp4" ||
|
||||||
|
created.Media[0].Body == nil {
|
||||||
|
t.Fatalf("held media = %+v", created.Media)
|
||||||
|
}
|
||||||
|
if created.Release == nil {
|
||||||
|
t.Fatal("missing Release")
|
||||||
|
}
|
||||||
|
body, err := io.ReadAll(created.Media[0].Body)
|
||||||
|
if err != nil || !bytes.Equal(body, clip) {
|
||||||
|
t.Fatalf("held video body = %d bytes err=%v", len(body), err)
|
||||||
|
}
|
||||||
|
created.Release()
|
||||||
|
}
|
||||||
@@ -0,0 +1,592 @@
|
|||||||
|
package web
|
||||||
|
|
||||||
|
import (
|
||||||
|
"bytes"
|
||||||
|
"context"
|
||||||
|
"errors"
|
||||||
|
"image"
|
||||||
|
"image/jpeg"
|
||||||
|
"image/png"
|
||||||
|
"io"
|
||||||
|
"log"
|
||||||
|
"mime"
|
||||||
|
"mime/multipart"
|
||||||
|
"net/http"
|
||||||
|
"path"
|
||||||
|
"strings"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"github.com/google/uuid"
|
||||||
|
"github.com/rwcarlsen/goexif/exif"
|
||||||
|
"golang.org/x/image/draw"
|
||||||
|
_ "golang.org/x/image/webp"
|
||||||
|
|
||||||
|
"plumber/internal/blob"
|
||||||
|
"plumber/internal/events"
|
||||||
|
"plumber/internal/store"
|
||||||
|
)
|
||||||
|
|
||||||
|
const (
|
||||||
|
defaultRequestBodyBytes = 3 << 20
|
||||||
|
postImageMaxFileBytes = 5 << 20
|
||||||
|
postVideoMaxFileBytes = 25 << 20
|
||||||
|
postImageMaxRequestBytes = 50 << 20 // 4 images + 1 video + form fields
|
||||||
|
postImageMultipartMemory = 2 << 20
|
||||||
|
postImageMaxSourceDim = 6000
|
||||||
|
postImageMaxSourcePixels = 16_000_000
|
||||||
|
postImageMaxRenderedDim = 1600
|
||||||
|
postImageCleanupTimeout = 10 * time.Second
|
||||||
|
)
|
||||||
|
|
||||||
|
func requestBodyLimit(r *http.Request) int64 {
|
||||||
|
if r.Method != http.MethodPost {
|
||||||
|
return defaultRequestBodyBytes
|
||||||
|
}
|
||||||
|
switch {
|
||||||
|
case r.URL.Path == "/submit", r.URL.Path == "/posts":
|
||||||
|
return postImageMaxRequestBytes
|
||||||
|
case strings.HasPrefix(r.URL.Path, "/posts/") && strings.HasSuffix(r.URL.Path, "/edit"):
|
||||||
|
return postImageMaxRequestBytes
|
||||||
|
default:
|
||||||
|
return defaultRequestBodyBytes
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
type postImageRequestError struct {
|
||||||
|
status int
|
||||||
|
message string
|
||||||
|
cause error
|
||||||
|
}
|
||||||
|
|
||||||
|
func (e *postImageRequestError) Error() string {
|
||||||
|
if e.cause == nil {
|
||||||
|
return e.message
|
||||||
|
}
|
||||||
|
return e.message + ": " + e.cause.Error()
|
||||||
|
}
|
||||||
|
|
||||||
|
func parsePostMutationForm(w http.ResponseWriter, r *http.Request) (func(), bool) {
|
||||||
|
contentType := r.Header.Get("Content-Type")
|
||||||
|
mediaType, _, err := mime.ParseMediaType(contentType)
|
||||||
|
if err != nil && strings.HasPrefix(strings.ToLower(contentType), "multipart/") {
|
||||||
|
http.Error(w, "Could not read upload.", http.StatusBadRequest)
|
||||||
|
return func() {}, false
|
||||||
|
}
|
||||||
|
if mediaType != "multipart/form-data" {
|
||||||
|
if err := r.ParseForm(); err != nil {
|
||||||
|
writePostImageRequestError(w, err)
|
||||||
|
return func() {}, false
|
||||||
|
}
|
||||||
|
return func() {}, true
|
||||||
|
}
|
||||||
|
if err := r.ParseMultipartForm(postImageMultipartMemory); err != nil {
|
||||||
|
writePostImageRequestError(w, err)
|
||||||
|
return func() {}, false
|
||||||
|
}
|
||||||
|
cleanup := func() {
|
||||||
|
if r.MultipartForm != nil {
|
||||||
|
_ = r.MultipartForm.RemoveAll()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return cleanup, true
|
||||||
|
}
|
||||||
|
|
||||||
|
func writePostImageRequestError(w http.ResponseWriter, err error) {
|
||||||
|
var requestErr *postImageRequestError
|
||||||
|
if errors.As(err, &requestErr) {
|
||||||
|
http.Error(w, requestErr.message, requestErr.status)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
var maxErr *http.MaxBytesError
|
||||||
|
if errors.As(err, &maxErr) {
|
||||||
|
http.Error(w, "Upload is too large.", http.StatusRequestEntityTooLarge)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
http.Error(w, "Could not read upload.", http.StatusBadRequest)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *Server) postImagesFromForm(
|
||||||
|
ctx context.Context,
|
||||||
|
r *http.Request,
|
||||||
|
postID string,
|
||||||
|
existing []store.PostImage,
|
||||||
|
) ([]store.PostImage, []string, []events.Media, error) {
|
||||||
|
if r.MultipartForm == nil {
|
||||||
|
return append([]store.PostImage(nil), existing...), nil, nil, nil
|
||||||
|
}
|
||||||
|
retained, err := retainedPostImages(r.MultipartForm, existing)
|
||||||
|
if err != nil {
|
||||||
|
return nil, nil, nil, err
|
||||||
|
}
|
||||||
|
files := r.MultipartForm.File["images"]
|
||||||
|
descriptions := r.MultipartForm.Value["image_description"]
|
||||||
|
if len(descriptions) > len(files) {
|
||||||
|
return nil, nil, nil, invalidPostImage("Image descriptions do not match selected images.", nil)
|
||||||
|
}
|
||||||
|
kinds := make([]string, len(files))
|
||||||
|
newImages, newVideos := 0, 0
|
||||||
|
for i, header := range files {
|
||||||
|
kinds[i] = sniffPostMedia(header)
|
||||||
|
if kinds[i] == store.MediaKindVideo {
|
||||||
|
newVideos++
|
||||||
|
} else {
|
||||||
|
newImages++
|
||||||
|
}
|
||||||
|
}
|
||||||
|
retainedImages, retainedVideos := countPostMedia(retained)
|
||||||
|
if retainedImages+newImages > store.MaxPostImages {
|
||||||
|
return nil, nil, nil, invalidPostImage("You can attach up to 4 images.", nil)
|
||||||
|
}
|
||||||
|
if retainedVideos+newVideos > store.MaxPostVideos {
|
||||||
|
return nil, nil, nil, invalidPostImage("You can attach one video.", nil)
|
||||||
|
}
|
||||||
|
if len(files) > 0 && !s.cfg.Blob.Enabled() {
|
||||||
|
return nil, nil, nil, &postImageRequestError{
|
||||||
|
status: http.StatusServiceUnavailable,
|
||||||
|
message: "Image uploads are not configured on this server.",
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
images := append([]store.PostImage(nil), retained...)
|
||||||
|
newKeys := make([]string, 0, len(files))
|
||||||
|
held := make([]events.Media, 0, len(files))
|
||||||
|
for i, header := range files {
|
||||||
|
description := ""
|
||||||
|
if i < len(descriptions) {
|
||||||
|
description = strings.TrimSpace(descriptions[i])
|
||||||
|
}
|
||||||
|
if len([]rune(description)) > store.MaxImageDescriptionRunes {
|
||||||
|
closeHeldMedia(held)
|
||||||
|
s.deletePostImageObjects(newKeys)
|
||||||
|
return nil, nil, nil, invalidPostImage("Image descriptions must be 500 characters or fewer.", nil)
|
||||||
|
}
|
||||||
|
item, objectKey, media, err := s.uploadPostMedia(ctx, postID, header, kinds[i], description)
|
||||||
|
if err != nil {
|
||||||
|
closeHeldMedia(held)
|
||||||
|
s.deletePostImageObjects(newKeys)
|
||||||
|
return nil, nil, nil, err
|
||||||
|
}
|
||||||
|
newKeys = append(newKeys, objectKey)
|
||||||
|
images = append(images, item)
|
||||||
|
held = append(held, media)
|
||||||
|
}
|
||||||
|
return images, newKeys, held, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func countPostMedia(items []store.PostImage) (images, videos int) {
|
||||||
|
for _, item := range items {
|
||||||
|
if item.Kind == store.MediaKindVideo {
|
||||||
|
videos++
|
||||||
|
} else {
|
||||||
|
images++
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return images, videos
|
||||||
|
}
|
||||||
|
|
||||||
|
func closeHeldMedia(media []events.Media) {
|
||||||
|
for i := range media {
|
||||||
|
if media[i].Body != nil {
|
||||||
|
_ = media[i].Body.Close()
|
||||||
|
media[i].Body = nil
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *Server) uploadPostMedia(
|
||||||
|
ctx context.Context,
|
||||||
|
postID string,
|
||||||
|
header *multipart.FileHeader,
|
||||||
|
kind, description string,
|
||||||
|
) (store.PostImage, string, events.Media, error) {
|
||||||
|
if kind == store.MediaKindVideo {
|
||||||
|
prepared, err := preparePostVideo(header)
|
||||||
|
if err != nil {
|
||||||
|
return store.PostImage{}, "", events.Media{}, err
|
||||||
|
}
|
||||||
|
mediaID := uuid.NewString()
|
||||||
|
objectKey := path.Join("post-videos", postID, mediaID+prepared.extension)
|
||||||
|
publicURL, err := s.cfg.Blob.Upload(ctx, blob.FileUpload{
|
||||||
|
Key: objectKey,
|
||||||
|
Body: prepared.body,
|
||||||
|
ContentType: prepared.contentType,
|
||||||
|
Size: prepared.size,
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
_ = prepared.body.Close()
|
||||||
|
return store.PostImage{}, "", events.Media{}, &postImageRequestError{
|
||||||
|
status: http.StatusServiceUnavailable,
|
||||||
|
message: "Could not upload video. Try again later.",
|
||||||
|
cause: err,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
media := events.Media{
|
||||||
|
Name: mediaID + prepared.extension,
|
||||||
|
ContentType: prepared.contentType,
|
||||||
|
Kind: store.MediaKindVideo,
|
||||||
|
Size: prepared.size,
|
||||||
|
}
|
||||||
|
if seeker, ok := prepared.body.(io.Seeker); ok {
|
||||||
|
if _, err := seeker.Seek(0, io.SeekStart); err == nil {
|
||||||
|
media.Body = prepared.body
|
||||||
|
} else {
|
||||||
|
_ = prepared.body.Close()
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
_ = prepared.body.Close()
|
||||||
|
}
|
||||||
|
return store.PostImage{
|
||||||
|
ID: mediaID,
|
||||||
|
PostID: postID,
|
||||||
|
ObjectKey: objectKey,
|
||||||
|
PublicURL: publicURL,
|
||||||
|
Description: description,
|
||||||
|
Kind: store.MediaKindVideo,
|
||||||
|
}, objectKey, media, nil
|
||||||
|
}
|
||||||
|
prepared, err := preparePostImage(header)
|
||||||
|
if err != nil {
|
||||||
|
return store.PostImage{}, "", events.Media{}, err
|
||||||
|
}
|
||||||
|
imageID := uuid.NewString()
|
||||||
|
objectKey := path.Join("post-images", postID, imageID+prepared.extension)
|
||||||
|
publicURL, err := s.cfg.Blob.Upload(ctx, blob.FileUpload{
|
||||||
|
Key: objectKey,
|
||||||
|
Body: bytes.NewReader(prepared.body),
|
||||||
|
ContentType: prepared.contentType,
|
||||||
|
Size: int64(len(prepared.body)),
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
return store.PostImage{}, "", events.Media{}, &postImageRequestError{
|
||||||
|
status: http.StatusServiceUnavailable,
|
||||||
|
message: "Could not upload image. Try again later.",
|
||||||
|
cause: err,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return store.PostImage{
|
||||||
|
ID: imageID,
|
||||||
|
PostID: postID,
|
||||||
|
ObjectKey: objectKey,
|
||||||
|
PublicURL: publicURL,
|
||||||
|
Description: description,
|
||||||
|
Kind: store.MediaKindImage,
|
||||||
|
Width: prepared.width,
|
||||||
|
Height: prepared.height,
|
||||||
|
}, objectKey, events.Media{
|
||||||
|
Name: imageID + prepared.extension,
|
||||||
|
ContentType: prepared.contentType,
|
||||||
|
Kind: store.MediaKindImage,
|
||||||
|
Size: int64(len(prepared.body)),
|
||||||
|
Bytes: prepared.body,
|
||||||
|
}, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func retainedPostImages(form *multipart.Form, existing []store.PostImage) ([]store.PostImage, error) {
|
||||||
|
byID := make(map[string]store.PostImage, len(existing))
|
||||||
|
for _, image := range existing {
|
||||||
|
byID[image.ID] = image
|
||||||
|
}
|
||||||
|
ids := form.Value["existing_image_id"]
|
||||||
|
descriptions := form.Value["existing_image_description"]
|
||||||
|
if len(descriptions) > len(ids) {
|
||||||
|
return nil, invalidPostImage("Existing image descriptions do not match the images.", nil)
|
||||||
|
}
|
||||||
|
seen := make(map[string]bool, len(ids))
|
||||||
|
retained := make([]store.PostImage, 0, len(ids))
|
||||||
|
for i, id := range ids {
|
||||||
|
id = strings.TrimSpace(id)
|
||||||
|
image, ok := byID[id]
|
||||||
|
if !ok || seen[id] {
|
||||||
|
return nil, invalidPostImage("An existing image selection is invalid.", nil)
|
||||||
|
}
|
||||||
|
seen[id] = true
|
||||||
|
if i < len(descriptions) {
|
||||||
|
image.Description = strings.TrimSpace(descriptions[i])
|
||||||
|
}
|
||||||
|
if len([]rune(image.Description)) > store.MaxImageDescriptionRunes {
|
||||||
|
return nil, invalidPostImage("Image descriptions must be 500 characters or fewer.", nil)
|
||||||
|
}
|
||||||
|
retained = append(retained, image)
|
||||||
|
}
|
||||||
|
return retained, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func invalidPostImage(message string, cause error) error {
|
||||||
|
return &postImageRequestError{status: http.StatusBadRequest, message: message, cause: cause}
|
||||||
|
}
|
||||||
|
|
||||||
|
type preparedPostImage struct {
|
||||||
|
body []byte
|
||||||
|
extension string
|
||||||
|
contentType string
|
||||||
|
width int
|
||||||
|
height int
|
||||||
|
}
|
||||||
|
|
||||||
|
func preparePostImage(header *multipart.FileHeader) (preparedPostImage, error) {
|
||||||
|
if header == nil {
|
||||||
|
return preparedPostImage{}, invalidPostImage("Select a valid image.", nil)
|
||||||
|
}
|
||||||
|
if header.Size > postImageMaxFileBytes {
|
||||||
|
return preparedPostImage{}, &postImageRequestError{
|
||||||
|
status: http.StatusRequestEntityTooLarge,
|
||||||
|
message: "Each image must be 5 MB or smaller.",
|
||||||
|
}
|
||||||
|
}
|
||||||
|
file, err := header.Open()
|
||||||
|
if err != nil {
|
||||||
|
return preparedPostImage{}, invalidPostImage("Could not read image.", err)
|
||||||
|
}
|
||||||
|
defer file.Close()
|
||||||
|
raw, err := io.ReadAll(io.LimitReader(file, postImageMaxFileBytes+1))
|
||||||
|
if err != nil {
|
||||||
|
return preparedPostImage{}, invalidPostImage("Could not read image.", err)
|
||||||
|
}
|
||||||
|
if len(raw) == 0 {
|
||||||
|
return preparedPostImage{}, invalidPostImage("Images cannot be empty.", nil)
|
||||||
|
}
|
||||||
|
if int64(len(raw)) > postImageMaxFileBytes {
|
||||||
|
return preparedPostImage{}, &postImageRequestError{
|
||||||
|
status: http.StatusRequestEntityTooLarge,
|
||||||
|
message: "Each image must be 5 MB or smaller.",
|
||||||
|
}
|
||||||
|
}
|
||||||
|
sniffed := http.DetectContentType(raw)
|
||||||
|
switch sniffed {
|
||||||
|
case "image/jpeg", "image/png", "image/webp":
|
||||||
|
default:
|
||||||
|
return preparedPostImage{}, invalidPostImage("Images must be JPEG, PNG, or WebP.", nil)
|
||||||
|
}
|
||||||
|
cfg, format, err := image.DecodeConfig(bytes.NewReader(raw))
|
||||||
|
if err != nil {
|
||||||
|
return preparedPostImage{}, invalidPostImage("Could not decode image.", err)
|
||||||
|
}
|
||||||
|
if cfg.Width <= 0 || cfg.Height <= 0 ||
|
||||||
|
cfg.Width > postImageMaxSourceDim || cfg.Height > postImageMaxSourceDim ||
|
||||||
|
int64(cfg.Width)*int64(cfg.Height) > postImageMaxSourcePixels {
|
||||||
|
return preparedPostImage{}, invalidPostImage("Image dimensions are too large.", nil)
|
||||||
|
}
|
||||||
|
decoded, decodedFormat, err := image.Decode(bytes.NewReader(raw))
|
||||||
|
if err != nil {
|
||||||
|
return preparedPostImage{}, invalidPostImage("Could not decode image.", err)
|
||||||
|
}
|
||||||
|
if format != "" {
|
||||||
|
decodedFormat = format
|
||||||
|
}
|
||||||
|
if sniffed == "image/jpeg" {
|
||||||
|
decoded = orientPostImage(decoded, jpegOrientation(raw))
|
||||||
|
}
|
||||||
|
decoded = fitPostImage(decoded, postImageMaxRenderedDim)
|
||||||
|
|
||||||
|
var out bytes.Buffer
|
||||||
|
result := preparedPostImage{}
|
||||||
|
switch decodedFormat {
|
||||||
|
case "jpeg":
|
||||||
|
if err := jpeg.Encode(&out, decoded, &jpeg.Options{Quality: 85}); err != nil {
|
||||||
|
return preparedPostImage{}, invalidPostImage("Could not encode image.", err)
|
||||||
|
}
|
||||||
|
result.extension = ".jpg"
|
||||||
|
result.contentType = "image/jpeg"
|
||||||
|
case "png", "webp":
|
||||||
|
if err := png.Encode(&out, decoded); err != nil {
|
||||||
|
return preparedPostImage{}, invalidPostImage("Could not encode image.", err)
|
||||||
|
}
|
||||||
|
result.extension = ".png"
|
||||||
|
result.contentType = "image/png"
|
||||||
|
default:
|
||||||
|
return preparedPostImage{}, invalidPostImage("Images must be JPEG, PNG, or WebP.", nil)
|
||||||
|
}
|
||||||
|
result.body = out.Bytes()
|
||||||
|
result.width = decoded.Bounds().Dx()
|
||||||
|
result.height = decoded.Bounds().Dy()
|
||||||
|
return result, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func sniffPostMedia(header *multipart.FileHeader) string {
|
||||||
|
if header == nil {
|
||||||
|
return store.MediaKindImage
|
||||||
|
}
|
||||||
|
file, err := header.Open()
|
||||||
|
if err != nil {
|
||||||
|
return store.MediaKindImage
|
||||||
|
}
|
||||||
|
defer file.Close()
|
||||||
|
peek := make([]byte, 512)
|
||||||
|
n, err := io.ReadFull(file, peek)
|
||||||
|
if err != nil && !errors.Is(err, io.ErrUnexpectedEOF) && !errors.Is(err, io.EOF) {
|
||||||
|
return store.MediaKindImage
|
||||||
|
}
|
||||||
|
return mediaKindFromBytes(peek[:n])
|
||||||
|
}
|
||||||
|
|
||||||
|
func mediaKindFromBytes(raw []byte) string {
|
||||||
|
switch http.DetectContentType(raw) {
|
||||||
|
case "video/mp4", "video/webm":
|
||||||
|
return store.MediaKindVideo
|
||||||
|
case "image/jpeg", "image/png", "image/webp":
|
||||||
|
return store.MediaKindImage
|
||||||
|
}
|
||||||
|
if isMP4(raw) || isWebM(raw) {
|
||||||
|
return store.MediaKindVideo
|
||||||
|
}
|
||||||
|
return store.MediaKindImage
|
||||||
|
}
|
||||||
|
|
||||||
|
func isMP4(raw []byte) bool {
|
||||||
|
return len(raw) >= 8 && string(raw[4:8]) == "ftyp"
|
||||||
|
}
|
||||||
|
|
||||||
|
func isWebM(raw []byte) bool {
|
||||||
|
return len(raw) >= 4 && raw[0] == 0x1a && raw[1] == 0x45 && raw[2] == 0xdf && raw[3] == 0xa3
|
||||||
|
}
|
||||||
|
|
||||||
|
type preparedPostVideo struct {
|
||||||
|
body io.ReadCloser
|
||||||
|
size int64
|
||||||
|
extension string
|
||||||
|
contentType string
|
||||||
|
}
|
||||||
|
|
||||||
|
func preparePostVideo(header *multipart.FileHeader) (preparedPostVideo, error) {
|
||||||
|
if header == nil {
|
||||||
|
return preparedPostVideo{}, invalidPostImage("Select a valid video.", nil)
|
||||||
|
}
|
||||||
|
if header.Size == 0 {
|
||||||
|
return preparedPostVideo{}, invalidPostImage("Videos cannot be empty.", nil)
|
||||||
|
}
|
||||||
|
if header.Size > postVideoMaxFileBytes {
|
||||||
|
return preparedPostVideo{}, &postImageRequestError{
|
||||||
|
status: http.StatusRequestEntityTooLarge,
|
||||||
|
message: "Each video must be 25 MB or smaller.",
|
||||||
|
}
|
||||||
|
}
|
||||||
|
file, err := header.Open()
|
||||||
|
if err != nil {
|
||||||
|
return preparedPostVideo{}, invalidPostImage("Could not read video.", err)
|
||||||
|
}
|
||||||
|
peek := make([]byte, 512)
|
||||||
|
n, err := io.ReadFull(file, peek)
|
||||||
|
if err != nil && !errors.Is(err, io.ErrUnexpectedEOF) && !errors.Is(err, io.EOF) {
|
||||||
|
file.Close()
|
||||||
|
return preparedPostVideo{}, invalidPostImage("Could not read video.", err)
|
||||||
|
}
|
||||||
|
if n == 0 {
|
||||||
|
file.Close()
|
||||||
|
return preparedPostVideo{}, invalidPostImage("Videos cannot be empty.", nil)
|
||||||
|
}
|
||||||
|
switch mediaKindFromBytes(peek[:n]) {
|
||||||
|
case store.MediaKindVideo:
|
||||||
|
default:
|
||||||
|
file.Close()
|
||||||
|
return preparedPostVideo{}, invalidPostImage("Videos must be MP4 or WebM.", nil)
|
||||||
|
}
|
||||||
|
if _, err := file.Seek(0, io.SeekStart); err != nil {
|
||||||
|
file.Close()
|
||||||
|
return preparedPostVideo{}, invalidPostImage("Could not read video.", err)
|
||||||
|
}
|
||||||
|
result := preparedPostVideo{body: file, size: header.Size}
|
||||||
|
if isWebM(peek[:n]) {
|
||||||
|
result.extension = ".webm"
|
||||||
|
result.contentType = "video/webm"
|
||||||
|
return result, nil
|
||||||
|
}
|
||||||
|
result.extension = ".mp4"
|
||||||
|
result.contentType = "video/mp4"
|
||||||
|
return result, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func jpegOrientation(raw []byte) int {
|
||||||
|
metadata, err := exif.Decode(bytes.NewReader(raw))
|
||||||
|
if err != nil {
|
||||||
|
return 1
|
||||||
|
}
|
||||||
|
tag, err := metadata.Get(exif.Orientation)
|
||||||
|
if err != nil {
|
||||||
|
return 1
|
||||||
|
}
|
||||||
|
orientation, err := tag.Int(0)
|
||||||
|
if err != nil || orientation < 1 || orientation > 8 {
|
||||||
|
return 1
|
||||||
|
}
|
||||||
|
return orientation
|
||||||
|
}
|
||||||
|
|
||||||
|
func orientPostImage(source image.Image, orientation int) image.Image {
|
||||||
|
if orientation <= 1 || orientation > 8 {
|
||||||
|
return source
|
||||||
|
}
|
||||||
|
bounds := source.Bounds()
|
||||||
|
width, height := bounds.Dx(), bounds.Dy()
|
||||||
|
targetWidth, targetHeight := width, height
|
||||||
|
if orientation >= 5 {
|
||||||
|
targetWidth, targetHeight = height, width
|
||||||
|
}
|
||||||
|
target := image.NewNRGBA(image.Rect(0, 0, targetWidth, targetHeight))
|
||||||
|
for y := 0; y < targetHeight; y++ {
|
||||||
|
for x := 0; x < targetWidth; x++ {
|
||||||
|
sourceX, sourceY := x, y
|
||||||
|
switch orientation {
|
||||||
|
case 2:
|
||||||
|
sourceX = width - 1 - x
|
||||||
|
case 3:
|
||||||
|
sourceX, sourceY = width-1-x, height-1-y
|
||||||
|
case 4:
|
||||||
|
sourceY = height - 1 - y
|
||||||
|
case 5:
|
||||||
|
sourceX, sourceY = y, x
|
||||||
|
case 6:
|
||||||
|
sourceX, sourceY = y, height-1-x
|
||||||
|
case 7:
|
||||||
|
sourceX, sourceY = width-1-y, height-1-x
|
||||||
|
case 8:
|
||||||
|
sourceX, sourceY = width-1-y, x
|
||||||
|
}
|
||||||
|
target.Set(x, y, source.At(bounds.Min.X+sourceX, bounds.Min.Y+sourceY))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return target
|
||||||
|
}
|
||||||
|
|
||||||
|
func fitPostImage(source image.Image, maxDimension int) image.Image {
|
||||||
|
bounds := source.Bounds()
|
||||||
|
width, height := bounds.Dx(), bounds.Dy()
|
||||||
|
if width <= maxDimension && height <= maxDimension {
|
||||||
|
return source
|
||||||
|
}
|
||||||
|
scale := float64(maxDimension) / float64(width)
|
||||||
|
if float64(height)*scale > float64(maxDimension) {
|
||||||
|
scale = float64(maxDimension) / float64(height)
|
||||||
|
}
|
||||||
|
targetWidth := max(1, int(float64(width)*scale))
|
||||||
|
targetHeight := max(1, int(float64(height)*scale))
|
||||||
|
target := image.NewNRGBA(image.Rect(0, 0, targetWidth, targetHeight))
|
||||||
|
draw.CatmullRom.Scale(target, target.Bounds(), source, bounds, draw.Over, nil)
|
||||||
|
return target
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *Server) deletePostImageObjects(keys []string) {
|
||||||
|
if len(keys) == 0 {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
ctx, cancel := context.WithTimeout(context.Background(), postImageCleanupTimeout)
|
||||||
|
defer cancel()
|
||||||
|
for _, key := range keys {
|
||||||
|
if err := s.cfg.Blob.Delete(ctx, key); err != nil {
|
||||||
|
log.Printf("delete post image %s: %v", key, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func removedPostImageKeys(before, after []store.PostImage) []string {
|
||||||
|
retained := make(map[string]bool, len(after))
|
||||||
|
for _, image := range after {
|
||||||
|
retained[image.ObjectKey] = true
|
||||||
|
}
|
||||||
|
var removed []string
|
||||||
|
for _, image := range before {
|
||||||
|
if !retained[image.ObjectKey] {
|
||||||
|
removed = append(removed, image.ObjectKey)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return removed
|
||||||
|
}
|
||||||
@@ -0,0 +1,626 @@
|
|||||||
|
package web
|
||||||
|
|
||||||
|
import (
|
||||||
|
"bytes"
|
||||||
|
"context"
|
||||||
|
"errors"
|
||||||
|
"image"
|
||||||
|
"image/color"
|
||||||
|
"image/jpeg"
|
||||||
|
"image/png"
|
||||||
|
"io"
|
||||||
|
"mime/multipart"
|
||||||
|
"net/http"
|
||||||
|
"net/http/httptest"
|
||||||
|
"strings"
|
||||||
|
"sync"
|
||||||
|
"testing"
|
||||||
|
|
||||||
|
"plumber/internal/blob"
|
||||||
|
"plumber/internal/pacific"
|
||||||
|
"plumber/internal/store"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestPreparePostImage(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
wide := solidPNG(t, 2000, 1000)
|
||||||
|
prepared, err := preparePostImageHeader(t, "wide.png", wide)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if prepared.width != 1600 || prepared.height != 800 ||
|
||||||
|
prepared.extension != ".png" || prepared.contentType != "image/png" {
|
||||||
|
t.Fatalf("prepared PNG = %+v", prepared)
|
||||||
|
}
|
||||||
|
|
||||||
|
jpegBody := solidJPEG(t, 40, 20)
|
||||||
|
prepared, err = preparePostImageHeader(t, "photo.jpg", jpegBody)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if prepared.width != 40 || prepared.height != 20 ||
|
||||||
|
prepared.extension != ".jpg" || prepared.contentType != "image/jpeg" {
|
||||||
|
t.Fatalf("prepared JPEG = %+v", prepared)
|
||||||
|
}
|
||||||
|
|
||||||
|
if _, err := preparePostImageHeader(t, "notes.txt", []byte("not an image")); err == nil {
|
||||||
|
t.Fatal("text upload unexpectedly succeeded")
|
||||||
|
}
|
||||||
|
_, err = preparePostImageHeader(t, "too-large.jpg", make([]byte, postImageMaxFileBytes+1))
|
||||||
|
var requestErr *postImageRequestError
|
||||||
|
if !errors.As(err, &requestErr) || requestErr.status != http.StatusRequestEntityTooLarge {
|
||||||
|
t.Fatalf("oversized file error = %v, want 413 request error", err)
|
||||||
|
}
|
||||||
|
if _, err := preparePostImageHeader(t, "too-wide.png", solidPNG(t, 6001, 1)); err == nil {
|
||||||
|
t.Fatal("oversized dimensions unexpectedly succeeded")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestPreparePostVideo(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
mp4 := tinyMP4()
|
||||||
|
prepared, err := preparePostVideoHeader(t, "clip.mp4", mp4)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
defer prepared.body.Close()
|
||||||
|
got, err := io.ReadAll(prepared.body)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if prepared.extension != ".mp4" || prepared.contentType != "video/mp4" ||
|
||||||
|
prepared.size != int64(len(mp4)) || !bytes.Equal(got, mp4) {
|
||||||
|
t.Fatalf("prepared MP4 = %+v len(body)=%d", prepared, len(got))
|
||||||
|
}
|
||||||
|
|
||||||
|
webm := tinyWebM()
|
||||||
|
prepared, err = preparePostVideoHeader(t, "clip.webm", webm)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
defer prepared.body.Close()
|
||||||
|
if prepared.extension != ".webm" || prepared.contentType != "video/webm" ||
|
||||||
|
prepared.size != int64(len(webm)) {
|
||||||
|
t.Fatalf("prepared WebM = %+v", prepared)
|
||||||
|
}
|
||||||
|
if _, err := preparePostVideoHeader(t, "empty.mp4", nil); err == nil {
|
||||||
|
t.Fatal("empty video unexpectedly succeeded")
|
||||||
|
}
|
||||||
|
if _, err := preparePostVideoHeader(t, "notes.txt", []byte("not a video")); err == nil {
|
||||||
|
t.Fatal("text video upload unexpectedly succeeded")
|
||||||
|
}
|
||||||
|
_, err = preparePostVideoHeader(t, "too-large.mp4", make([]byte, postVideoMaxFileBytes+1))
|
||||||
|
var requestErr *postImageRequestError
|
||||||
|
if !errors.As(err, &requestErr) || requestErr.status != http.StatusRequestEntityTooLarge {
|
||||||
|
t.Fatalf("oversized video error = %v, want 413 request error", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestOrientPostImage(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
source := image.NewNRGBA(image.Rect(0, 0, 2, 1))
|
||||||
|
source.Set(0, 0, color.NRGBA{R: 255, A: 255})
|
||||||
|
source.Set(1, 0, color.NRGBA{B: 255, A: 255})
|
||||||
|
rotated := orientPostImage(source, 6)
|
||||||
|
if rotated.Bounds().Dx() != 1 || rotated.Bounds().Dy() != 2 {
|
||||||
|
t.Fatalf("rotated bounds = %v", rotated.Bounds())
|
||||||
|
}
|
||||||
|
top := color.NRGBAModel.Convert(rotated.At(0, 0)).(color.NRGBA)
|
||||||
|
bottom := color.NRGBAModel.Convert(rotated.At(0, 1)).(color.NRGBA)
|
||||||
|
if top.R != 255 || bottom.B != 255 {
|
||||||
|
t.Fatalf("rotation colors top=%v bottom=%v", top, bottom)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestPostImageMultipartLifecycle(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
images := &recordingImageBlob{}
|
||||||
|
srv, mem := newTestServer(t, Config{Blob: images})
|
||||||
|
handler := srv.Handler()
|
||||||
|
homeowner := seedUser(t, mem, uniq("images"), "hunter22", store.RoleUser)
|
||||||
|
cookies := loginUser(t, handler, homeowner.Username, "hunter22")
|
||||||
|
csrf := csrfForCookies(t, handler, cookies)
|
||||||
|
|
||||||
|
rec := multipartPost(t, handler, "/submit", map[string][]string{
|
||||||
|
"_csrf": {csrf},
|
||||||
|
"title": {"Leaky valve"},
|
||||||
|
"body": {"Two views of the leak."},
|
||||||
|
"city": {"Oakland"},
|
||||||
|
"image_description": {"Front view", "Under the sink"},
|
||||||
|
}, []multipartTestFile{
|
||||||
|
{name: "front.png", body: solidPNG(t, 80, 40)},
|
||||||
|
{name: "under.jpg", body: solidJPEG(t, 40, 80)},
|
||||||
|
}, cookies)
|
||||||
|
if rec.Code != http.StatusSeeOther {
|
||||||
|
t.Fatalf("root image upload status = %d: %s", rec.Code, rec.Body.String())
|
||||||
|
}
|
||||||
|
roots, err := mem.ListRootPosts(context.Background(), pacific.Today(), homeowner.ID)
|
||||||
|
if err != nil || len(roots) != 1 {
|
||||||
|
t.Fatalf("roots = %+v, %v", roots, err)
|
||||||
|
}
|
||||||
|
root, err := mem.GetPost(context.Background(), roots[0].ID)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if len(root.Images) != 2 ||
|
||||||
|
root.Images[0].Description != "Front view" ||
|
||||||
|
root.Images[1].Description != "Under the sink" {
|
||||||
|
t.Fatalf("root images = %+v", root.Images)
|
||||||
|
}
|
||||||
|
|
||||||
|
rec = multipartPost(t, handler, "/posts", map[string][]string{
|
||||||
|
"_csrf": {csrf},
|
||||||
|
"parent_id": {root.ID},
|
||||||
|
"body": {"Here is the model label."},
|
||||||
|
"image_description": {"Model label"},
|
||||||
|
}, []multipartTestFile{{name: "label.png", body: solidPNG(t, 60, 30)}}, cookies)
|
||||||
|
if rec.Code != http.StatusSeeOther {
|
||||||
|
t.Fatalf("reply image upload status = %d: %s", rec.Code, rec.Body.String())
|
||||||
|
}
|
||||||
|
thread, err := mem.GetPostThread(context.Background(), root.ID)
|
||||||
|
if err != nil || len(thread.Replies) != 1 {
|
||||||
|
t.Fatalf("thread = %+v, %v", thread, err)
|
||||||
|
}
|
||||||
|
reply := thread.Replies[0]
|
||||||
|
if len(reply.Images) != 1 || reply.Images[0].Description != "Model label" {
|
||||||
|
t.Fatalf("reply images = %+v", reply.Images)
|
||||||
|
}
|
||||||
|
originalKey := reply.Images[0].ObjectKey
|
||||||
|
|
||||||
|
rec = multipartPost(t, handler, "/posts/"+reply.ID+"/edit", map[string][]string{
|
||||||
|
"_csrf": {csrf},
|
||||||
|
"body": {"Updated label photos."},
|
||||||
|
"existing_image_id": {reply.Images[0].ID},
|
||||||
|
"existing_image_description": {"Existing label"},
|
||||||
|
"image_description": {"Serial number"},
|
||||||
|
}, []multipartTestFile{{name: "serial.jpg", body: solidJPEG(t, 50, 25)}}, cookies)
|
||||||
|
if rec.Code != http.StatusSeeOther {
|
||||||
|
t.Fatalf("image edit status = %d: %s", rec.Code, rec.Body.String())
|
||||||
|
}
|
||||||
|
edited, err := mem.GetPost(context.Background(), reply.ID)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if len(edited.Images) != 2 ||
|
||||||
|
edited.Images[0].Description != "Existing label" ||
|
||||||
|
edited.Images[1].Description != "Serial number" {
|
||||||
|
t.Fatalf("edited images = %+v", edited.Images)
|
||||||
|
}
|
||||||
|
|
||||||
|
rec = multipartPost(t, handler, "/posts/"+reply.ID+"/edit", map[string][]string{
|
||||||
|
"_csrf": {csrf},
|
||||||
|
"body": {"Keep only the serial number."},
|
||||||
|
"existing_image_id": {edited.Images[1].ID},
|
||||||
|
"existing_image_description": {"Serial number"},
|
||||||
|
}, nil, cookies)
|
||||||
|
if rec.Code != http.StatusSeeOther {
|
||||||
|
t.Fatalf("image removal status = %d: %s", rec.Code, rec.Body.String())
|
||||||
|
}
|
||||||
|
edited, err = mem.GetPost(context.Background(), reply.ID)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if len(edited.Images) != 1 || edited.Images[0].Description != "Serial number" {
|
||||||
|
t.Fatalf("images after removal = %+v", edited.Images)
|
||||||
|
}
|
||||||
|
if !images.wasDeleted(originalKey) {
|
||||||
|
t.Fatalf("removed object %q was not deleted: %+v", originalKey, images.deletedKeys())
|
||||||
|
}
|
||||||
|
|
||||||
|
uploadsBefore := images.uploadCount()
|
||||||
|
rec = multipartPost(t, handler, "/posts/"+reply.ID+"/edit", map[string][]string{
|
||||||
|
"_csrf": {csrf},
|
||||||
|
"body": {"Invalid retained image."},
|
||||||
|
"existing_image_id": {"not-owned"},
|
||||||
|
}, nil, cookies)
|
||||||
|
if rec.Code != http.StatusBadRequest {
|
||||||
|
t.Fatalf("invalid retained image status = %d, want 400", rec.Code)
|
||||||
|
}
|
||||||
|
unchanged, err := mem.GetPost(context.Background(), reply.ID)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if unchanged.Body != "Keep only the serial number." || len(unchanged.Images) != 1 {
|
||||||
|
t.Fatalf("invalid retained image changed post: %+v", unchanged)
|
||||||
|
}
|
||||||
|
|
||||||
|
files := make([]multipartTestFile, store.MaxPostImages+1)
|
||||||
|
for i := range files {
|
||||||
|
files[i] = multipartTestFile{name: "extra.png", body: solidPNG(t, 10, 10)}
|
||||||
|
}
|
||||||
|
rec = multipartPost(t, handler, "/posts", map[string][]string{
|
||||||
|
"_csrf": {csrf},
|
||||||
|
"parent_id": {root.ID},
|
||||||
|
"body": {"Too many images."},
|
||||||
|
}, files, cookies)
|
||||||
|
if rec.Code != http.StatusBadRequest {
|
||||||
|
t.Fatalf("five-image status = %d, want 400", rec.Code)
|
||||||
|
}
|
||||||
|
if images.uploadCount() != uploadsBefore {
|
||||||
|
t.Fatal("five-image request uploaded objects before rejecting count")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestPostVideoMultipartLifecycle(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
blobs := &recordingImageBlob{}
|
||||||
|
srv, mem := newTestServer(t, Config{Blob: blobs})
|
||||||
|
handler := srv.Handler()
|
||||||
|
homeowner := seedUser(t, mem, uniq("video"), "hunter22", store.RoleUser)
|
||||||
|
cookies := loginUser(t, handler, homeowner.Username, "hunter22")
|
||||||
|
csrf := csrfForCookies(t, handler, cookies)
|
||||||
|
|
||||||
|
rec := multipartPost(t, handler, "/submit", map[string][]string{
|
||||||
|
"_csrf": {csrf},
|
||||||
|
"title": {"Valve clip"},
|
||||||
|
"body": {"A photo and a video."},
|
||||||
|
"city": {"Oakland"},
|
||||||
|
"image_description": {"Still", "Walkthrough"},
|
||||||
|
}, []multipartTestFile{
|
||||||
|
{name: "still.png", body: solidPNG(t, 40, 20)},
|
||||||
|
{name: "walk.mp4", body: tinyMP4()},
|
||||||
|
}, cookies)
|
||||||
|
if rec.Code != http.StatusSeeOther {
|
||||||
|
t.Fatalf("root video upload status = %d: %s", rec.Code, rec.Body.String())
|
||||||
|
}
|
||||||
|
roots, err := mem.ListRootPosts(context.Background(), pacific.Today(), homeowner.ID)
|
||||||
|
if err != nil || len(roots) != 1 {
|
||||||
|
t.Fatalf("roots = %+v, %v", roots, err)
|
||||||
|
}
|
||||||
|
root, err := mem.GetPost(context.Background(), roots[0].ID)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if len(root.Images) != 2 ||
|
||||||
|
root.Images[0].Kind != store.MediaKindImage ||
|
||||||
|
root.Images[1].Kind != store.MediaKindVideo ||
|
||||||
|
root.Images[1].Description != "Walkthrough" ||
|
||||||
|
!strings.HasPrefix(root.Images[1].ObjectKey, "post-videos/") {
|
||||||
|
t.Fatalf("root media = %+v", root.Images)
|
||||||
|
}
|
||||||
|
clip := tinyMP4()
|
||||||
|
var streamed recordedImageUpload
|
||||||
|
for _, upload := range blobs.recordedUploads() {
|
||||||
|
if strings.HasPrefix(upload.key, "post-videos/") {
|
||||||
|
streamed = upload
|
||||||
|
break
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if streamed.size != int64(len(clip)) || !bytes.Equal(streamed.body, clip) {
|
||||||
|
t.Fatalf("streamed video upload = %+v", streamed)
|
||||||
|
}
|
||||||
|
|
||||||
|
rec = httptest.NewRecorder()
|
||||||
|
req := httptest.NewRequest(http.MethodGet, "/questions/"+root.ID, nil)
|
||||||
|
for _, cookie := range cookies {
|
||||||
|
req.AddCookie(cookie)
|
||||||
|
}
|
||||||
|
handler.ServeHTTP(rec, req)
|
||||||
|
page := rec.Body.String()
|
||||||
|
if rec.Code != http.StatusOK ||
|
||||||
|
!strings.Contains(page, `<video src="`+root.Images[1].PublicURL) ||
|
||||||
|
!strings.Contains(page, `data-existing-video`) {
|
||||||
|
t.Fatalf("question page missing video player: %d %s", rec.Code, page)
|
||||||
|
}
|
||||||
|
|
||||||
|
rec = multipartPost(t, handler, "/posts/"+root.ID+"/edit", map[string][]string{
|
||||||
|
"_csrf": {csrf},
|
||||||
|
"body": {"Keep the clip."},
|
||||||
|
"existing_image_id": {root.Images[1].ID},
|
||||||
|
"existing_image_description": {"Kept clip"},
|
||||||
|
}, nil, cookies)
|
||||||
|
if rec.Code != http.StatusSeeOther {
|
||||||
|
t.Fatalf("retain video status = %d: %s", rec.Code, rec.Body.String())
|
||||||
|
}
|
||||||
|
edited, err := mem.GetPost(context.Background(), root.ID)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if len(edited.Images) != 1 || edited.Images[0].Kind != store.MediaKindVideo ||
|
||||||
|
edited.Images[0].Description != "Kept clip" {
|
||||||
|
t.Fatalf("retained video = %+v", edited.Images)
|
||||||
|
}
|
||||||
|
|
||||||
|
rec = multipartPost(t, handler, "/posts", map[string][]string{
|
||||||
|
"_csrf": {csrf},
|
||||||
|
"parent_id": {root.ID},
|
||||||
|
"body": {"Two clips."},
|
||||||
|
}, []multipartTestFile{
|
||||||
|
{name: "a.mp4", body: tinyMP4()},
|
||||||
|
{name: "b.mp4", body: tinyMP4()},
|
||||||
|
}, cookies)
|
||||||
|
if rec.Code != http.StatusBadRequest {
|
||||||
|
t.Fatalf("two-video status = %d, want 400", rec.Code)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestPostImageUploadCompensation(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
t.Run("blob failure deletes earlier upload", func(t *testing.T) {
|
||||||
|
images := &recordingImageBlob{failAt: 2}
|
||||||
|
srv, mem := newTestServer(t, Config{Blob: images})
|
||||||
|
handler := srv.Handler()
|
||||||
|
user := seedUser(t, mem, uniq("blob-fail"), "hunter22", store.RoleUser)
|
||||||
|
cookies := loginUser(t, handler, user.Username, "hunter22")
|
||||||
|
csrf := csrfForCookies(t, handler, cookies)
|
||||||
|
rec := multipartPost(t, handler, "/submit", map[string][]string{
|
||||||
|
"_csrf": {csrf},
|
||||||
|
"title": {"Upload failure"},
|
||||||
|
"body": {"Should not persist."},
|
||||||
|
}, []multipartTestFile{
|
||||||
|
{name: "one.png", body: solidPNG(t, 10, 10)},
|
||||||
|
{name: "two.png", body: solidPNG(t, 10, 10)},
|
||||||
|
}, cookies)
|
||||||
|
if rec.Code != http.StatusServiceUnavailable {
|
||||||
|
t.Fatalf("blob failure status = %d: %s", rec.Code, rec.Body.String())
|
||||||
|
}
|
||||||
|
if images.uploadCount() != 1 || len(images.deletedKeys()) != 1 {
|
||||||
|
t.Fatalf("blob compensation uploads=%d deletes=%v", images.uploadCount(), images.deletedKeys())
|
||||||
|
}
|
||||||
|
})
|
||||||
|
|
||||||
|
t.Run("store failure deletes uploaded object", func(t *testing.T) {
|
||||||
|
images := &recordingImageBlob{}
|
||||||
|
mem := store.NewMemory()
|
||||||
|
failing := &failingCreatePostStore{Store: mem}
|
||||||
|
srv := newTestServerStore(t, failing, Config{Blob: images})
|
||||||
|
handler := srv.Handler()
|
||||||
|
user := seedUser(t, mem, uniq("store-fail"), "hunter22", store.RoleUser)
|
||||||
|
cookies := loginUser(t, handler, user.Username, "hunter22")
|
||||||
|
csrf := csrfForCookies(t, handler, cookies)
|
||||||
|
rec := multipartPost(t, handler, "/submit", map[string][]string{
|
||||||
|
"_csrf": {csrf},
|
||||||
|
"title": {"Store failure"},
|
||||||
|
"body": {"Should clean up."},
|
||||||
|
}, []multipartTestFile{{name: "one.png", body: solidPNG(t, 10, 10)}}, cookies)
|
||||||
|
if rec.Code != http.StatusInternalServerError {
|
||||||
|
t.Fatalf("store failure status = %d: %s", rec.Code, rec.Body.String())
|
||||||
|
}
|
||||||
|
if images.uploadCount() != 1 || len(images.deletedKeys()) != 1 {
|
||||||
|
t.Fatalf("store compensation uploads=%d deletes=%v", images.uploadCount(), images.deletedKeys())
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestPostImageRequestLimits(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
for _, test := range []struct {
|
||||||
|
method string
|
||||||
|
path string
|
||||||
|
want int64
|
||||||
|
}{
|
||||||
|
{http.MethodPost, "/submit", postImageMaxRequestBytes},
|
||||||
|
{http.MethodPost, "/posts", postImageMaxRequestBytes},
|
||||||
|
{http.MethodPost, "/posts/id/edit", postImageMaxRequestBytes},
|
||||||
|
{http.MethodPost, "/login", defaultRequestBodyBytes},
|
||||||
|
{http.MethodGet, "/posts", defaultRequestBodyBytes},
|
||||||
|
} {
|
||||||
|
req := httptest.NewRequest(test.method, test.path, nil)
|
||||||
|
if got := requestBodyLimit(req); got != test.want {
|
||||||
|
t.Errorf("%s %s limit = %d, want %d", test.method, test.path, got, test.want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
type multipartTestFile struct {
|
||||||
|
name string
|
||||||
|
body []byte
|
||||||
|
}
|
||||||
|
|
||||||
|
func multipartPost(
|
||||||
|
t *testing.T,
|
||||||
|
handler http.Handler,
|
||||||
|
requestPath string,
|
||||||
|
fields map[string][]string,
|
||||||
|
files []multipartTestFile,
|
||||||
|
cookies []*http.Cookie,
|
||||||
|
) *httptest.ResponseRecorder {
|
||||||
|
t.Helper()
|
||||||
|
var body bytes.Buffer
|
||||||
|
writer := multipart.NewWriter(&body)
|
||||||
|
for name, values := range fields {
|
||||||
|
for _, value := range values {
|
||||||
|
if err := writer.WriteField(name, value); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
for _, file := range files {
|
||||||
|
part, err := writer.CreateFormFile("images", file.name)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if _, err := part.Write(file.body); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if err := writer.Close(); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
req := httptest.NewRequest(http.MethodPost, requestPath, &body)
|
||||||
|
req.Header.Set("Content-Type", writer.FormDataContentType())
|
||||||
|
for _, cookie := range cookies {
|
||||||
|
req.AddCookie(cookie)
|
||||||
|
}
|
||||||
|
rec := httptest.NewRecorder()
|
||||||
|
handler.ServeHTTP(rec, req)
|
||||||
|
return rec
|
||||||
|
}
|
||||||
|
|
||||||
|
func preparePostVideoHeader(t *testing.T, name string, body []byte) (preparedPostVideo, error) {
|
||||||
|
t.Helper()
|
||||||
|
header := multipartFileHeader(t, name, body)
|
||||||
|
return preparePostVideo(header)
|
||||||
|
}
|
||||||
|
|
||||||
|
func preparePostImageHeader(t *testing.T, name string, body []byte) (preparedPostImage, error) {
|
||||||
|
t.Helper()
|
||||||
|
var requestBody bytes.Buffer
|
||||||
|
writer := multipart.NewWriter(&requestBody)
|
||||||
|
part, err := writer.CreateFormFile("images", name)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if _, err := part.Write(body); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if err := writer.Close(); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
req := httptest.NewRequest(http.MethodPost, "/posts", &requestBody)
|
||||||
|
req.Header.Set("Content-Type", writer.FormDataContentType())
|
||||||
|
if err := req.ParseMultipartForm(postImageMultipartMemory); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
defer req.MultipartForm.RemoveAll()
|
||||||
|
return preparePostImage(req.MultipartForm.File["images"][0])
|
||||||
|
}
|
||||||
|
|
||||||
|
func multipartFileHeader(t *testing.T, name string, body []byte) *multipart.FileHeader {
|
||||||
|
t.Helper()
|
||||||
|
var requestBody bytes.Buffer
|
||||||
|
writer := multipart.NewWriter(&requestBody)
|
||||||
|
part, err := writer.CreateFormFile("images", name)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if _, err := part.Write(body); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if err := writer.Close(); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
req := httptest.NewRequest(http.MethodPost, "/posts", &requestBody)
|
||||||
|
req.Header.Set("Content-Type", writer.FormDataContentType())
|
||||||
|
if err := req.ParseMultipartForm(postImageMultipartMemory); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
t.Cleanup(func() { _ = req.MultipartForm.RemoveAll() })
|
||||||
|
return req.MultipartForm.File["images"][0]
|
||||||
|
}
|
||||||
|
|
||||||
|
func tinyMP4() []byte {
|
||||||
|
body := make([]byte, 16)
|
||||||
|
body[3] = 16
|
||||||
|
copy(body[4:], "ftypisom")
|
||||||
|
copy(body[12:], "isom")
|
||||||
|
return body
|
||||||
|
}
|
||||||
|
|
||||||
|
func tinyWebM() []byte {
|
||||||
|
return []byte{0x1a, 0x45, 0xdf, 0xa3, 0x01, 0x00, 0x00, 0x00}
|
||||||
|
}
|
||||||
|
|
||||||
|
func solidPNG(t *testing.T, width, height int) []byte {
|
||||||
|
t.Helper()
|
||||||
|
img := image.NewNRGBA(image.Rect(0, 0, width, height))
|
||||||
|
for y := 0; y < height; y++ {
|
||||||
|
for x := 0; x < width; x++ {
|
||||||
|
img.Set(x, y, color.NRGBA{R: 30, G: 90, B: 140, A: 255})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
var out bytes.Buffer
|
||||||
|
if err := png.Encode(&out, img); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
return out.Bytes()
|
||||||
|
}
|
||||||
|
|
||||||
|
func solidJPEG(t *testing.T, width, height int) []byte {
|
||||||
|
t.Helper()
|
||||||
|
img := image.NewNRGBA(image.Rect(0, 0, width, height))
|
||||||
|
for y := 0; y < height; y++ {
|
||||||
|
for x := 0; x < width; x++ {
|
||||||
|
img.Set(x, y, color.NRGBA{R: 140, G: 90, B: 30, A: 255})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
var out bytes.Buffer
|
||||||
|
if err := jpeg.Encode(&out, img, &jpeg.Options{Quality: 90}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
return out.Bytes()
|
||||||
|
}
|
||||||
|
|
||||||
|
type recordedImageUpload struct {
|
||||||
|
key string
|
||||||
|
contentType string
|
||||||
|
size int64
|
||||||
|
body []byte
|
||||||
|
}
|
||||||
|
|
||||||
|
type recordingImageBlob struct {
|
||||||
|
mu sync.Mutex
|
||||||
|
calls int
|
||||||
|
failAt int
|
||||||
|
uploads []recordedImageUpload
|
||||||
|
deletes []string
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *recordingImageBlob) Enabled() bool { return true }
|
||||||
|
|
||||||
|
func (b *recordingImageBlob) Upload(_ context.Context, object blob.FileUpload) (string, error) {
|
||||||
|
b.mu.Lock()
|
||||||
|
defer b.mu.Unlock()
|
||||||
|
b.calls++
|
||||||
|
if b.failAt > 0 && b.calls == b.failAt {
|
||||||
|
return "", errors.New("injected upload failure")
|
||||||
|
}
|
||||||
|
body, err := io.ReadAll(object.Body)
|
||||||
|
if err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
b.uploads = append(b.uploads, recordedImageUpload{
|
||||||
|
key: object.Key,
|
||||||
|
contentType: object.ContentType,
|
||||||
|
size: object.Size,
|
||||||
|
body: body,
|
||||||
|
})
|
||||||
|
return "https://cdn.example/" + object.Key, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *recordingImageBlob) Delete(_ context.Context, key string) error {
|
||||||
|
b.mu.Lock()
|
||||||
|
defer b.mu.Unlock()
|
||||||
|
b.deletes = append(b.deletes, key)
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *recordingImageBlob) uploadCount() int {
|
||||||
|
return len(b.recordedUploads())
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *recordingImageBlob) recordedUploads() []recordedImageUpload {
|
||||||
|
b.mu.Lock()
|
||||||
|
defer b.mu.Unlock()
|
||||||
|
return append([]recordedImageUpload(nil), b.uploads...)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *recordingImageBlob) deletedKeys() []string {
|
||||||
|
b.mu.Lock()
|
||||||
|
defer b.mu.Unlock()
|
||||||
|
return append([]string(nil), b.deletes...)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *recordingImageBlob) wasDeleted(key string) bool {
|
||||||
|
for _, deleted := range b.deletedKeys() {
|
||||||
|
if deleted == key {
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
|
||||||
|
type failingCreatePostStore struct {
|
||||||
|
store.Store
|
||||||
|
}
|
||||||
|
|
||||||
|
func (f *failingCreatePostStore) CreatePost(context.Context, *store.Post) error {
|
||||||
|
return errors.New("injected store failure")
|
||||||
|
}
|
||||||
+40
-59
@@ -5,21 +5,32 @@ import (
|
|||||||
"database/sql"
|
"database/sql"
|
||||||
"errors"
|
"errors"
|
||||||
"fmt"
|
"fmt"
|
||||||
"log"
|
|
||||||
"net/http"
|
"net/http"
|
||||||
"net/url"
|
"net/url"
|
||||||
"strings"
|
"strings"
|
||||||
"time"
|
|
||||||
|
|
||||||
"github.com/go-chi/chi/v5"
|
"github.com/go-chi/chi/v5"
|
||||||
|
"github.com/google/uuid"
|
||||||
|
|
||||||
"plumber/internal/mail"
|
"plumber/internal/events"
|
||||||
"plumber/internal/store"
|
"plumber/internal/store"
|
||||||
)
|
)
|
||||||
|
|
||||||
// handleCreatePost creates either a root question or a reply. Replies are
|
// handleCreatePost creates either a root question or a reply. Replies are
|
||||||
// limited to the root author and admins, and cannot be added to hidden threads.
|
// limited to the root author and admins, and cannot be added to hidden threads.
|
||||||
func (s *Server) handleCreatePost(w http.ResponseWriter, r *http.Request) {
|
func (s *Server) handleCreatePost(w http.ResponseWriter, r *http.Request) {
|
||||||
|
cleanup, ok := parsePostMutationForm(w, r)
|
||||||
|
if !ok {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
var media []events.Media
|
||||||
|
held := false
|
||||||
|
defer func() {
|
||||||
|
if !held {
|
||||||
|
closeHeldMedia(media)
|
||||||
|
cleanup()
|
||||||
|
}
|
||||||
|
}()
|
||||||
if !s.requireCSRF(w, r) {
|
if !s.requireCSRF(w, r) {
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
@@ -37,6 +48,7 @@ func (s *Server) handleCreatePost(w http.ResponseWriter, r *http.Request) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
post := &store.Post{
|
post := &store.Post{
|
||||||
|
ID: uuid.NewString(),
|
||||||
AuthorID: user.ID,
|
AuthorID: user.ID,
|
||||||
Body: truncateRunes(body, 12000),
|
Body: truncateRunes(body, 12000),
|
||||||
}
|
}
|
||||||
@@ -71,7 +83,14 @@ func (s *Server) handleCreatePost(w http.ResponseWriter, r *http.Request) {
|
|||||||
root = threadRoot
|
root = threadRoot
|
||||||
}
|
}
|
||||||
|
|
||||||
|
images, newKeys, media, err := s.postImagesFromForm(r.Context(), r, post.ID, nil)
|
||||||
|
if err != nil {
|
||||||
|
writePostImageRequestError(w, err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
post.Images = images
|
||||||
if err := s.store.CreatePost(r.Context(), post); err != nil {
|
if err := s.store.CreatePost(r.Context(), post); err != nil {
|
||||||
|
s.deletePostImageObjects(newKeys)
|
||||||
if errors.Is(err, store.ErrInvalidPost) {
|
if errors.Is(err, store.ErrInvalidPost) {
|
||||||
http.Error(w, "invalid post", http.StatusBadRequest)
|
http.Error(w, "invalid post", http.StatusBadRequest)
|
||||||
return
|
return
|
||||||
@@ -82,9 +101,8 @@ func (s *Server) handleCreatePost(w http.ResponseWriter, r *http.Request) {
|
|||||||
if root == nil {
|
if root == nil {
|
||||||
root = post
|
root = post
|
||||||
}
|
}
|
||||||
if parent != nil {
|
s.publishPostCreated(post, root, user, media, cleanup)
|
||||||
s.notifyPostReply(parent, root, post, user)
|
held = true
|
||||||
}
|
|
||||||
http.Redirect(
|
http.Redirect(
|
||||||
w,
|
w,
|
||||||
r,
|
r,
|
||||||
@@ -93,62 +111,14 @@ func (s *Server) handleCreatePost(w http.ResponseWriter, r *http.Request) {
|
|||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
// notifyPostReply emails the root homeowner for admin replies and the direct
|
|
||||||
// parent author for homeowner replies.
|
|
||||||
func (s *Server) notifyPostReply(
|
|
||||||
parent *store.Post,
|
|
||||||
root *store.Post,
|
|
||||||
reply *store.Post,
|
|
||||||
replyAuthor *store.User,
|
|
||||||
) {
|
|
||||||
if parent == nil ||
|
|
||||||
root == nil ||
|
|
||||||
reply == nil ||
|
|
||||||
replyAuthor == nil ||
|
|
||||||
s.cfg.Mail == nil {
|
|
||||||
return
|
|
||||||
}
|
|
||||||
if _, disabled := s.cfg.Mail.(mail.Nop); disabled {
|
|
||||||
return
|
|
||||||
}
|
|
||||||
recipientID := parent.AuthorID
|
|
||||||
if replyAuthor.Admin() {
|
|
||||||
recipientID = root.AuthorID
|
|
||||||
}
|
|
||||||
if recipientID == replyAuthor.ID {
|
|
||||||
return
|
|
||||||
}
|
|
||||||
msg := mail.PostReply{
|
|
||||||
RootID: root.ID,
|
|
||||||
RootTitle: root.Title,
|
|
||||||
ReplyID: reply.ID,
|
|
||||||
ReplyBody: reply.Body,
|
|
||||||
ReplyAuthorName: replyAuthor.Name,
|
|
||||||
}
|
|
||||||
go func() {
|
|
||||||
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
|
|
||||||
defer cancel()
|
|
||||||
recipient, err := s.store.UserByID(ctx, recipientID)
|
|
||||||
if err != nil {
|
|
||||||
log.Printf("notify reply %s: load recipient: %v", msg.ReplyID, err)
|
|
||||||
return
|
|
||||||
}
|
|
||||||
if recipient == nil || strings.TrimSpace(recipient.Email) == "" {
|
|
||||||
return
|
|
||||||
}
|
|
||||||
msg.ToEmail = recipient.Email
|
|
||||||
msg.ToName = recipient.Name
|
|
||||||
if err := s.cfg.Mail.NotifyPostReply(ctx, msg); err != nil {
|
|
||||||
log.Printf("notify reply %s: %v", msg.ReplyID, err)
|
|
||||||
return
|
|
||||||
}
|
|
||||||
log.Printf("notify reply %s: accepted", msg.ReplyID)
|
|
||||||
}()
|
|
||||||
}
|
|
||||||
|
|
||||||
// handleEditPost updates only a post's body after verifying that the current
|
// handleEditPost updates only a post's body after verifying that the current
|
||||||
// homeowner owns it or that an admin is editing an admin-authored post.
|
// homeowner owns it or that an admin is editing an admin-authored post.
|
||||||
func (s *Server) handleEditPost(w http.ResponseWriter, r *http.Request) {
|
func (s *Server) handleEditPost(w http.ResponseWriter, r *http.Request) {
|
||||||
|
cleanup, ok := parsePostMutationForm(w, r)
|
||||||
|
if !ok {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
defer cleanup()
|
||||||
if !s.requireCSRF(w, r) {
|
if !s.requireCSRF(w, r) {
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
@@ -177,8 +147,17 @@ func (s *Server) handleEditPost(w http.ResponseWriter, r *http.Request) {
|
|||||||
http.Error(w, "post body required", http.StatusBadRequest)
|
http.Error(w, "post body required", http.StatusBadRequest)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
previousImages := append([]store.PostImage(nil), post.Images...)
|
||||||
|
images, newKeys, media, err := s.postImagesFromForm(r.Context(), r, post.ID, previousImages)
|
||||||
|
if err != nil {
|
||||||
|
writePostImageRequestError(w, err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
closeHeldMedia(media)
|
||||||
post.Body = truncateRunes(body, 12000)
|
post.Body = truncateRunes(body, 12000)
|
||||||
|
post.Images = images
|
||||||
if err := s.store.UpdatePost(r.Context(), post); err != nil {
|
if err := s.store.UpdatePost(r.Context(), post); err != nil {
|
||||||
|
s.deletePostImageObjects(newKeys)
|
||||||
if errors.Is(err, store.ErrInvalidPost) {
|
if errors.Is(err, store.ErrInvalidPost) {
|
||||||
http.Error(w, "invalid post", http.StatusBadRequest)
|
http.Error(w, "invalid post", http.StatusBadRequest)
|
||||||
return
|
return
|
||||||
@@ -190,6 +169,8 @@ func (s *Server) handleEditPost(w http.ResponseWriter, r *http.Request) {
|
|||||||
http.Error(w, "could not save post", http.StatusInternalServerError)
|
http.Error(w, "could not save post", http.StatusInternalServerError)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
s.deletePostImageObjects(removedPostImageKeys(previousImages, images))
|
||||||
|
s.publishPostUpdated(post, root, nil)
|
||||||
http.Redirect(
|
http.Redirect(
|
||||||
w,
|
w,
|
||||||
r,
|
r,
|
||||||
|
|||||||
+110
-1
@@ -9,6 +9,7 @@ import (
|
|||||||
"testing"
|
"testing"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
|
"plumber/internal/events"
|
||||||
"plumber/internal/mail"
|
"plumber/internal/mail"
|
||||||
"plumber/internal/pacific"
|
"plumber/internal/pacific"
|
||||||
"plumber/internal/store"
|
"plumber/internal/store"
|
||||||
@@ -263,8 +264,12 @@ func TestEditPostRoutePermissions(t *testing.T) {
|
|||||||
func TestPostReplyNotifications(t *testing.T) {
|
func TestPostReplyNotifications(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
|
|
||||||
|
mem := store.NewMemory()
|
||||||
|
bus := events.New()
|
||||||
|
defer bus.Close()
|
||||||
recording := &mail.Recording{}
|
recording := &mail.Recording{}
|
||||||
srv, mem := newTestServer(t, Config{Mail: recording})
|
mail.Subscribe(bus, mem, recording)
|
||||||
|
srv := newTestServerStore(t, mem, Config{Events: bus})
|
||||||
handler := srv.Handler()
|
handler := srv.Handler()
|
||||||
homeowner := seedUser(t, mem, uniq("homeowner"), "hunter22", store.RoleUser)
|
homeowner := seedUser(t, mem, uniq("homeowner"), "hunter22", store.RoleUser)
|
||||||
admin := seedUser(t, mem, uniq("admin"), "hunter22", store.RoleAdmin)
|
admin := seedUser(t, mem, uniq("admin"), "hunter22", store.RoleAdmin)
|
||||||
@@ -413,6 +418,12 @@ func TestQuestionPageRendersNestedPostControls(t *testing.T) {
|
|||||||
Body: "Water under the cabinet.",
|
Body: "Water under the cabinet.",
|
||||||
City: "Oakland",
|
City: "Oakland",
|
||||||
PostDate: pacific.Today(),
|
PostDate: pacific.Today(),
|
||||||
|
Images: []store.PostImage{{
|
||||||
|
ID: "root-photo", ObjectKey: "post-images/root-photo.jpg",
|
||||||
|
PublicURL: "https://cdn.example/root-photo.jpg",
|
||||||
|
Description: "Water pooling below the shutoff valve",
|
||||||
|
Width: 1200, Height: 900,
|
||||||
|
}},
|
||||||
}
|
}
|
||||||
if err := mem.CreatePost(context.Background(), root); err != nil {
|
if err := mem.CreatePost(context.Background(), root); err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
@@ -421,6 +432,11 @@ func TestQuestionPageRendersNestedPostControls(t *testing.T) {
|
|||||||
ParentID: &root.ID,
|
ParentID: &root.ID,
|
||||||
AuthorID: homeowner.ID,
|
AuthorID: homeowner.ID,
|
||||||
Body: "The model number is 123.",
|
Body: "The model number is 123.",
|
||||||
|
Images: []store.PostImage{{
|
||||||
|
ID: "reply-photo", ObjectKey: "post-images/reply-photo.png",
|
||||||
|
PublicURL: "https://cdn.example/reply-photo.png",
|
||||||
|
Width: 900, Height: 1200,
|
||||||
|
}},
|
||||||
}
|
}
|
||||||
if err := mem.CreatePost(context.Background(), homeownerReply); err != nil {
|
if err := mem.CreatePost(context.Background(), homeownerReply); err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
@@ -429,6 +445,12 @@ func TestQuestionPageRendersNestedPostControls(t *testing.T) {
|
|||||||
ParentID: &homeownerReply.ID,
|
ParentID: &homeownerReply.ID,
|
||||||
AuthorID: admin.ID,
|
AuthorID: admin.ID,
|
||||||
Body: "Replace the cartridge.",
|
Body: "Replace the cartridge.",
|
||||||
|
Images: []store.PostImage{{
|
||||||
|
ID: "admin-photo", ObjectKey: "post-images/admin-photo.webp",
|
||||||
|
PublicURL: "https://cdn.example/admin-photo.webp",
|
||||||
|
Description: "Replacement cartridge orientation",
|
||||||
|
Width: 1000, Height: 1000,
|
||||||
|
}},
|
||||||
}
|
}
|
||||||
if err := mem.CreatePost(context.Background(), adminReply); err != nil {
|
if err := mem.CreatePost(context.Background(), adminReply); err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
@@ -460,8 +482,27 @@ func TestQuestionPageRendersNestedPostControls(t *testing.T) {
|
|||||||
`action="/posts"`,
|
`action="/posts"`,
|
||||||
`data-submit-once`,
|
`data-submit-once`,
|
||||||
`data-submit-button`,
|
`data-submit-button`,
|
||||||
|
`enctype="multipart/form-data"`,
|
||||||
|
`data-image-picker`,
|
||||||
|
`accept="image/jpeg,image/png,image/webp,video/mp4,video/webm,.mp4,.webm"`,
|
||||||
|
`aria-live="polite"`,
|
||||||
|
`name="existing_image_id" value="root-photo"`,
|
||||||
|
`name="existing_image_id" value="reply-photo"`,
|
||||||
|
`data-image-zoom`,
|
||||||
|
`href="https://cdn.example/root-photo.jpg"`,
|
||||||
|
`src="https://cdn.example/root-photo.jpg"`,
|
||||||
|
`alt="Water pooling below the shutoff valve"`,
|
||||||
|
`src="https://cdn.example/reply-photo.png"`,
|
||||||
|
`alt="Photo attached to this post"`,
|
||||||
|
`src="https://cdn.example/admin-photo.webp"`,
|
||||||
|
`loading="lazy" decoding="async"`,
|
||||||
|
`data-image-zoom-dialog`,
|
||||||
|
`<figcaption>Replacement cartridge orientation</figcaption>`,
|
||||||
`action="/posts/` + root.ID + `/edit"`,
|
`action="/posts/` + root.ID + `/edit"`,
|
||||||
`action="/posts/` + homeownerReply.ID + `/edit"`,
|
`action="/posts/` + homeownerReply.ID + `/edit"`,
|
||||||
|
`href="/questions/` + root.ID + `#post-` + root.ID + `"`,
|
||||||
|
`href="/questions/` + root.ID + `#post-` + homeownerReply.ID + `"`,
|
||||||
|
`href="/questions/` + root.ID + `#post-` + adminReply.ID + `"`,
|
||||||
`>The model number is 123A.</textarea>`,
|
`>The model number is 123A.</textarea>`,
|
||||||
`removeAttribute('open')`,
|
`removeAttribute('open')`,
|
||||||
} {
|
} {
|
||||||
@@ -469,6 +510,12 @@ func TestQuestionPageRendersNestedPostControls(t *testing.T) {
|
|||||||
t.Fatalf("question page missing %q: %s", want, body)
|
t.Fatalf("question page missing %q: %s", want, body)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
if got := strings.Count(body, ">Permalink</a>"); got != 3 {
|
||||||
|
t.Fatalf("question page rendered %d permalinks, want 3: %s", got, body)
|
||||||
|
}
|
||||||
|
if got := strings.Count(body, `data-image-picker`); got != 5 {
|
||||||
|
t.Fatalf("question page rendered %d image pickers, want 5: %s", got, body)
|
||||||
|
}
|
||||||
if strings.Contains(body, `action="/posts/`+adminReply.ID+`/edit"`) {
|
if strings.Contains(body, `action="/posts/`+adminReply.ID+`/edit"`) {
|
||||||
t.Fatalf("homeowner can edit admin reply: %s", body)
|
t.Fatalf("homeowner can edit admin reply: %s", body)
|
||||||
}
|
}
|
||||||
@@ -484,6 +531,68 @@ func TestQuestionPageRendersNestedPostControls(t *testing.T) {
|
|||||||
strings.Contains(rec.Body.String(), `action="/posts/`+root.ID+`/edit"`) {
|
strings.Contains(rec.Body.String(), `action="/posts/`+root.ID+`/edit"`) {
|
||||||
t.Fatalf("admin edit controls are incorrect: %d %s", rec.Code, rec.Body.String())
|
t.Fatalf("admin edit controls are incorrect: %d %s", rec.Code, rec.Body.String())
|
||||||
}
|
}
|
||||||
|
|
||||||
|
rec = httptest.NewRecorder()
|
||||||
|
req = httptest.NewRequest(http.MethodGet, "/", nil)
|
||||||
|
for _, cookie := range homeownerCookies {
|
||||||
|
req.AddCookie(cookie)
|
||||||
|
}
|
||||||
|
handler.ServeHTTP(rec, req)
|
||||||
|
if rec.Code != http.StatusOK {
|
||||||
|
t.Fatalf("hunt page status = %d: %s", rec.Code, rec.Body.String())
|
||||||
|
}
|
||||||
|
if strings.Contains(rec.Body.String(), "cdn.example") {
|
||||||
|
t.Fatalf("hunt page rendered post images: %s", rec.Body.String())
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestImagePickerAssetsAreServed(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
srv, _ := newTestServer(t, Config{})
|
||||||
|
handler := srv.Handler()
|
||||||
|
for _, asset := range []struct {
|
||||||
|
path string
|
||||||
|
wants []string
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
path: "/static/app.js",
|
||||||
|
wants: []string{
|
||||||
|
`const pickerSelector = "[data-image-picker]"`,
|
||||||
|
`video/mp4`,
|
||||||
|
`video/webm`,
|
||||||
|
`showModal`,
|
||||||
|
`new DataTransfer()`,
|
||||||
|
`addEventListener("drop"`,
|
||||||
|
`resetImagePicker`,
|
||||||
|
`URL.revokeObjectURL`,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
path: "/static/app.css",
|
||||||
|
wants: []string{
|
||||||
|
`.image-dropzone`,
|
||||||
|
`.image-dropzone:focus-within`,
|
||||||
|
`.image-preview-list`,
|
||||||
|
`.post-image-grid`,
|
||||||
|
`.post-video`,
|
||||||
|
`.image-zoom`,
|
||||||
|
`@media (max-width: 520px)`,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
} {
|
||||||
|
rec := httptest.NewRecorder()
|
||||||
|
req := httptest.NewRequest(http.MethodGet, asset.path, nil)
|
||||||
|
handler.ServeHTTP(rec, req)
|
||||||
|
if rec.Code != http.StatusOK {
|
||||||
|
t.Fatalf("%s status = %d", asset.path, rec.Code)
|
||||||
|
}
|
||||||
|
for _, want := range asset.wants {
|
||||||
|
if !strings.Contains(rec.Body.String(), want) {
|
||||||
|
t.Errorf("%s missing %q", asset.path, want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func waitForMail(t *testing.T, recording *mail.Recording, want int) []mail.PostReply {
|
func waitForMail(t *testing.T, recording *mail.Recording, want int) []mail.PostReply {
|
||||||
|
|||||||
+64
-5
@@ -18,10 +18,11 @@ import (
|
|||||||
"github.com/alexedwards/scs/v2"
|
"github.com/alexedwards/scs/v2"
|
||||||
"github.com/go-chi/chi/v5"
|
"github.com/go-chi/chi/v5"
|
||||||
"github.com/go-chi/chi/v5/middleware"
|
"github.com/go-chi/chi/v5/middleware"
|
||||||
|
"github.com/google/uuid"
|
||||||
|
|
||||||
"plumber/internal/blob"
|
"plumber/internal/blob"
|
||||||
|
"plumber/internal/events"
|
||||||
"plumber/internal/geo"
|
"plumber/internal/geo"
|
||||||
"plumber/internal/mail"
|
|
||||||
"plumber/internal/pacific"
|
"plumber/internal/pacific"
|
||||||
"plumber/internal/store"
|
"plumber/internal/store"
|
||||||
)
|
)
|
||||||
@@ -34,7 +35,10 @@ type Config struct {
|
|||||||
// TrustedProxies are CIDRs allowed to set X-Forwarded-For (direct peer).
|
// TrustedProxies are CIDRs allowed to set X-Forwarded-For (direct peer).
|
||||||
TrustedProxies []*net.IPNet
|
TrustedProxies []*net.IPNet
|
||||||
Blob blob.Uploader
|
Blob blob.Uploader
|
||||||
Mail mail.Notifier
|
Events events.Publisher
|
||||||
|
BaseURL string
|
||||||
|
// HoldUploadUntilDiscord keeps create-post temp files until PostedToDiscord.
|
||||||
|
HoldUploadUntilDiscord bool
|
||||||
}
|
}
|
||||||
|
|
||||||
type Server struct {
|
type Server struct {
|
||||||
@@ -103,12 +107,37 @@ type threadPostCtx struct {
|
|||||||
Depth int
|
Depth int
|
||||||
}
|
}
|
||||||
|
|
||||||
|
type imagePickerCtx struct {
|
||||||
|
ID string
|
||||||
|
Video *store.PostImage
|
||||||
|
Photos []store.PostImage
|
||||||
|
}
|
||||||
|
|
||||||
|
func splitPickerMedia(images []store.PostImage) (*store.PostImage, []store.PostImage) {
|
||||||
|
photos := make([]store.PostImage, 0, len(images))
|
||||||
|
var video *store.PostImage
|
||||||
|
for i := range images {
|
||||||
|
if images[i].Kind == store.MediaKindVideo {
|
||||||
|
img := images[i]
|
||||||
|
video = &img
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
photos = append(photos, images[i])
|
||||||
|
}
|
||||||
|
return video, photos
|
||||||
|
}
|
||||||
|
|
||||||
|
func postPhotos(images []store.PostImage) []store.PostImage {
|
||||||
|
_, photos := splitPickerMedia(images)
|
||||||
|
return photos
|
||||||
|
}
|
||||||
|
|
||||||
func New(st store.Store, sessionStore scs.Store, templateFS fs.FS, staticFS fs.FS, cfg Config) (*Server, error) {
|
func New(st store.Store, sessionStore scs.Store, templateFS fs.FS, staticFS fs.FS, cfg Config) (*Server, error) {
|
||||||
if cfg.Blob == nil {
|
if cfg.Blob == nil {
|
||||||
cfg.Blob = blob.Disabled{}
|
cfg.Blob = blob.Disabled{}
|
||||||
}
|
}
|
||||||
if cfg.Mail == nil {
|
if cfg.Events == nil {
|
||||||
cfg.Mail = mail.Nop{}
|
cfg.Events = events.Nop{}
|
||||||
}
|
}
|
||||||
funcMap := template.FuncMap{
|
funcMap := template.FuncMap{
|
||||||
"voteCtx": func(user *store.User, csrf, view, date string, post *store.Post) voteCtx {
|
"voteCtx": func(user *store.User, csrf, view, date string, post *store.Post) voteCtx {
|
||||||
@@ -117,6 +146,14 @@ func New(st store.Store, sessionStore scs.Store, templateFS fs.FS, staticFS fs.F
|
|||||||
"postCtx": func(user *store.User, csrf string, root, post *store.Post, depth int) threadPostCtx {
|
"postCtx": func(user *store.User, csrf string, root, post *store.Post, depth int) threadPostCtx {
|
||||||
return threadPostCtx{User: user, CSRF: csrf, Root: root, Post: post, Depth: depth}
|
return threadPostCtx{User: user, CSRF: csrf, Root: root, Post: post, Depth: depth}
|
||||||
},
|
},
|
||||||
|
"imagePicker": func(id string, images []store.PostImage) imagePickerCtx {
|
||||||
|
video, photos := splitPickerMedia(images)
|
||||||
|
return imagePickerCtx{ID: id, Video: video, Photos: photos}
|
||||||
|
},
|
||||||
|
"newImagePicker": func(id string) imagePickerCtx {
|
||||||
|
return imagePickerCtx{ID: id}
|
||||||
|
},
|
||||||
|
"postPhotos": postPhotos,
|
||||||
"add": func(a, b int) int { return a + b },
|
"add": func(a, b int) int { return a + b },
|
||||||
"rank": func(i int) int { return i + 1 },
|
"rank": func(i int) int { return i + 1 },
|
||||||
"isAdmin": func(u *store.User) bool { return u.Admin() },
|
"isAdmin": func(u *store.User) bool { return u.Admin() },
|
||||||
@@ -182,7 +219,7 @@ func (s *Server) Handler() http.Handler {
|
|||||||
r.Use(middleware.Recoverer)
|
r.Use(middleware.Recoverer)
|
||||||
r.Use(func(next http.Handler) http.Handler {
|
r.Use(func(next http.Handler) http.Handler {
|
||||||
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
r.Body = http.MaxBytesReader(w, r.Body, 3<<20)
|
r.Body = http.MaxBytesReader(w, r.Body, requestBodyLimit(r))
|
||||||
next.ServeHTTP(w, r)
|
next.ServeHTTP(w, r)
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
@@ -331,6 +368,18 @@ func (s *Server) handleSubmitForm(w http.ResponseWriter, r *http.Request) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (s *Server) handleSubmit(w http.ResponseWriter, r *http.Request) {
|
func (s *Server) handleSubmit(w http.ResponseWriter, r *http.Request) {
|
||||||
|
cleanup, ok := parsePostMutationForm(w, r)
|
||||||
|
if !ok {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
var media []events.Media
|
||||||
|
held := false
|
||||||
|
defer func() {
|
||||||
|
if !held {
|
||||||
|
closeHeldMedia(media)
|
||||||
|
cleanup()
|
||||||
|
}
|
||||||
|
}()
|
||||||
if !s.requireCSRF(w, r) {
|
if !s.requireCSRF(w, r) {
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
@@ -362,15 +411,25 @@ func (s *Server) handleSubmit(w http.ResponseWriter, r *http.Request) {
|
|||||||
city = truncateRunes(city, 80)
|
city = truncateRunes(city, 80)
|
||||||
}
|
}
|
||||||
post := &store.Post{
|
post := &store.Post{
|
||||||
|
ID: uuid.NewString(),
|
||||||
AuthorID: u.ID,
|
AuthorID: u.ID,
|
||||||
Title: title,
|
Title: title,
|
||||||
Body: body,
|
Body: body,
|
||||||
City: city,
|
City: city,
|
||||||
}
|
}
|
||||||
|
images, newKeys, media, err := s.postImagesFromForm(r.Context(), r, post.ID, nil)
|
||||||
|
if err != nil {
|
||||||
|
writePostImageRequestError(w, err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
post.Images = images
|
||||||
if err := s.store.CreatePost(r.Context(), post); err != nil {
|
if err := s.store.CreatePost(r.Context(), post); err != nil {
|
||||||
|
s.deletePostImageObjects(newKeys)
|
||||||
http.Error(w, "could not save question", http.StatusInternalServerError)
|
http.Error(w, "could not save question", http.StatusInternalServerError)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
s.publishPostCreated(post, post, u, media, cleanup)
|
||||||
|
held = true
|
||||||
http.Redirect(w, r, "/questions/"+url.PathEscape(post.ID), http.StatusSeeOther)
|
http.Redirect(w, r, "/questions/"+url.PathEscape(post.ID), http.StatusSeeOther)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -173,6 +173,13 @@ func TestRegisterLoginAsk(t *testing.T) {
|
|||||||
`id="submit-progress"`,
|
`id="submit-progress"`,
|
||||||
`data-submit-once`,
|
`data-submit-once`,
|
||||||
`data-submit-button`,
|
`data-submit-button`,
|
||||||
|
`enctype="multipart/form-data"`,
|
||||||
|
`data-image-picker`,
|
||||||
|
`id="submit-images"`,
|
||||||
|
`accept="image/jpeg,image/png,image/webp,video/mp4,video/webm,.mp4,.webm"`,
|
||||||
|
`Add up to 4 JPEG, PNG, or WebP images (5 MB each) and one MP4 or WebM video (25 MB).`,
|
||||||
|
`Drop photos or a video here`,
|
||||||
|
`data-video-slot`,
|
||||||
} {
|
} {
|
||||||
if !strings.Contains(rec.Body.String(), want) {
|
if !strings.Contains(rec.Body.String(), want) {
|
||||||
t.Fatalf("submit form missing %q: %s", want, rec.Body.String())
|
t.Fatalf("submit form missing %q: %s", want, rec.Body.String())
|
||||||
|
|||||||
+34
@@ -42,6 +42,29 @@ CREATE INDEX IF NOT EXISTS idx_posts_root_date
|
|||||||
ON posts(post_date, post_state)
|
ON posts(post_date, post_state)
|
||||||
WHERE parent_id IS NULL;
|
WHERE parent_id IS NULL;
|
||||||
|
|
||||||
|
CREATE TABLE IF NOT EXISTS post_images (
|
||||||
|
id TEXT PRIMARY KEY,
|
||||||
|
post_id TEXT NOT NULL REFERENCES posts(id) ON DELETE CASCADE,
|
||||||
|
object_key TEXT NOT NULL UNIQUE,
|
||||||
|
public_url TEXT NOT NULL,
|
||||||
|
description TEXT NOT NULL DEFAULT '' CHECK (char_length(description) <= 500),
|
||||||
|
kind TEXT NOT NULL DEFAULT 'image',
|
||||||
|
position SMALLINT NOT NULL,
|
||||||
|
width INTEGER NOT NULL,
|
||||||
|
height INTEGER NOT NULL,
|
||||||
|
created_at TEXT NOT NULL,
|
||||||
|
CONSTRAINT post_images_kind_check CHECK (kind IN ('image', 'video')),
|
||||||
|
CONSTRAINT post_images_width_check CHECK (width >= 0),
|
||||||
|
CONSTRAINT post_images_height_check CHECK (height >= 0),
|
||||||
|
CONSTRAINT post_images_image_dims_check CHECK (kind <> 'image' OR (width > 0 AND height > 0)),
|
||||||
|
CONSTRAINT post_images_position_check CHECK (position BETWEEN 0 AND 4),
|
||||||
|
UNIQUE (post_id, position)
|
||||||
|
);
|
||||||
|
|
||||||
|
CREATE UNIQUE INDEX IF NOT EXISTS post_images_one_video_uidx
|
||||||
|
ON post_images (post_id)
|
||||||
|
WHERE kind = 'video';
|
||||||
|
|
||||||
CREATE TABLE IF NOT EXISTS post_votes (
|
CREATE TABLE IF NOT EXISTS post_votes (
|
||||||
user_id TEXT NOT NULL REFERENCES users(id),
|
user_id TEXT NOT NULL REFERENCES users(id),
|
||||||
post_id TEXT NOT NULL REFERENCES posts(id) ON DELETE CASCADE,
|
post_id TEXT NOT NULL REFERENCES posts(id) ON DELETE CASCADE,
|
||||||
@@ -52,6 +75,17 @@ CREATE TABLE IF NOT EXISTS post_votes (
|
|||||||
CREATE INDEX IF NOT EXISTS idx_post_votes_post_id
|
CREATE INDEX IF NOT EXISTS idx_post_votes_post_id
|
||||||
ON post_votes(post_id);
|
ON post_votes(post_id);
|
||||||
|
|
||||||
|
CREATE TABLE IF NOT EXISTS discord_post_links (
|
||||||
|
post_id TEXT PRIMARY KEY REFERENCES posts(id) ON DELETE CASCADE,
|
||||||
|
discord_message_id TEXT NOT NULL UNIQUE,
|
||||||
|
discord_thread_id TEXT NOT NULL DEFAULT '',
|
||||||
|
created_at TEXT NOT NULL
|
||||||
|
);
|
||||||
|
|
||||||
|
CREATE UNIQUE INDEX IF NOT EXISTS discord_post_links_thread_uidx
|
||||||
|
ON discord_post_links (discord_thread_id)
|
||||||
|
WHERE discord_thread_id <> '';
|
||||||
|
|
||||||
CREATE TABLE IF NOT EXISTS sessions (
|
CREATE TABLE IF NOT EXISTS sessions (
|
||||||
token TEXT PRIMARY KEY,
|
token TEXT PRIMARY KEY,
|
||||||
data BYTEA NOT NULL,
|
data BYTEA NOT NULL,
|
||||||
|
|||||||
+373
@@ -749,6 +749,371 @@ input:focus, textarea:focus, .btn:focus-visible, .chip:focus-visible, .vote-btn:
|
|||||||
|
|
||||||
.post-form-actions .btn { flex: 1 1 10rem; }
|
.post-form-actions .btn { flex: 1 1 10rem; }
|
||||||
|
|
||||||
|
.image-picker {
|
||||||
|
min-width: 0;
|
||||||
|
margin: 10px 0;
|
||||||
|
padding: 0;
|
||||||
|
border: 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-picker legend {
|
||||||
|
margin-bottom: 6px;
|
||||||
|
padding: 0;
|
||||||
|
font-family: var(--mono);
|
||||||
|
font-weight: 500;
|
||||||
|
font-size: 0.68rem;
|
||||||
|
letter-spacing: 0.12em;
|
||||||
|
text-transform: uppercase;
|
||||||
|
color: var(--muted);
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-picker-hint {
|
||||||
|
margin: 0 0 8px;
|
||||||
|
color: var(--muted);
|
||||||
|
font-family: var(--mono);
|
||||||
|
font-size: 0.7rem;
|
||||||
|
line-height: 1.5;
|
||||||
|
text-wrap: pretty;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-dropzone {
|
||||||
|
position: relative;
|
||||||
|
min-height: 108px;
|
||||||
|
display: grid;
|
||||||
|
place-content: center;
|
||||||
|
gap: 8px;
|
||||||
|
padding: 18px 72px 18px 18px;
|
||||||
|
border: 1px dashed var(--zinc);
|
||||||
|
border-radius: 3px;
|
||||||
|
background: #181a1d;
|
||||||
|
transition: border-color 140ms ease, background-color 140ms ease;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-dropzone:hover,
|
||||||
|
.image-dropzone.is-dragging {
|
||||||
|
border-color: var(--signal);
|
||||||
|
background: #202124;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-dropzone:focus-within {
|
||||||
|
outline: 2px solid var(--signal);
|
||||||
|
outline-offset: 2px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-input {
|
||||||
|
position: absolute;
|
||||||
|
inset: 0;
|
||||||
|
z-index: 1;
|
||||||
|
width: 100%;
|
||||||
|
height: 100%;
|
||||||
|
opacity: 0;
|
||||||
|
cursor: pointer;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-dropzone-label {
|
||||||
|
display: grid;
|
||||||
|
gap: 3px;
|
||||||
|
pointer-events: none;
|
||||||
|
text-align: center;
|
||||||
|
color: var(--ink);
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-dropzone-label strong {
|
||||||
|
font-family: var(--sans);
|
||||||
|
font-size: 0.95rem;
|
||||||
|
font-weight: 500;
|
||||||
|
letter-spacing: 0;
|
||||||
|
text-transform: none;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-dropzone-label span {
|
||||||
|
color: var(--muted);
|
||||||
|
font-family: var(--mono);
|
||||||
|
font-size: 0.68rem;
|
||||||
|
letter-spacing: 0.05em;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-picker-count {
|
||||||
|
position: absolute;
|
||||||
|
top: 10px;
|
||||||
|
right: 10px;
|
||||||
|
padding: 3px 6px;
|
||||||
|
border: 1px solid var(--line);
|
||||||
|
color: var(--muted);
|
||||||
|
background: var(--panel);
|
||||||
|
font-family: var(--mono);
|
||||||
|
font-size: 0.65rem;
|
||||||
|
letter-spacing: 0.06em;
|
||||||
|
pointer-events: none;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-picker-error {
|
||||||
|
margin: 8px 0 0;
|
||||||
|
color: #ffd0d0;
|
||||||
|
font-family: var(--mono);
|
||||||
|
font-size: 0.72rem;
|
||||||
|
}
|
||||||
|
|
||||||
|
.video-picker-slot:not(:empty) {
|
||||||
|
margin-bottom: 10px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.video-preview {
|
||||||
|
min-width: 0;
|
||||||
|
display: grid;
|
||||||
|
grid-template-rows: auto 1fr;
|
||||||
|
border: 1px solid var(--line);
|
||||||
|
border-radius: 3px;
|
||||||
|
overflow: hidden;
|
||||||
|
background: #141516;
|
||||||
|
}
|
||||||
|
|
||||||
|
.video-preview[hidden] { display: none; }
|
||||||
|
|
||||||
|
.video-preview-media {
|
||||||
|
position: relative;
|
||||||
|
background: var(--bg);
|
||||||
|
}
|
||||||
|
|
||||||
|
.video-preview-media video,
|
||||||
|
.post-video video {
|
||||||
|
display: block;
|
||||||
|
width: 100%;
|
||||||
|
max-height: 20rem;
|
||||||
|
background: #000;
|
||||||
|
}
|
||||||
|
|
||||||
|
.post-video {
|
||||||
|
margin: 16px 0 0;
|
||||||
|
overflow: hidden;
|
||||||
|
border: 1px solid var(--line);
|
||||||
|
border-radius: 3px;
|
||||||
|
background: #141516;
|
||||||
|
}
|
||||||
|
|
||||||
|
.post-video video { max-height: 32rem; }
|
||||||
|
|
||||||
|
.post-video figcaption {
|
||||||
|
padding: 8px 10px;
|
||||||
|
border-top: 1px solid var(--line);
|
||||||
|
color: var(--muted);
|
||||||
|
font-family: var(--mono);
|
||||||
|
font-size: 0.7rem;
|
||||||
|
line-height: 1.45;
|
||||||
|
overflow-wrap: anywhere;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-preview-list {
|
||||||
|
display: grid;
|
||||||
|
grid-template-columns: repeat(2, minmax(0, 1fr));
|
||||||
|
gap: 10px;
|
||||||
|
margin-top: 10px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-preview {
|
||||||
|
min-width: 0;
|
||||||
|
display: grid;
|
||||||
|
grid-template-rows: auto 1fr;
|
||||||
|
border: 1px solid var(--line);
|
||||||
|
border-radius: 3px;
|
||||||
|
overflow: hidden;
|
||||||
|
background: #141516;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-preview[hidden] { display: none; }
|
||||||
|
|
||||||
|
.image-preview-media {
|
||||||
|
position: relative;
|
||||||
|
aspect-ratio: 4 / 3;
|
||||||
|
background: var(--bg);
|
||||||
|
overflow: hidden;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-preview-media img {
|
||||||
|
width: 100%;
|
||||||
|
height: 100%;
|
||||||
|
object-fit: cover;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-preview-tag {
|
||||||
|
position: absolute;
|
||||||
|
top: 8px;
|
||||||
|
left: 8px;
|
||||||
|
padding: 3px 6px;
|
||||||
|
background: rgba(20, 21, 22, 0.9);
|
||||||
|
border: 1px solid var(--line);
|
||||||
|
color: var(--ink);
|
||||||
|
font-family: var(--mono);
|
||||||
|
font-size: 0.6rem;
|
||||||
|
letter-spacing: 0.08em;
|
||||||
|
text-transform: uppercase;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-preview-fields {
|
||||||
|
min-width: 0;
|
||||||
|
display: grid;
|
||||||
|
align-content: start;
|
||||||
|
gap: 7px;
|
||||||
|
padding: 10px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-preview-fields label {
|
||||||
|
display: grid;
|
||||||
|
gap: 6px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-preview-name {
|
||||||
|
margin: 0;
|
||||||
|
overflow: hidden;
|
||||||
|
color: var(--muted);
|
||||||
|
font-family: var(--mono);
|
||||||
|
font-size: 0.68rem;
|
||||||
|
text-overflow: ellipsis;
|
||||||
|
white-space: nowrap;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-remove {
|
||||||
|
width: fit-content;
|
||||||
|
min-height: 44px;
|
||||||
|
padding: 0;
|
||||||
|
border: 0;
|
||||||
|
background: transparent;
|
||||||
|
color: var(--muted);
|
||||||
|
font-family: var(--mono);
|
||||||
|
font-size: 0.68rem;
|
||||||
|
letter-spacing: 0.06em;
|
||||||
|
text-decoration: underline;
|
||||||
|
text-transform: uppercase;
|
||||||
|
cursor: pointer;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-remove:hover { color: #ffd0d0; }
|
||||||
|
.image-remove:focus-visible {
|
||||||
|
outline: 2px solid var(--signal);
|
||||||
|
outline-offset: 2px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.post-image-grid {
|
||||||
|
display: grid;
|
||||||
|
grid-template-columns: repeat(2, minmax(0, 1fr));
|
||||||
|
gap: 8px;
|
||||||
|
margin-top: 16px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.post-image-grid-1 { grid-template-columns: minmax(0, 1fr); }
|
||||||
|
|
||||||
|
.post-image {
|
||||||
|
min-width: 0;
|
||||||
|
margin: 0;
|
||||||
|
overflow: hidden;
|
||||||
|
border: 1px solid var(--line);
|
||||||
|
border-radius: 3px;
|
||||||
|
background: #141516;
|
||||||
|
}
|
||||||
|
|
||||||
|
.post-image-zoom {
|
||||||
|
display: block;
|
||||||
|
color: inherit;
|
||||||
|
text-decoration: none;
|
||||||
|
cursor: zoom-in;
|
||||||
|
}
|
||||||
|
|
||||||
|
.post-image-zoom:focus-visible {
|
||||||
|
outline: 2px solid var(--signal);
|
||||||
|
outline-offset: 2px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.post-image img {
|
||||||
|
width: 100%;
|
||||||
|
height: 100%;
|
||||||
|
max-height: 32rem;
|
||||||
|
aspect-ratio: 4 / 3;
|
||||||
|
object-fit: cover;
|
||||||
|
}
|
||||||
|
|
||||||
|
.post-image-grid-1 .post-image img {
|
||||||
|
height: auto;
|
||||||
|
aspect-ratio: auto;
|
||||||
|
object-fit: contain;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-zoom {
|
||||||
|
width: min(100vw - 24px, 1100px);
|
||||||
|
max-width: none;
|
||||||
|
height: min(100vh - 24px, 100dvh);
|
||||||
|
max-height: none;
|
||||||
|
margin: auto;
|
||||||
|
padding: 12px;
|
||||||
|
border: 1px solid var(--line);
|
||||||
|
border-radius: 4px;
|
||||||
|
background: #101113;
|
||||||
|
color: var(--ink);
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-zoom::backdrop {
|
||||||
|
background: rgba(10, 11, 12, 0.88);
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-zoom-bar {
|
||||||
|
display: flex;
|
||||||
|
justify-content: flex-end;
|
||||||
|
margin: 0 0 8px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-zoom-close {
|
||||||
|
min-height: 44px;
|
||||||
|
padding: 0 12px;
|
||||||
|
border: 1px solid var(--line);
|
||||||
|
border-radius: 3px;
|
||||||
|
background: var(--panel);
|
||||||
|
color: var(--ink);
|
||||||
|
font-family: var(--mono);
|
||||||
|
font-size: 0.72rem;
|
||||||
|
letter-spacing: 0.06em;
|
||||||
|
text-transform: uppercase;
|
||||||
|
cursor: pointer;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-zoom-close:hover { border-color: var(--zinc); }
|
||||||
|
|
||||||
|
.image-zoom-close:focus-visible {
|
||||||
|
outline: 2px solid var(--signal);
|
||||||
|
outline-offset: 2px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-zoom img {
|
||||||
|
display: block;
|
||||||
|
width: 100%;
|
||||||
|
height: calc(100% - 4.5rem);
|
||||||
|
max-height: calc(100dvh - 8rem);
|
||||||
|
object-fit: contain;
|
||||||
|
background: #000;
|
||||||
|
}
|
||||||
|
|
||||||
|
.image-zoom-caption {
|
||||||
|
margin: 8px 0 0;
|
||||||
|
color: var(--muted);
|
||||||
|
font-family: var(--mono);
|
||||||
|
font-size: 0.72rem;
|
||||||
|
line-height: 1.45;
|
||||||
|
overflow-wrap: anywhere;
|
||||||
|
}
|
||||||
|
|
||||||
|
.post-image figcaption {
|
||||||
|
padding: 8px 10px;
|
||||||
|
border-top: 1px solid var(--line);
|
||||||
|
color: var(--muted);
|
||||||
|
font-family: var(--mono);
|
||||||
|
font-size: 0.7rem;
|
||||||
|
line-height: 1.45;
|
||||||
|
overflow-wrap: anywhere;
|
||||||
|
}
|
||||||
|
|
||||||
|
.post-permalink {
|
||||||
|
display: inline-flex;
|
||||||
|
align-items: center;
|
||||||
|
}
|
||||||
|
|
||||||
.post-hide {
|
.post-hide {
|
||||||
margin: 0;
|
margin: 0;
|
||||||
}
|
}
|
||||||
@@ -792,8 +1157,16 @@ input:focus, textarea:focus, .btn:focus-visible, .chip:focus-visible, .vote-btn:
|
|||||||
.panel-wrap { padding: 32px; }
|
.panel-wrap { padding: 32px; }
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@media (max-width: 520px) {
|
||||||
|
.image-preview-list,
|
||||||
|
.post-image-grid {
|
||||||
|
grid-template-columns: minmax(0, 1fr);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
@media (prefers-reduced-motion: reduce) {
|
@media (prefers-reduced-motion: reduce) {
|
||||||
.btn-primary:hover { filter: none; }
|
.btn-primary:hover { filter: none; }
|
||||||
|
.image-dropzone { transition: none; }
|
||||||
.submit-progress-bar {
|
.submit-progress-bar {
|
||||||
width: 100%;
|
width: 100%;
|
||||||
animation: none;
|
animation: none;
|
||||||
|
|||||||
+334
@@ -1,5 +1,11 @@
|
|||||||
(() => {
|
(() => {
|
||||||
const formSelector = "form[data-submit-once]";
|
const formSelector = "form[data-submit-once]";
|
||||||
|
const pickerSelector = "[data-image-picker]";
|
||||||
|
const allowedImageTypes = new Set(["image/jpeg", "image/png", "image/webp"]);
|
||||||
|
const allowedVideoTypes = new Set(["video/mp4", "video/webm"]);
|
||||||
|
const maxImageBytes = 5 * 1024 * 1024;
|
||||||
|
const maxVideoBytes = 25 * 1024 * 1024;
|
||||||
|
const pickerStates = new WeakMap();
|
||||||
|
|
||||||
function progressIndicator() {
|
function progressIndicator() {
|
||||||
return document.getElementById("submit-progress");
|
return document.getElementById("submit-progress");
|
||||||
@@ -21,6 +27,279 @@
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
function existingImageCount(picker) {
|
||||||
|
return picker.querySelectorAll("[data-existing-image]:not([hidden])").length;
|
||||||
|
}
|
||||||
|
|
||||||
|
function existingVideoCount(picker) {
|
||||||
|
return picker.querySelectorAll("[data-existing-video]:not([hidden])").length;
|
||||||
|
}
|
||||||
|
|
||||||
|
function updateImageCount(picker, state) {
|
||||||
|
const photos = existingImageCount(picker) + state.entries.length;
|
||||||
|
const videos = existingVideoCount(picker) + (state.video ? 1 : 0);
|
||||||
|
const status = picker.querySelector("[data-image-count]");
|
||||||
|
if (!status) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
status.textContent = videos
|
||||||
|
? `${photos} of ${state.max} · 1 video`
|
||||||
|
: `${photos} of ${state.max}`;
|
||||||
|
}
|
||||||
|
|
||||||
|
function showImageError(picker, message) {
|
||||||
|
const error = picker.querySelector("[data-image-error]");
|
||||||
|
if (!error) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
error.textContent = message;
|
||||||
|
error.hidden = !message;
|
||||||
|
}
|
||||||
|
|
||||||
|
function imageFileAllowed(file) {
|
||||||
|
if (allowedImageTypes.has(file.type)) {
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
if (file.type) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
return /\.(jpe?g|png|webp)$/i.test(file.name);
|
||||||
|
}
|
||||||
|
|
||||||
|
function videoFileAllowed(file) {
|
||||||
|
if (allowedVideoTypes.has(file.type)) {
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
if (file.type) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
return /\.(mp4|webm)$/i.test(file.name);
|
||||||
|
}
|
||||||
|
|
||||||
|
function sameImageFile(left, right) {
|
||||||
|
return left.name === right.name &&
|
||||||
|
left.size === right.size &&
|
||||||
|
left.lastModified === right.lastModified;
|
||||||
|
}
|
||||||
|
|
||||||
|
function syncImageInput(state) {
|
||||||
|
const transfer = new DataTransfer();
|
||||||
|
if (state.video) {
|
||||||
|
transfer.items.add(state.video.file);
|
||||||
|
}
|
||||||
|
state.entries.forEach((entry) => transfer.items.add(entry.file));
|
||||||
|
state.input.files = transfer.files;
|
||||||
|
}
|
||||||
|
|
||||||
|
function removeNewImage(picker, state, entry) {
|
||||||
|
const index = state.entries.indexOf(entry);
|
||||||
|
if (index === -1) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
state.entries.splice(index, 1);
|
||||||
|
URL.revokeObjectURL(entry.previewURL);
|
||||||
|
entry.card.remove();
|
||||||
|
syncImageInput(state);
|
||||||
|
showImageError(picker, "");
|
||||||
|
updateImageCount(picker, state);
|
||||||
|
}
|
||||||
|
|
||||||
|
function removeNewVideo(picker, state) {
|
||||||
|
if (!state.video) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
URL.revokeObjectURL(state.video.previewURL);
|
||||||
|
state.video.card.remove();
|
||||||
|
state.video = null;
|
||||||
|
syncImageInput(state);
|
||||||
|
showImageError(picker, "");
|
||||||
|
updateImageCount(picker, state);
|
||||||
|
}
|
||||||
|
|
||||||
|
function addNewImage(picker, state, file) {
|
||||||
|
const fragment = state.template.content.cloneNode(true);
|
||||||
|
const card = fragment.querySelector("[data-new-image]");
|
||||||
|
const preview = fragment.querySelector("[data-image-preview]");
|
||||||
|
const name = fragment.querySelector("[data-image-name]");
|
||||||
|
const previewURL = URL.createObjectURL(file);
|
||||||
|
preview.src = previewURL;
|
||||||
|
if (name) {
|
||||||
|
name.textContent = file.name;
|
||||||
|
}
|
||||||
|
const entry = { file, card, previewURL };
|
||||||
|
const removeButton = card.querySelector("[data-remove-image]");
|
||||||
|
removeButton.setAttribute("aria-label", `Remove selected image: ${file.name}`);
|
||||||
|
removeButton.addEventListener("click", () => {
|
||||||
|
removeNewImage(picker, state, entry);
|
||||||
|
});
|
||||||
|
state.list.appendChild(fragment);
|
||||||
|
state.entries.push(entry);
|
||||||
|
}
|
||||||
|
|
||||||
|
function addNewVideo(picker, state, file) {
|
||||||
|
const fragment = state.videoTemplate.content.cloneNode(true);
|
||||||
|
const card = fragment.querySelector("[data-new-video]");
|
||||||
|
const preview = fragment.querySelector("[data-video-preview]");
|
||||||
|
const name = fragment.querySelector("[data-image-name]");
|
||||||
|
const previewURL = URL.createObjectURL(file);
|
||||||
|
preview.src = previewURL;
|
||||||
|
preview.setAttribute("aria-label", file.name);
|
||||||
|
if (name) {
|
||||||
|
name.textContent = file.name;
|
||||||
|
}
|
||||||
|
const entry = { file, card, previewURL };
|
||||||
|
const removeButton = card.querySelector("[data-remove-image]");
|
||||||
|
removeButton.setAttribute("aria-label", `Remove selected video: ${file.name}`);
|
||||||
|
removeButton.addEventListener("click", () => {
|
||||||
|
removeNewVideo(picker, state);
|
||||||
|
});
|
||||||
|
state.videoSlot.appendChild(fragment);
|
||||||
|
state.video = entry;
|
||||||
|
}
|
||||||
|
|
||||||
|
function addImageFiles(picker, state, files) {
|
||||||
|
showImageError(picker, "");
|
||||||
|
const uniqueFiles = files.filter((file) =>
|
||||||
|
!state.entries.some((entry) => sameImageFile(entry.file, file)) &&
|
||||||
|
!(state.video && sameImageFile(state.video.file, file))
|
||||||
|
);
|
||||||
|
const videos = uniqueFiles.filter(videoFileAllowed);
|
||||||
|
const images = uniqueFiles.filter(imageFileAllowed);
|
||||||
|
if (videos.length + images.length !== uniqueFiles.length) {
|
||||||
|
showImageError(picker, "Use JPEG, PNG, or WebP photos and one MP4 or WebM video.");
|
||||||
|
syncImageInput(state);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
const availablePhotos = state.max - existingImageCount(picker) - state.entries.length;
|
||||||
|
if (images.length > availablePhotos) {
|
||||||
|
showImageError(
|
||||||
|
picker,
|
||||||
|
availablePhotos > 0
|
||||||
|
? `You can add ${availablePhotos} more ${availablePhotos === 1 ? "image" : "images"}.`
|
||||||
|
: "You already have 4 images selected."
|
||||||
|
);
|
||||||
|
syncImageInput(state);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
const availableVideos = state.maxVideos - existingVideoCount(picker) - (state.video ? 1 : 0);
|
||||||
|
if (videos.length > availableVideos) {
|
||||||
|
showImageError(
|
||||||
|
picker,
|
||||||
|
availableVideos > 0 ? "You can attach one video." : "You already have a video selected."
|
||||||
|
);
|
||||||
|
syncImageInput(state);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
for (const file of images) {
|
||||||
|
if (file.size > maxImageBytes) {
|
||||||
|
showImageError(picker, `${file.name} is larger than 5 MB.`);
|
||||||
|
syncImageInput(state);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
for (const file of videos) {
|
||||||
|
if (file.size > maxVideoBytes) {
|
||||||
|
showImageError(picker, `${file.name} is larger than 25 MB.`);
|
||||||
|
syncImageInput(state);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
videos.forEach((file) => addNewVideo(picker, state, file));
|
||||||
|
images.forEach((file) => addNewImage(picker, state, file));
|
||||||
|
syncImageInput(state);
|
||||||
|
updateImageCount(picker, state);
|
||||||
|
}
|
||||||
|
|
||||||
|
function resetImagePicker(picker) {
|
||||||
|
const state = pickerStates.get(picker);
|
||||||
|
if (!state) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
state.entries.forEach((entry) => {
|
||||||
|
URL.revokeObjectURL(entry.previewURL);
|
||||||
|
entry.card.remove();
|
||||||
|
});
|
||||||
|
state.entries = [];
|
||||||
|
if (state.video) {
|
||||||
|
URL.revokeObjectURL(state.video.previewURL);
|
||||||
|
state.video.card.remove();
|
||||||
|
state.video = null;
|
||||||
|
}
|
||||||
|
state.input.value = "";
|
||||||
|
picker.querySelectorAll("[data-existing-image], [data-existing-video]").forEach((card) => {
|
||||||
|
card.hidden = false;
|
||||||
|
card.querySelectorAll("input").forEach((input) => {
|
||||||
|
input.disabled = false;
|
||||||
|
});
|
||||||
|
});
|
||||||
|
showImageError(picker, "");
|
||||||
|
updateImageCount(picker, state);
|
||||||
|
}
|
||||||
|
|
||||||
|
function initializeImagePicker(picker) {
|
||||||
|
if (
|
||||||
|
pickerStates.has(picker) ||
|
||||||
|
typeof DataTransfer === "undefined" ||
|
||||||
|
typeof URL.createObjectURL !== "function"
|
||||||
|
) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
const input = picker.querySelector("[data-image-input]");
|
||||||
|
const dropzone = picker.querySelector("[data-image-dropzone]");
|
||||||
|
const list = picker.querySelector("[data-image-list]");
|
||||||
|
const template = picker.querySelector("[data-image-template]");
|
||||||
|
const videoSlot = picker.querySelector("[data-video-slot]");
|
||||||
|
const videoTemplate = picker.querySelector("[data-video-template]");
|
||||||
|
if (!input || !dropzone || !list || !template || !videoSlot || !videoTemplate) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
const state = {
|
||||||
|
input,
|
||||||
|
list,
|
||||||
|
template,
|
||||||
|
videoSlot,
|
||||||
|
videoTemplate,
|
||||||
|
entries: [],
|
||||||
|
video: null,
|
||||||
|
max: Number.parseInt(picker.dataset.maxImages, 10) || 4,
|
||||||
|
maxVideos: Number.parseInt(picker.dataset.maxVideos, 10) || 1,
|
||||||
|
};
|
||||||
|
pickerStates.set(picker, state);
|
||||||
|
updateImageCount(picker, state);
|
||||||
|
|
||||||
|
input.addEventListener("change", () => {
|
||||||
|
addImageFiles(picker, state, Array.from(input.files));
|
||||||
|
});
|
||||||
|
picker.querySelectorAll("[data-existing-image], [data-existing-video]").forEach((card) => {
|
||||||
|
card.querySelector("[data-remove-image]").addEventListener("click", () => {
|
||||||
|
card.hidden = true;
|
||||||
|
card.querySelectorAll("input").forEach((existingInput) => {
|
||||||
|
existingInput.disabled = true;
|
||||||
|
});
|
||||||
|
showImageError(picker, "");
|
||||||
|
updateImageCount(picker, state);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
["dragenter", "dragover"].forEach((eventName) => {
|
||||||
|
dropzone.addEventListener(eventName, (event) => {
|
||||||
|
event.preventDefault();
|
||||||
|
dropzone.classList.add("is-dragging");
|
||||||
|
});
|
||||||
|
});
|
||||||
|
["dragleave", "drop"].forEach((eventName) => {
|
||||||
|
dropzone.addEventListener(eventName, (event) => {
|
||||||
|
event.preventDefault();
|
||||||
|
dropzone.classList.remove("is-dragging");
|
||||||
|
});
|
||||||
|
});
|
||||||
|
dropzone.addEventListener("drop", (event) => {
|
||||||
|
addImageFiles(picker, state, Array.from(event.dataTransfer.files));
|
||||||
|
});
|
||||||
|
picker.closest("form")?.addEventListener("reset", () => {
|
||||||
|
window.setTimeout(() => resetImagePicker(picker), 0);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
document.addEventListener("submit", (event) => {
|
document.addEventListener("submit", (event) => {
|
||||||
const form = event.target.closest(formSelector);
|
const form = event.target.closest(formSelector);
|
||||||
if (!form) {
|
if (!form) {
|
||||||
@@ -50,9 +329,64 @@
|
|||||||
|
|
||||||
window.addEventListener("pageshow", () => {
|
window.addEventListener("pageshow", () => {
|
||||||
document.querySelectorAll(formSelector).forEach(resetForm);
|
document.querySelectorAll(formSelector).forEach(resetForm);
|
||||||
|
document.querySelectorAll(pickerSelector).forEach(resetImagePicker);
|
||||||
|
if (zoomDialog?.open) {
|
||||||
|
zoomDialog.close();
|
||||||
|
}
|
||||||
const progress = progressIndicator();
|
const progress = progressIndicator();
|
||||||
if (progress) {
|
if (progress) {
|
||||||
progress.hidden = true;
|
progress.hidden = true;
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
document.querySelectorAll(pickerSelector).forEach(initializeImagePicker);
|
||||||
|
|
||||||
|
const zoomDialog = document.querySelector("[data-image-zoom-dialog]");
|
||||||
|
const zoomImage = zoomDialog?.querySelector("[data-image-zoom-img]");
|
||||||
|
const zoomCaption = zoomDialog?.querySelector("[data-image-zoom-caption]");
|
||||||
|
let zoomTrigger = null;
|
||||||
|
|
||||||
|
function openImageZoom(link) {
|
||||||
|
if (!zoomDialog || !zoomImage || typeof zoomDialog.showModal !== "function") {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
const photo = link.querySelector("img");
|
||||||
|
if (!photo) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
zoomTrigger = link;
|
||||||
|
zoomImage.src = link.href;
|
||||||
|
zoomImage.alt = photo.alt || "";
|
||||||
|
if (zoomCaption) {
|
||||||
|
zoomCaption.textContent = photo.alt || "";
|
||||||
|
}
|
||||||
|
if (!zoomDialog.open) {
|
||||||
|
zoomDialog.showModal();
|
||||||
|
}
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
document.addEventListener("click", (event) => {
|
||||||
|
const link = event.target.closest("[data-image-zoom]");
|
||||||
|
if (!link) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
if (openImageZoom(link)) {
|
||||||
|
event.preventDefault();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
zoomDialog?.addEventListener("click", (event) => {
|
||||||
|
if (event.target === zoomDialog) {
|
||||||
|
zoomDialog.close();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
zoomDialog?.addEventListener("close", () => {
|
||||||
|
if (zoomImage) {
|
||||||
|
zoomImage.removeAttribute("src");
|
||||||
|
}
|
||||||
|
zoomTrigger?.focus();
|
||||||
|
zoomTrigger = null;
|
||||||
|
});
|
||||||
})();
|
})();
|
||||||
|
|||||||
@@ -73,6 +73,13 @@
|
|||||||
<footer class="site-footer">
|
<footer class="site-footer">
|
||||||
<p>This site is not a substitute for a licensed plumber. Advice is general and based on the question as written. If you have a gas leak, flooding, or another emergency, leave the area if needed and call 911.</p>
|
<p>This site is not a substitute for a licensed plumber. Advice is general and based on the question as written. If you have a gas leak, flooding, or another emergency, leave the area if needed and call 911.</p>
|
||||||
</footer>
|
</footer>
|
||||||
|
<dialog class="image-zoom" data-image-zoom-dialog aria-labelledby="image-zoom-caption">
|
||||||
|
<form method="dialog" class="image-zoom-bar">
|
||||||
|
<button class="image-zoom-close" value="close">Close</button>
|
||||||
|
</form>
|
||||||
|
<img data-image-zoom-img alt="">
|
||||||
|
<p id="image-zoom-caption" class="image-zoom-caption" data-image-zoom-caption></p>
|
||||||
|
</dialog>
|
||||||
</body>
|
</body>
|
||||||
</html>
|
</html>
|
||||||
{{end}}
|
{{end}}
|
||||||
|
|||||||
@@ -0,0 +1,141 @@
|
|||||||
|
{{define "imagePicker"}}
|
||||||
|
<fieldset class="image-picker" data-image-picker data-max-images="4" data-max-videos="1">
|
||||||
|
<legend>Photos and video <span class="optional">(optional)</span></legend>
|
||||||
|
<p id="{{.ID}}-hint" class="image-picker-hint">
|
||||||
|
Add up to 4 JPEG, PNG, or WebP images (5 MB each) and one MP4 or WebM video (25 MB).
|
||||||
|
</p>
|
||||||
|
<div class="video-picker-slot" data-video-slot>
|
||||||
|
{{if .Video}}
|
||||||
|
<article class="video-preview" data-video-card data-existing-video>
|
||||||
|
<div class="video-preview-media">
|
||||||
|
<video src="{{.Video.PublicURL}}" controls playsinline preload="metadata"
|
||||||
|
{{if .Video.Description}}aria-label="{{.Video.Description}}"{{else}}aria-label="Saved video"{{end}}></video>
|
||||||
|
<span class="image-preview-tag">Saved</span>
|
||||||
|
</div>
|
||||||
|
<div class="image-preview-fields">
|
||||||
|
<input type="hidden" name="existing_image_id" value="{{.Video.ID}}">
|
||||||
|
<label for="{{.ID}}-video-description-{{.Video.ID}}">
|
||||||
|
Video description <span class="optional">(optional)</span>
|
||||||
|
</label>
|
||||||
|
<input id="{{.ID}}-video-description-{{.Video.ID}}" type="text"
|
||||||
|
name="existing_image_description" maxlength="500"
|
||||||
|
value="{{.Video.Description}}" placeholder="What should people notice?">
|
||||||
|
<button class="image-remove" type="button" data-remove-image
|
||||||
|
aria-label="Remove video{{if .Video.Description}}: {{.Video.Description}}{{end}}">
|
||||||
|
Remove
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
</article>
|
||||||
|
{{end}}
|
||||||
|
</div>
|
||||||
|
<div class="image-dropzone" data-image-dropzone>
|
||||||
|
<input id="{{.ID}}" class="image-input" type="file" name="images"
|
||||||
|
accept="image/jpeg,image/png,image/webp,video/mp4,video/webm,.mp4,.webm" multiple
|
||||||
|
aria-describedby="{{.ID}}-hint {{.ID}}-status {{.ID}}-error"
|
||||||
|
data-image-input>
|
||||||
|
<label class="image-dropzone-label" for="{{.ID}}">
|
||||||
|
<strong>Drop photos or a video here</strong>
|
||||||
|
<span>or click to browse</span>
|
||||||
|
</label>
|
||||||
|
<span id="{{.ID}}-status" class="image-picker-count" role="status"
|
||||||
|
aria-live="polite" data-image-count>{{len .Photos}} of 4{{if .Video}} · 1 video{{end}}</span>
|
||||||
|
</div>
|
||||||
|
<p id="{{.ID}}-error" class="image-picker-error" role="alert"
|
||||||
|
data-image-error hidden></p>
|
||||||
|
|
||||||
|
<div class="image-preview-list" data-image-list>
|
||||||
|
{{range .Photos}}
|
||||||
|
<article class="image-preview" data-image-card data-existing-image>
|
||||||
|
<div class="image-preview-media">
|
||||||
|
<img src="{{.PublicURL}}" alt="" width="{{.Width}}" height="{{.Height}}">
|
||||||
|
<span class="image-preview-tag">Saved</span>
|
||||||
|
</div>
|
||||||
|
<div class="image-preview-fields">
|
||||||
|
<input type="hidden" name="existing_image_id" value="{{.ID}}">
|
||||||
|
<label for="{{$.ID}}-description-{{.ID}}">
|
||||||
|
Image description <span class="optional">(optional)</span>
|
||||||
|
</label>
|
||||||
|
<input id="{{$.ID}}-description-{{.ID}}" type="text"
|
||||||
|
name="existing_image_description" maxlength="500"
|
||||||
|
value="{{.Description}}" placeholder="What should people notice?">
|
||||||
|
<button class="image-remove" type="button" data-remove-image
|
||||||
|
aria-label="Remove image{{if .Description}}: {{.Description}}{{end}}">
|
||||||
|
Remove
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
</article>
|
||||||
|
{{end}}
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<template data-image-template>
|
||||||
|
<article class="image-preview" data-image-card data-new-image>
|
||||||
|
<div class="image-preview-media">
|
||||||
|
<img alt="" data-image-preview>
|
||||||
|
<span class="image-preview-tag">New</span>
|
||||||
|
</div>
|
||||||
|
<div class="image-preview-fields">
|
||||||
|
<p class="image-preview-name" data-image-name></p>
|
||||||
|
<label>
|
||||||
|
Image description <span class="optional">(optional)</span>
|
||||||
|
<input type="text" name="image_description" maxlength="500"
|
||||||
|
placeholder="What should people notice?">
|
||||||
|
</label>
|
||||||
|
<button class="image-remove" type="button" data-remove-image
|
||||||
|
aria-label="Remove selected image">
|
||||||
|
Remove
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
</article>
|
||||||
|
</template>
|
||||||
|
<template data-video-template>
|
||||||
|
<article class="video-preview" data-video-card data-new-video>
|
||||||
|
<div class="video-preview-media">
|
||||||
|
<video controls playsinline preload="metadata" data-video-preview></video>
|
||||||
|
<span class="image-preview-tag">New</span>
|
||||||
|
</div>
|
||||||
|
<div class="image-preview-fields">
|
||||||
|
<p class="image-preview-name" data-image-name></p>
|
||||||
|
<label>
|
||||||
|
Video description <span class="optional">(optional)</span>
|
||||||
|
<input type="text" name="image_description" maxlength="500"
|
||||||
|
placeholder="What should people notice?">
|
||||||
|
</label>
|
||||||
|
<button class="image-remove" type="button" data-remove-image
|
||||||
|
aria-label="Remove selected video">
|
||||||
|
Remove
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
</article>
|
||||||
|
</template>
|
||||||
|
<noscript>
|
||||||
|
<p class="image-picker-hint">Image previews and removal while editing require JavaScript.</p>
|
||||||
|
</noscript>
|
||||||
|
</fieldset>
|
||||||
|
{{end}}
|
||||||
|
|
||||||
|
{{define "postImages"}}
|
||||||
|
{{range .Images}}
|
||||||
|
{{if eq .Kind "video"}}
|
||||||
|
<figure class="post-video">
|
||||||
|
<video src="{{.PublicURL}}" controls playsinline preload="metadata"
|
||||||
|
{{if .Description}}aria-label="{{.Description}}"{{else}}aria-label="Video attached to this post"{{end}}></video>
|
||||||
|
{{if .Description}}<figcaption>{{.Description}}</figcaption>{{end}}
|
||||||
|
</figure>
|
||||||
|
{{end}}
|
||||||
|
{{end}}
|
||||||
|
{{$photos := postPhotos .Images}}
|
||||||
|
{{if $photos}}
|
||||||
|
<div class="post-image-grid post-image-grid-{{len $photos}}">
|
||||||
|
{{range $photos}}
|
||||||
|
<figure class="post-image">
|
||||||
|
<a class="post-image-zoom" href="{{.PublicURL}}" data-image-zoom>
|
||||||
|
<img src="{{.PublicURL}}" width="{{.Width}}" height="{{.Height}}"
|
||||||
|
alt="{{if .Description}}{{.Description}}{{else}}Photo attached to this post{{end}}"
|
||||||
|
loading="lazy" decoding="async">
|
||||||
|
</a>
|
||||||
|
{{if .Description}}<figcaption>{{.Description}}</figcaption>{{end}}
|
||||||
|
</figure>
|
||||||
|
{{end}}
|
||||||
|
</div>
|
||||||
|
{{end}}
|
||||||
|
{{end}}
|
||||||
@@ -3,12 +3,13 @@
|
|||||||
{{if canReply .User .Root}}
|
{{if canReply .User .Root}}
|
||||||
<details class="post-composer">
|
<details class="post-composer">
|
||||||
<summary>Reply</summary>
|
<summary>Reply</summary>
|
||||||
<form class="post-form" method="post" action="/posts"
|
<form class="post-form" method="post" action="/posts" enctype="multipart/form-data"
|
||||||
data-submit-once data-submitting-label="Posting…">
|
data-submit-once data-submitting-label="Posting…">
|
||||||
<input type="hidden" name="_csrf" value="{{.CSRF}}">
|
<input type="hidden" name="_csrf" value="{{.CSRF}}">
|
||||||
<input type="hidden" name="parent_id" value="{{.Post.ID}}">
|
<input type="hidden" name="parent_id" value="{{.Post.ID}}">
|
||||||
<label for="reply-{{.Post.ID}}">Reply to {{.Post.AuthorName}}</label>
|
<label for="reply-{{.Post.ID}}">Reply to {{.Post.AuthorName}}</label>
|
||||||
<textarea id="reply-{{.Post.ID}}" name="body" rows="5" required maxlength="12000"></textarea>
|
<textarea id="reply-{{.Post.ID}}" name="body" rows="5" required maxlength="12000"></textarea>
|
||||||
|
{{template "imagePicker" (newImagePicker (printf "reply-images-%s" .Post.ID))}}
|
||||||
<div class="post-form-actions">
|
<div class="post-form-actions">
|
||||||
<button type="submit" class="btn btn-primary" data-submit-button>Post reply</button>
|
<button type="submit" class="btn btn-primary" data-submit-button>Post reply</button>
|
||||||
<button type="reset" class="btn btn-ghost"
|
<button type="reset" class="btn btn-ghost"
|
||||||
@@ -20,19 +21,25 @@
|
|||||||
{{if canEditPost .User .Post}}
|
{{if canEditPost .User .Post}}
|
||||||
<details class="post-composer">
|
<details class="post-composer">
|
||||||
<summary>Edit</summary>
|
<summary>Edit</summary>
|
||||||
<form class="post-form" method="post" action="/posts/{{.Post.ID}}/edit">
|
<form class="post-form" method="post" action="/posts/{{.Post.ID}}/edit"
|
||||||
|
enctype="multipart/form-data"
|
||||||
|
data-submit-once data-submitting-label="Saving…">
|
||||||
<input type="hidden" name="_csrf" value="{{.CSRF}}">
|
<input type="hidden" name="_csrf" value="{{.CSRF}}">
|
||||||
<label for="edit-{{.Post.ID}}">Edit post</label>
|
<label for="edit-{{.Post.ID}}">Edit post</label>
|
||||||
<textarea id="edit-{{.Post.ID}}" name="body" rows="5" required
|
<textarea id="edit-{{.Post.ID}}" name="body" rows="5" required
|
||||||
maxlength="12000">{{.Post.Body}}</textarea>
|
maxlength="12000">{{.Post.Body}}</textarea>
|
||||||
|
{{template "imagePicker" (imagePicker (printf "edit-images-%s" .Post.ID) .Post.Images)}}
|
||||||
<div class="post-form-actions">
|
<div class="post-form-actions">
|
||||||
<button type="submit" class="btn btn-primary">Save changes</button>
|
<button type="submit" class="btn btn-primary" data-submit-button>Save changes</button>
|
||||||
<button type="reset" class="btn btn-ghost"
|
<button type="reset" class="btn btn-ghost"
|
||||||
onclick="this.closest('details').removeAttribute('open')">Cancel</button>
|
onclick="this.closest('details').removeAttribute('open')">Cancel</button>
|
||||||
</div>
|
</div>
|
||||||
</form>
|
</form>
|
||||||
</details>
|
</details>
|
||||||
{{end}}
|
{{end}}
|
||||||
|
<a class="linkish post-permalink"
|
||||||
|
href="/questions/{{.Root.ID}}#post-{{.Post.ID}}"
|
||||||
|
aria-label="Permanent link to post by {{.Post.AuthorName}}">Permalink</a>
|
||||||
{{if and (not .Post.ParentID) (isAdmin .User)}}
|
{{if and (not .Post.ParentID) (isAdmin .User)}}
|
||||||
<form class="post-hide" method="post" action="/questions/{{.Post.ID}}/hide">
|
<form class="post-hide" method="post" action="/questions/{{.Post.ID}}/hide">
|
||||||
<input type="hidden" name="_csrf" value="{{.CSRF}}">
|
<input type="hidden" name="_csrf" value="{{.CSRF}}">
|
||||||
@@ -56,6 +63,7 @@
|
|||||||
</p>
|
</p>
|
||||||
</header>
|
</header>
|
||||||
<p class="post-body">{{.Post.Body}}</p>
|
<p class="post-body">{{.Post.Body}}</p>
|
||||||
|
{{template "postImages" .Post}}
|
||||||
{{template "postActions" .}}
|
{{template "postActions" .}}
|
||||||
{{if .Post.Replies}}
|
{{if .Post.Replies}}
|
||||||
<div class="post-replies">
|
<div class="post-replies">
|
||||||
|
|||||||
@@ -17,6 +17,7 @@
|
|||||||
{{if isEdited .Question}}<span class="edited">Edited</span>{{end}}
|
{{if isEdited .Question}}<span class="edited">Edited</span>{{end}}
|
||||||
</p>
|
</p>
|
||||||
<p class="post-body">{{.Question.Body}}</p>
|
<p class="post-body">{{.Question.Body}}</p>
|
||||||
|
{{template "postImages" .Question}}
|
||||||
{{template "postActions" (postCtx .User .CSRF .Question .Question 0)}}
|
{{template "postActions" (postCtx .User .CSRF .Question .Question 0)}}
|
||||||
</div>
|
</div>
|
||||||
</article>
|
</article>
|
||||||
|
|||||||
@@ -4,7 +4,7 @@
|
|||||||
<h1>Ask a question</h1>
|
<h1>Ask a question</h1>
|
||||||
<p class="lede">It lands on today’s hunt (Pacific time). People vote; the ranking resets at midnight PT.</p>
|
<p class="lede">It lands on today’s hunt (Pacific time). People vote; the ranking resets at midnight PT.</p>
|
||||||
{{if .Error}}<p class="banner error" role="alert">{{.Error}}</p>{{end}}
|
{{if .Error}}<p class="banner error" role="alert">{{.Error}}</p>{{end}}
|
||||||
<form class="ask" method="post" action="/submit"
|
<form class="ask" method="post" action="/submit" enctype="multipart/form-data"
|
||||||
data-submit-once data-submitting-label="Posting…">
|
data-submit-once data-submitting-label="Posting…">
|
||||||
<input type="hidden" name="_csrf" value="{{.CSRF}}">
|
<input type="hidden" name="_csrf" value="{{.CSRF}}">
|
||||||
<label for="title">Title</label>
|
<label for="title">Title</label>
|
||||||
@@ -13,6 +13,7 @@
|
|||||||
<textarea id="body" name="body" rows="8" required maxlength="8000" placeholder="Age of the house, what you already tried, where you are in the Bay if it helps.">{{.BodyVal}}</textarea>
|
<textarea id="body" name="body" rows="8" required maxlength="8000" placeholder="Age of the house, what you already tried, where you are in the Bay if it helps.">{{.BodyVal}}</textarea>
|
||||||
<label for="city">City <span class="optional">(optional)</span></label>
|
<label for="city">City <span class="optional">(optional)</span></label>
|
||||||
<input id="city" name="city" type="text" maxlength="80" value="{{.CityVal}}" placeholder="Oakland">
|
<input id="city" name="city" type="text" maxlength="80" value="{{.CityVal}}" placeholder="Oakland">
|
||||||
|
{{template "imagePicker" (newImagePicker "submit-images")}}
|
||||||
<button type="submit" class="btn btn-primary" data-submit-button>Submit to today’s hunt</button>
|
<button type="submit" class="btn btn-primary" data-submit-button>Submit to today’s hunt</button>
|
||||||
</form>
|
</form>
|
||||||
</main>
|
</main>
|
||||||
|
|||||||
Reference in New Issue
Block a user